linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Tony Luck <tony.luck@intel.com>,
	gong.chen@linux.intel.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/7] mm/hwpoison: add '#' to madvise_hwpoison
Date: Fri, 23 Aug 2013 10:38:54 -0400	[thread overview]
Message-ID: <1377268734-8oq8947y-mutt-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <1377253841-17620-7-git-send-email-liwanp@linux.vnet.ibm.com>

On Fri, Aug 23, 2013 at 06:30:41PM +0800, Wanpeng Li wrote:
> Add '#' to madvise_hwpoison.
> 
> Before patch:
> 
> [   95.892866] Injecting memory failure for page 19d0 at b7786000
> [   95.893151] MCE 0x19d0: non LRU page recovery: Ignored
> 
> After patch:
> 
> [   95.892866] Injecting memory failure for page 0x19d0 at 0xb7786000
> [   95.893151] MCE 0x19d0: non LRU page recovery: Ignored
> 
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
>  mm/madvise.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/madvise.c b/mm/madvise.c
> index 95795df..588bb19 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -353,14 +353,14 @@ static int madvise_hwpoison(int bhv, unsigned long start, unsigned long end)
>  		if (ret != 1)
>  			return ret;
>  		if (bhv == MADV_SOFT_OFFLINE) {
> -			printk(KERN_INFO "Soft offlining page %lx at %lx\n",
> +			pr_info("Soft offlining page %#lx at %#lx\n",
>  				page_to_pfn(p), start);
>  			ret = soft_offline_page(p, MF_COUNT_INCREASED);
>  			if (ret)
>  				break;
>  			continue;
>  		}
> -		printk(KERN_INFO "Injecting memory failure for page %lx at %lx\n",
> +		pr_info("Injecting memory failure for page %#lx at %#lx\n",
>  		       page_to_pfn(p), start);
>  		/* Ignore return value for now */
>  		memory_failure(page_to_pfn(p), 0, MF_COUNT_INCREASED);
> -- 
> 1.8.1.2
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2013-08-23 14:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 10:30 [PATCH v2 1/7] mm/hwpoison: fix lose PG_dirty flag for errors on mlocked pages Wanpeng Li
2013-08-23 10:30 ` [PATCH v2 2/7] mm/hwpoison: don't need to hold compound lock for hugetlbfs page Wanpeng Li
2013-08-23 10:30 ` [PATCH v2 3/7] mm/hwpoison: fix race against poison thp Wanpeng Li
2013-08-23 10:30 ` [PATCH v2 4/7] mm/hwpoison: replacing atomic_long_sub() with atomic_long_dec() Wanpeng Li
2013-08-23 14:35   ` Naoya Horiguchi
2013-08-23 10:30 ` [PATCH v2 5/7] mm/hwpoison: don't set migration type twice to avoid hold heavy contend zone->lock Wanpeng Li
2013-08-23 14:36   ` Naoya Horiguchi
2013-08-25 23:23     ` Wanpeng Li
2013-08-25 23:23     ` Wanpeng Li
2013-08-23 10:30 ` [PATCH v2 6/7] mm/hwpoison: drop forward reference declarations __soft_offline_page() Wanpeng Li
2013-08-23 10:30 ` [PATCH v2 7/7] mm/hwpoison: add '#' to madvise_hwpoison Wanpeng Li
2013-08-23 14:38   ` Naoya Horiguchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377268734-8oq8947y-mutt-n-horiguchi@ah.jp.nec.com \
    --to=n-horiguchi@ah.jp.nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=fengguang.wu@intel.com \
    --cc=gong.chen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liwanp@linux.vnet.ibm.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox