From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx144.postini.com [74.125.245.144]) by kanga.kvack.org (Postfix) with SMTP id 011E96B0032 for ; Mon, 12 Aug 2013 09:21:08 -0400 (EDT) Message-ID: <1376313658.2457.1.camel@buesod1.americas.hpqcorp.net> Subject: Re: [PATCH v2 01/20] mm, hugetlb: protect reserved pages when soft offlining a hugepage From: Davidlohr Bueso Date: Mon, 12 Aug 2013 06:20:58 -0700 In-Reply-To: <1376040398-11212-2-git-send-email-iamjoonsoo.kim@lge.com> References: <1376040398-11212-1-git-send-email-iamjoonsoo.kim@lge.com> <1376040398-11212-2-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Andrew Morton , Rik van Riel , Mel Gorman , Michal Hocko , "Aneesh Kumar K.V" , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Wanpeng Li , Naoya Horiguchi , Hillf Danton On Fri, 2013-08-09 at 18:26 +0900, Joonsoo Kim wrote: > Don't use the reserve pool when soft offlining a hugepage. > Check we have free pages outside the reserve pool before we > dequeue the huge page. Otherwise, we can steal other's reserve page. > > Reviewed-by: Aneesh Kumar > Signed-off-by: Joonsoo Kim Reviewed-by: Davidlohr Bueso > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 6782b41..d971233 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -935,10 +935,11 @@ static struct page *alloc_buddy_huge_page(struct hstate *h, int nid) > */ > struct page *alloc_huge_page_node(struct hstate *h, int nid) > { > - struct page *page; > + struct page *page = NULL; > > spin_lock(&hugetlb_lock); > - page = dequeue_huge_page_node(h, nid); > + if (h->free_huge_pages - h->resv_huge_pages > 0) > + page = dequeue_huge_page_node(h, nid); > spin_unlock(&hugetlb_lock); > > if (!page) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org