From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx158.postini.com [74.125.245.158]) by kanga.kvack.org (Postfix) with SMTP id 427036B0032 for ; Tue, 23 Jul 2013 15:16:01 -0400 (EDT) Message-ID: <1374606958.10171.2.camel@joe-AO722> Subject: Re: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT. From: Joe Perches Date: Tue, 23 Jul 2013 12:15:58 -0700 In-Reply-To: <20130723184843.GG21100@mtj.dyndns.org> References: <1374220774-29974-1-git-send-email-tangchen@cn.fujitsu.com> <1374220774-29974-2-git-send-email-tangchen@cn.fujitsu.com> <20130723184843.GG21100@mtj.dyndns.org> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: Tang Chen , tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org On Tue, 2013-07-23 at 14:48 -0400, Tejun Heo wrote: > On Fri, Jul 19, 2013 at 03:59:14PM +0800, Tang Chen wrote: > > The Hot-Pluggable field in SRAT suggests if the memory could be > > hotplugged while the system is running. Print it as well when > > parsing SRAT will help users to know which memory is hotpluggable. [] > a nit below > > > + pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx] %s\n", > > + node, pxm, > > + (unsigned long long) start, (unsigned long long) end - 1, > > + hotpluggable ? "Hot Pluggable" : ""); > > The following would be more conventional. > > "...10Lx]%s\n", ..., hotpluggable ? " Hot Pluggable" : "" > > Also, isn't "Hot Pluggable" a bit too verbose? "hotplug" should be > fine, I think. It's also a tiny nit better to use: pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s\n", node, pxm, (unsigned long long) start, (unsigned long long) end - 1, hotpluggable ? " Hot Pluggable" : ""); (or " hotplug") so there's no space before newline. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org