From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx149.postini.com [74.125.245.149]) by kanga.kvack.org (Postfix) with SMTP id 2B31E6B0031 for ; Wed, 17 Jul 2013 14:08:30 -0400 (EDT) Date: Wed, 17 Jul 2013 14:08:25 -0400 From: Naoya Horiguchi Message-ID: <1374084505-2en57dv0-mutt-n-horiguchi@ah.jp.nec.com> In-Reply-To: <20130717180249.19F1BE0090@blue.fi.intel.com> References: <1374012587-whdyhveh-mutt-n-horiguchi@ah.jp.nec.com> <1374078950-8o0ev16q-mutt-n-horiguchi@ah.jp.nec.com> <20130717180249.19F1BE0090@blue.fi.intel.com> Subject: Re: [PATCH] mm/swap.c: clear PageActive before adding pages onto unevictable list (Re: 3.11.0-rc1: kernel BUG at mm/migrate.c:458 in page migration) Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , linux-kernel@vger.kernel.org, KOSAKI Motohiro On Wed, Jul 17, 2013 at 09:02:49PM +0300, Kirill A. Shutemov wrote: ... > > --- > > From: Naoya Horiguchi > > Date: Wed, 17 Jul 2013 11:49:56 -0400 > > Subject: [PATCH] mm/swap.c: clear PageActive before adding pages onto > > unevictable list > > > > As a result of v3.10-3600-g13f7f78 "mm: pagevec: defer deciding which LRU > > to add a page to until pagevec drain time," pages on unevictable lists can > > have both of PageActive and PageUnevictable set. This is not only confusing, > > but also corrupts page migration and shrink_[in]active_list. > > > > This patch fixes the problem by adding ClearPageActive before adding pages > > into unevictable list. It also cleans up VM_BUG_ONs. > > > > Signed-off-by: Naoya Horiguchi > > Cc: stable@vger.kernel.org # 3.10 > > Looks good to me. > > Acked-by: Kirill A. Shutemov Thanks. > One more patch related to the topic: > > https://lkml.org/lkml/2013/7/15/140 Yes, that's why I added CC to you :) Naoya -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org