From: Tim Chen <tim.c.chen@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Peter Hurley <peter@hurleysoftware.com>,
Davidlohr Bueso <davidlohr.bueso@hp.com>,
Alex Shi <alex.shi@intel.com>,
Michel Lespinasse <walken@google.com>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Matthew R Wilcox <matthew.r.wilcox@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 2/2] rwsem: do optimistic spinning for writer lock acquisition
Date: Tue, 25 Jun 2013 09:00:06 -0700 [thread overview]
Message-ID: <1372176006.22432.96.camel@schen9-DESK> (raw)
In-Reply-To: <20130625073739.GX28407@twins.programming.kicks-ass.net>
On Tue, 2013-06-25 at 09:37 +0200, Peter Zijlstra wrote:
> On Mon, Jun 24, 2013 at 01:17:45PM -0700, Tim Chen wrote:
> > On second thought, I agree with you. I should change this to
> > something like
> >
> > int retval = true;
> > task_struct *sem_owner;
> >
> > /* Spin only if active writer running */
> > if (!sem->owner)
> > return false;
> >
> > rcu_read_lock();
> > sem_owner = sem->owner;
>
> That should be: sem_owner = ACCESS_ONCE(sem->owner); to make sure the
> compiler doesn't try and be clever and rereads.
Thanks. Will incorporate this in next version of the patch.
Tim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-25 16:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1371855277.git.tim.c.chen@linux.intel.com>
2013-06-21 23:51 ` [PATCH 1/2] rwsem: check the lock before cpmxchg in down_write_trylock and rwsem_do_wake Tim Chen
2013-06-22 0:10 ` Alex Shi
2013-06-22 0:15 ` Davidlohr Bueso
2013-06-24 16:34 ` Tim Chen
2013-06-22 7:21 ` Peter Hurley
2013-06-23 1:16 ` Alex Shi
2013-06-23 5:10 ` Andi Kleen
2013-06-23 11:52 ` Alex Shi
2013-06-21 23:51 ` [PATCH 2/2] rwsem: do optimistic spinning for writer lock acquisition Tim Chen
2013-06-22 0:00 ` Davidlohr Bueso
2013-06-22 7:57 ` Peter Hurley
2013-06-23 20:03 ` Davidlohr Bueso
2013-06-24 17:11 ` Tim Chen
2013-06-24 18:49 ` Peter Hurley
2013-06-24 19:13 ` Tim Chen
2013-06-24 20:32 ` Peter Hurley
2013-06-24 20:17 ` Tim Chen
2013-06-24 20:48 ` Peter Hurley
2013-06-24 21:30 ` Tim Chen
2013-06-25 7:37 ` Peter Zijlstra
2013-06-25 16:00 ` Tim Chen [this message]
2013-06-24 21:58 ` Tim Chen
2013-06-24 22:08 ` Peter Hurley
2013-06-24 8:46 ` Peter Zijlstra
2013-06-24 16:36 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372176006.22432.96.camel@schen9-DESK \
--to=tim.c.chen@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=andi@firstfloor.org \
--cc=dave.hansen@intel.com \
--cc=davidlohr.bueso@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mingo@elte.hu \
--cc=peter@hurleysoftware.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox