linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Davidlohr Bueso <davidlohr.bueso@hp.com>
To: akpm@linux-foundation.org, riel@redhat.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Davidlohr Bueso <davidlohr.bueso@hp.com>
Subject: [PATCH 11/11] ipc: document general ipc locking scheme
Date: Tue, 18 Jun 2013 18:18:36 -0700	[thread overview]
Message-ID: <1371604716-3439-12-git-send-email-davidlohr.bueso@hp.com> (raw)
In-Reply-To: <1371604716-3439-1-git-send-email-davidlohr.bueso@hp.com>

As suggested by Andrew, add a generic initial locking scheme
used throughout all sysv ipc mechanisms. Documenting the ids
rwsem, how rcu can be enough to do the initial checks and when
to actually acquire the kern_ipc_perm.lock spinlock.

I found that adding it to util.c was generic enough.

Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
---
 ipc/util.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/ipc/util.c b/ipc/util.c
index 8f12fe3..639bf38 100644
--- a/ipc/util.c
+++ b/ipc/util.c
@@ -15,6 +15,14 @@
  * Jun 2006 - namespaces ssupport
  *            OpenVZ, SWsoft Inc.
  *            Pavel Emelianov <xemul@openvz.org>
+ *
+ * General sysv ipc locking scheme:
+ *  when doing ipc id lookups, take the ids->rwsem
+ *      rcu_read_lock()
+ *          obtain the ipc object (kern_ipc_perm)
+ *          perform security, capabilities, auditing and permission checks, etc.
+ *          acquire the ipc lock (kern_ipc_perm.lock) throught ipc_lock_object()
+ *             perform data updates (ie: SET, RMID, LOCK/UNLOCK commands)
  */
 
 #include <linux/mm.h>
-- 
1.7.11.7

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2013-06-19  1:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19  1:18 [PATCH 00/11] sysv ipc shared mem optimizations Davidlohr Bueso
2013-06-19  1:18 ` [PATCH 01/11] ipc,shm: introduce lockless functions to obtain the ipc object Davidlohr Bueso
2013-06-19  1:18 ` [PATCH 02/11] ipc,shm: shorten critical region in shmctl_down Davidlohr Bueso
2013-06-19  1:18 ` [PATCH 03/11] ipc: drop ipcctl_pre_down Davidlohr Bueso
2013-07-16 22:49   ` Andrew Morton
2013-06-19  1:18 ` [PATCH 04/11] ipc,shm: introduce shmctl_nolock Davidlohr Bueso
2013-06-19  1:18 ` [PATCH 05/11] ipc,shm: make shmctl_nolock lockless Davidlohr Bueso
2013-06-19  1:18 ` [PATCH 06/11] ipc,shm: shorten critical region for shmctl Davidlohr Bueso
2013-06-19  1:18 ` [PATCH 07/11] ipc,shm: cleanup do_shmat pasta Davidlohr Bueso
2013-06-19  1:18 ` [PATCH 08/11] ipc,shm: shorten critical region for shmat Davidlohr Bueso
2013-06-19  1:18 ` [PATCH 09/11] ipc: rename ids->rw_mutex Davidlohr Bueso
2013-06-19  1:18 ` [PATCH 10/11] ipc,msg: drop msg_unlock Davidlohr Bueso
2013-06-19  1:18 ` Davidlohr Bueso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371604716-3439-12-git-send-email-davidlohr.bueso@hp.com \
    --to=davidlohr.bueso@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox