From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA04C4167B for ; Tue, 5 Dec 2023 16:35:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDEB26B007B; Tue, 5 Dec 2023 11:35:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C8EF46B0082; Tue, 5 Dec 2023 11:35:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B07896B0083; Tue, 5 Dec 2023 11:35:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9E5546B0082 for ; Tue, 5 Dec 2023 11:35:29 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 668A11C0281 for ; Tue, 5 Dec 2023 16:35:29 +0000 (UTC) X-FDA: 81533315178.21.DE41910 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id DB8E8140036 for ; Tue, 5 Dec 2023 16:35:26 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lurv3KKi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701794127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WAjSMM8S9duqQaTKyF8A+39oTGj2tsKJXjdXtV2uUE8=; b=C1LXad6x8HiQsGTA0TNhCfFdfuZQ1NEz/qiG9b4ufvCXt8kF9VYO1ItFpnR/031SmnEfdm XtVFP9+q77Nv90hcJ148XdMWL488lAavnbUDLzPVidXy6OyNmplmJsmd/d0C6nKwgch4wo icgSQDPcyklPziyW5SShtejIXYXmOvA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lurv3KKi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701794127; a=rsa-sha256; cv=none; b=l5TPsBMpvVDReleDqyinkMPHB815nrx9CdYxOOQW+az2s8jSg8dERO8tevmMykmaiI0iqt NuR1ePDSBRdV/9bAur+hPbw665uJzzA+u1vln2EXRPcPu+ZYMvqaDsyZt2VlJz3EpnvW5e 2aAlKDA2tSPBXxrxDPuWdriYFlpCfAE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701794126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WAjSMM8S9duqQaTKyF8A+39oTGj2tsKJXjdXtV2uUE8=; b=Lurv3KKioQiayLnJH5DCVx+9lYCjSwFfAaE91ZZZOoTCQPDI2MADL5F0PeFr/B/FilSVdf VDIteP7T7ks7XyF1vh/Pwe8DXoCgDl8PESr/9Mx9avmi43oyGAUTzIFMEqahskEwxKNbO1 S65gPqmK/44r7a2VH5d60CvU60aglV8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-HLoqJrLdMLad-0eezkIRcg-1; Tue, 05 Dec 2023 11:35:23 -0500 X-MC-Unique: HLoqJrLdMLad-0eezkIRcg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-33334e370d3so3025560f8f.2 for ; Tue, 05 Dec 2023 08:35:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701794122; x=1702398922; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WAjSMM8S9duqQaTKyF8A+39oTGj2tsKJXjdXtV2uUE8=; b=JHEl/8VwVRiq/c4rX26BoVwC3D9n9AzG0wI0ZcSgCO9rLRZGSH6sfZHQQ1ezZhXLXp uMz8QZG9uxuU/yyYg1QwCHg5geOiplSnA//ojhoNceArLwvptjh91r4SiTrgmm/kU2wF o6ZqkMCaAovvVG9+l7IcPRrbMEjv1OWXiEcDx1FgGY8YxQGXGn/lCFvINlTFnNtDg+R7 o/6W/J/bfROnhZb33UVl1XTFavRz6ORlxv3ykQ2I0lTMeWyFfY8l9CrzmEy9k+FxPhUL FwfiBuBdANJMI+yISA/vlF/gT9JNERN/+iDvGrkDC7SX3Tte6NENktFEW/8sAssx2mEm WNPw== X-Gm-Message-State: AOJu0Yxyy//L1kLfagd7/Ily0Bb5K2P/V7rrasLMsUFMpmelEtbbLqtS Bikx2GmPV4vSLrPlhj73t8KyJRU8pH4f/U1j/HlufFKlQ3pc8ajMRwa1cmhavVSgNublqq2jVyq 493Pvh8ePfOA= X-Received: by 2002:a05:6000:14a:b0:333:3d2b:7d03 with SMTP id r10-20020a056000014a00b003333d2b7d03mr3089555wrx.133.1701794122277; Tue, 05 Dec 2023 08:35:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZFrpKLkRbWvkntQIIpVSy/jf+9XoUctTpD6c77+lw3yfwoVpNz/mIVsE7+b54YAYaoziLXw== X-Received: by 2002:a05:6000:14a:b0:333:3d2b:7d03 with SMTP id r10-20020a056000014a00b003333d2b7d03mr3089523wrx.133.1701794121960; Tue, 05 Dec 2023 08:35:21 -0800 (PST) Received: from ?IPV6:2003:cb:c72f:300:1ec7:2962:8889:ef6? (p200300cbc72f03001ec7296288890ef6.dip0.t-ipconnect.de. [2003:cb:c72f:300:1ec7:2962:8889:ef6]) by smtp.gmail.com with ESMTPSA id r12-20020a5d52cc000000b00333590f3bf9sm1964226wrv.19.2023.12.05.08.35.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 08:35:21 -0800 (PST) Message-ID: <1370c5b7-c914-4861-ad7a-90199723994a@redhat.com> Date: Tue, 5 Dec 2023 17:35:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 04/10] mm: thp: Support allocation of anonymous multi-size THP From: David Hildenbrand To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231204102027.57185-1-ryan.roberts@arm.com> <20231204102027.57185-5-ryan.roberts@arm.com> <71040a8c-4ea1-4f21-8ac8-65f7c25c217e@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <71040a8c-4ea1-4f21-8ac8-65f7c25c217e@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DB8E8140036 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mhb9rcg7hfsmuuq8b7gfykxky1ord5i1 X-HE-Tag: 1701794126-204739 X-HE-Meta: U2FsdGVkX1/F8L6NJwM5AysE5IsbAPh4gWiVlwzYwoce3WQnxa+TA8W9DahyrTvt3wVPE8+RUnAbbVBe97T4EXpNxYGjaxvEPo8gSzCX/54nDt0DiMdCWZro+sCxm4wLilo9gCXXncpRkWak2YXPq2X2Y/E5cShxDBWZUGsiKNz06qaP+g7yX9S84Av6BlV0LNxpXdygIwbvPDDZiF1ABFELH2Yq0dz1R9vE2hLiJPgxIOMKRnSbEGo+X1JDuwGO2RoN1mn75Tj5T4ZEiO6BIgFIX9r7Ch58jbI67Mua+gvdzZ7MEvuL0SZk+Y4uuDZwqJ6RgIvSnsSNhakw3vt+L5pN1PN2EOkXUwg1GZ/hc6mQ5vkYJ/bTtk+MRKD4GGToJsTZEoGk6EkPKMGghmv0s45xyWkY4EVas1RvR+HSRF++arCN73sMxNfKYK7RoQmz5BLbpWQTH9+L+vEoF2orChgyARC7sctMnyMwZdFI+JLpQn77AUHFK4+B5o+Ci3UzynjmtkWnDgIJkZv3/2nEo+BByvWM6vVcdhqyxAs0BzKU0OeWb4xIytllmBOUaUX0NYa5k2aYd0yWZWlsceXaoBlR2BMH3ZrpfUDX7IuMXxhWi3tdR/V6wagQwLESz7dLovC0/+vUDq9c2zKvmBSFyoEeCG+U6Du1DqRcxVVKRVitwGxu7ai7gm2QmZ8EPJKSFJzYNi4CJJu2780arOqemckIsH4RTtV/H1IW3cue7JwjNP2SoNL8l3W2potc4soL7DkGd+NTRqsOrmlRodmZou+wVHiq8Fpvz0636fzCHRbVwnUTl/jiqe5fLC+8SfXj6VmtmV/R1dTebUs3m2xQZPQb12K5ftP+Qxpc1SX/Pr+o2wzZTdjJknIH7hwmJz+cSDtLXKlR2s7i6l1aeFUGjxe8khFZpcJDyrs1cI820hgicWzZK/ZsE5S51BHUEiBkmkSy0d8ZZO68pTr7XXm TJ8hsH7G vhNmkR8LEf3H83SgnB2Lm4IfJYu7jTqwqce1xb8O0ssqoANrBbOZ3BQYXwABh3LlryVk0gxLB/nE0H3s7NvpFFHEUsBuL7TV2/eRUgnVstefup6xzM/Dadjv+DqhVfQiWNe+vbVfVhjnUlnLxTSEnkpniheBDKz+vaqjqxvmmpOWi0hic5Vc6SO7+nV41zDlYOY0bWKNT6YkF5Z2/3doCSoOCwO6xI3FFJql6g7z4SHPAhkx+feYS3IB0AiMOKyOCc6M6nXB8WdL1QhysVzQut5kt1r7kNIoDp+nTHURiqGuL+w6vyStanaQZrZZP3b6RtJijzIOEwRUDpoD8U9TJnHvJogDfgDPrcGMVq7xGmKjkz0cXBhrOtU3lH7azyxQ6O2fOPRrE0tPbv8avNI5lOjrlsMKXskud7QyVILQqR7YL947IliuwgmLa/JuuKVPpE6KGpg5Oybs52aZZE0hZkJqx5oIit7H+vivpcjT1/I793Yg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Comment: Both will eventually loop over all orders, correct? Could > eventually be sped up in the future. > > Nit: the orders = ... order = ... looks like this might deserve a helper > function that makes this easier to read. > > Nit: Why call thp_vma_suitable_orders if the orders are already 0? > Again, some helper might be reasonable where that is handled internally. > > Comment: For order-0 we'll always perform a function call to both > thp_vma_allowable_orders() / thp_vma_suitable_orders(). We should > perform some fast and efficient check if any in the system / for this VMA, and in that case just fallback before > doing more expensive checks. Correction: only a call to thp_vma_allowable_orders(). I wonder if we can move some of thp_vma_allowable_orders() into the header file where we'd just check as fast and as efficiently for "no THP < PMD_THP enabled" on this system. -- Cheers, David / dhildenb