From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx137.postini.com [74.125.245.137]) by kanga.kvack.org (Postfix) with SMTP id E9A4B8D001E for ; Tue, 11 Jun 2013 12:13:18 -0400 (EDT) Received: by mail-ea0-f172.google.com with SMTP id q10so4982506eaj.3 for ; Tue, 11 Jun 2013 09:13:17 -0700 (PDT) Message-ID: <1370967193.3252.47.camel@edumazet-glaptop> Subject: Re: [PATCH] slab: prevent warnings when allocating with __GFP_NOWARN From: Eric Dumazet Date: Tue, 11 Jun 2013 09:13:13 -0700 In-Reply-To: <51B745F9.9080609@oracle.com> References: <1370891880-2644-1-git-send-email-sasha.levin@oracle.com> <51B62F6B.8040308@oracle.com> <0000013f3075f90d-735942a8-b4b8-413f-a09e-57d1de0c4974-000000@email.amazonses.com> <51B67553.6020205@oracle.com> <51B72323.8040207@oracle.com> <0000013f33cdc631-eadb07d1-ef08-4e2c-a218-1997eb86cde9-000000@email.amazonses.com> <51B73F38.6040802@kernel.org> <0000013f33d58923-88767793-2187-476d-b500-dba3c22607aa-000000@email.amazonses.com> <51B745F9.9080609@oracle.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Sasha Levin Cc: Christoph Lameter , Pekka Enberg , "linux-mm@kvack.org" , Andrew Morton , LKML On Tue, 2013-06-11 at 11:44 -0400, Sasha Levin wrote: > On 06/11/2013 11:23 AM, Christoph Lameter wrote: > > On Tue, 11 Jun 2013, Pekka Enberg wrote: > > > >> So you're OK with going forward with Sasha's patch? It's needed > >> because __GFP_NOWARN was specifically added there to fix this > >> issue earlier. > > > > Why dont we fix the call site to use vmalloc instead for larger allocs? > > > > We should probably be doing both. Allowing a pipe to store thousands of page refs seems quite useless and dangerous. Having to use vmalloc()/vfree() for every splice()/vmsplice() would be a performance loss anyway. (fs/splice.c splice_grow_spd() will also want to allocate big kmalloc() chunks) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org