From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Christoph Lameter <cl@gentwo.org>,
Pekka Enberg <penberg@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] slab: prevent warnings when allocating with __GFP_NOWARN
Date: Tue, 11 Jun 2013 09:13:13 -0700 [thread overview]
Message-ID: <1370967193.3252.47.camel@edumazet-glaptop> (raw)
In-Reply-To: <51B745F9.9080609@oracle.com>
On Tue, 2013-06-11 at 11:44 -0400, Sasha Levin wrote:
> On 06/11/2013 11:23 AM, Christoph Lameter wrote:
> > On Tue, 11 Jun 2013, Pekka Enberg wrote:
> >
> >> So you're OK with going forward with Sasha's patch? It's needed
> >> because __GFP_NOWARN was specifically added there to fix this
> >> issue earlier.
> >
> > Why dont we fix the call site to use vmalloc instead for larger allocs?
> >
>
> We should probably be doing both.
Allowing a pipe to store thousands of page refs seems quite useless and
dangerous.
Having to use vmalloc()/vfree() for every splice()/vmsplice() would be a
performance loss anyway.
(fs/splice.c splice_grow_spd() will also want to allocate big kmalloc()
chunks)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-11 16:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 19:18 Sasha Levin
2013-06-10 19:31 ` Pekka Enberg
2013-06-10 19:56 ` Sasha Levin
2013-06-10 23:40 ` Christoph Lameter
2013-06-11 0:54 ` Sasha Levin
2013-06-11 6:28 ` Pekka Enberg
2013-06-11 13:16 ` Sasha Levin
2013-06-11 15:14 ` Christoph Lameter
2013-06-11 15:16 ` Pekka Enberg
2013-06-11 15:23 ` Christoph Lameter
2013-06-11 15:44 ` Sasha Levin
2013-06-11 16:13 ` Eric Dumazet [this message]
2013-06-11 16:19 ` Sasha Levin
2013-06-11 16:37 ` Eric Dumazet
2013-06-11 16:43 ` Dave Jones
2013-06-11 19:02 ` Sasha Levin
2013-06-12 13:01 ` Christoph Lameter
2013-06-11 16:28 ` Christoph Lameter
2013-06-11 22:34 ` Andrew Morton
2013-06-13 7:03 ` Pekka Enberg
2013-06-11 22:10 ` David Rientjes
2013-06-11 15:08 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370967193.3252.47.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox