From: PINTU KUMAR <pintu_agarwal@yahoo.com>
To: anish singh <anish198519851985@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [checkpatch] - Confusion
Date: Mon, 10 Jun 2013 11:49:00 -0700 (PDT) [thread overview]
Message-ID: <1370890140.99216.YahooMailNeo@web160102.mail.bf1.yahoo.com> (raw)
In-Reply-To: <CAK7N6vrQFK=9OQi7dDUgGWWNQk71x3BeqPA9x3Pq66baA61PrQ@mail.gmail.com>
>________________________________
> From: anish singh <anish198519851985@gmail.com>
>To: PINTU KUMAR <pintu_agarwal@yahoo.com>
>Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>; "linux-mm@kvack.org" <linux-mm@kvack.org>
>Sent: Sunday, 9 June 2013 10:58 PM
>Subject: Re: [checkpatch] - Confusion
>
>
>On Mon, Jun 10, 2013 at 11:21 AM, PINTU KUMAR <pintu_agarwal@yahoo.com> wrote:
>> Hi,
>>
>> I wanted to submit my first patch.
>> But I have some confusion about the /scripts/checkpatch.pl errors.
>>
>> After correcting some checkpatch errors, when I run checkpatch.pl, it showed me 0 errors.
>> But when I create patches are git format-patch, it is showing me 1 error.
>did you run the checkpatch.pl on the file which gets created
>after git format-patch?
>If yes, then I think it is not necessary.You can use git-am to apply
>your own patch on a undisturbed file and if it applies properly then
>you are good to go i.e. you can send your patch.
Yes, first I ran checkpatch directly on the file(mm/page_alloc.c) and fixed all the errors.
It showed me (0) errors.
Then I created a patch using _git format-patch_ and ran checkpatch again on the created patch.
But now it is showing me 1 error.
According to me this error is false positive (irrelevant), because I did not change anything related to the error and also the similar change already exists somewhere else too.
Do you mean, shall I go ahead and submit the patch with this 1 error??
ERROR: need consistent spacing around '*' (ctx:WxV)
#153: FILE: mm/page_alloc.c:5476:
+int min_free_kbytes_sysctl_handler(ctl_table *table, int write,
>>
>> If I fix error in patch, it showed me back again in files.
>>
>> Now, I am confused which error to fix while submitting patches, the file or the patch errors.
>>
>> Please provide your opinion.
>>
>> File: mm/page_alloc.c
>> Previous file errors:
>> total: 16 errors, 110 warnings, 6255 lines checked
>>
>> After fixing errors:
>> total: 0 errors, 105 warnings, 6255 lines checked
>>
>>
>> And, after running on patch:
>> ERROR: need consistent spacing around '*' (ctx:WxV)
>> #153: FILE: mm/page_alloc.c:5476:
>> +int min_free_kbytes_sysctl_handler(ctl_table *table, int write,
>>
>>
>>
>>
>> - Pintu
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-10 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 5:51 PINTU KUMAR
2013-06-10 5:58 ` anish singh
2013-06-10 18:49 ` PINTU KUMAR [this message]
2013-06-12 0:54 ` Sören Brinkmann
2013-06-12 4:15 ` Joe Perches
2013-06-12 4:48 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370890140.99216.YahooMailNeo@web160102.mail.bf1.yahoo.com \
--to=pintu_agarwal@yahoo.com \
--cc=anish198519851985@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox