From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42131C5AD49 for ; Mon, 26 May 2025 17:17:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAB046B007B; Mon, 26 May 2025 13:17:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5B9D6B0083; Mon, 26 May 2025 13:17:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A239F6B0085; Mon, 26 May 2025 13:17:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7D87F6B007B for ; Mon, 26 May 2025 13:17:22 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F38C61A0A19 for ; Mon, 26 May 2025 17:17:21 +0000 (UTC) X-FDA: 83485715082.18.0F9D55A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 2BD0AC0002 for ; Mon, 26 May 2025 17:17:19 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Oh7pW1Xo; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748279839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vvkurFwD/ln7aIPd0yrzQWt5kfZ7guBxhUcxWM2VHnE=; b=IVrww2ap5V4wxA4/ipMHazOPoOL+4xvGlZjpjxmanCce0C3hd4hp3tCRX4Zp1a1BuEOOwW rsEy2whwSLxjGD1n6pZFp6JpF2yZCxerM5HejHEFjVH8Grj3c3vTRJEirixjR3pEtid6Zl VbCLdr3oja1b/FVvDbKU5j8DmPCgGfE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Oh7pW1Xo; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748279839; a=rsa-sha256; cv=none; b=qtYCqofJ4ITYPjmHtUWwOWBpm01hU6za+Du5qhv/tpqRppU7qZZ8NfiaYeqUIS93lmN3XZ p0aH37Unfmk7EV+I63gGB9me4jUVKE2+V0RyRrjkzIaVfKWLGxxhagQ9pvTd4jf6wU1det mgWzU6WDN9oo0jtT7iih+1ng8pQQ4Bc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748279838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vvkurFwD/ln7aIPd0yrzQWt5kfZ7guBxhUcxWM2VHnE=; b=Oh7pW1XozJDly2VdZKuCttE2iXdDQPo/TDuIqnlxJAwRAopINMZAYRwWkxywl9RdxRqKPS jQe77BXbdh8i3KJs3ukQoMOdCF25jj/jKGQjVt39Uu3jHpPaZKeueTIpgJ3gjV9fXukHVs 8YrH0+KpSkVHgGaiUjk3XtsiB5019rw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-q8VqtgQcOjiOaTB_A5yGvQ-1; Mon, 26 May 2025 13:17:17 -0400 X-MC-Unique: q8VqtgQcOjiOaTB_A5yGvQ-1 X-Mimecast-MFC-AGG-ID: q8VqtgQcOjiOaTB_A5yGvQ_1748279836 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a360d01518so1576765f8f.2 for ; Mon, 26 May 2025 10:17:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748279836; x=1748884636; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vvkurFwD/ln7aIPd0yrzQWt5kfZ7guBxhUcxWM2VHnE=; b=rayiL09XCDGFpQdy/eQn+4F1cFmvtP+j3g3t2rwAT4u04AXH9GwUR+nfJmjJQ9EGbI JysFJ76K7mkaz8l6OPbu7Sml4jgnohjr/7PWVrmAnd5HR/JkJDp5tMI5x05lUDgGrt/X kq9dKPgUrhiuoD8qBiicAE3MSBkeLh91je3L/sLQKzcqzvI9AaME14/nX3Hs+muOO0iF 2Qsg8jjSczjaSVYzPPHCiIB6NTIbWJ5EVl9uCj98RtLn2zK0nuzU//bvU32NMJEw8ram pLMe58TPkJtiSZN7cUheNES8Di2cM9EzRof3BN7igPT6xDKGguG3AAtcTXFlIHE8pWzI IcLw== X-Forwarded-Encrypted: i=1; AJvYcCWB57LbJMLv0zt92akoNIgXGxCIaS4IhCTrUeblMso50O8TzMmPB4F2n/GLIq9J4AGy1PU3yvMjSQ==@kvack.org X-Gm-Message-State: AOJu0YxgIlXC6EavAn7NeUeVvZFGJOqBPAHfcDbWeRe42slwiK5XOxpI b4ekp+lB+f7Mb/YtZeuDooFKdQIX/+mZBSX0FtqKc9IYVe5BSMGafC34rZxMoLeE6lnelTqJwZ8 m3TbsD25f9/v5i7WwYHcdC2HEEmoPGjFRWKv0q4GHcRZKiU3Ic7QA X-Gm-Gg: ASbGncujPUnrHL2KUCg0zz5xWUazATPbsSW5W93B1zkVXeMX06Q6xtE9o9Au0iNwbGc tRT6Qt1V9j9IBi91ftwo7UOhDbs/OMFRcIzNjglYrVPHgwilp7O8C6n3oCro0BuEEY3E0YPQK1T dQeRf02CF+QXHYPiP3Ybe45tFgMFb8vxM2bA5hWArJoZMSKLnFdUIPgqqz6faYAJtL1dAex+r1e 88z7yCOc+xmoBTU/dThn/g9aJDBzfq3QGvUq5DN/+GOCgmSg2bk2kjqItCiRFPJZECnfUx6tz7B pFfsIqZhlyGdf/KYyDJv//JcSeWgFCHZTXhfLAkoX76D2sATRI5+QHNfDUGHI2isQnb4Uocx0Iv ZleyJ1UxSOTTYW0kk9s/79GIRd+BlRxcUmfC+HN8= X-Received: by 2002:a05:6000:2892:b0:3a4:cf40:ff37 with SMTP id ffacd0b85a97d-3a4cf4101e6mr7349865f8f.6.1748279836095; Mon, 26 May 2025 10:17:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEor4pKEGtom7BDqTYjiMotloxQfu1xzqM+ForU+36DqHUur59mzcvYI/Btx64T3mrbSgEa4Q== X-Received: by 2002:a05:6000:2892:b0:3a4:cf40:ff37 with SMTP id ffacd0b85a97d-3a4cf4101e6mr7349836f8f.6.1748279835622; Mon, 26 May 2025 10:17:15 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:6500:e1c1:8216:4c25:efe4? (p200300d82f196500e1c182164c25efe4.dip0.t-ipconnect.de. [2003:d8:2f19:6500:e1c1:8216:4c25:efe4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4cd0cf5c0sm8078384f8f.12.2025.05.26.10.17.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 May 2025 10:17:15 -0700 (PDT) Message-ID: <13707f7a-3ed6-4a79-bc55-46d331f8b051@redhat.com> Date: Mon, 26 May 2025 19:17:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/5] drivers/base/node: Optimize memory block registration to reduce boot time To: Donet Tom , Andrew Morton , Mike Rapoport , Oscar Salvador , Zi Yan , Greg Kroah-Hartman Cc: Ritesh Harjani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , Madhavan Srinivasan , Nilay Shroff , linuxppc-dev@lists.ozlabs.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XqgZ3C5am7loQqnreCQLPENIC3X9IjiGjpg-P4KtIkw_1748279836 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2BD0AC0002 X-Stat-Signature: n3wtf6tx5c97xgi56t9smufqqthutxk9 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748279839-321526 X-HE-Meta: U2FsdGVkX1/VKLSfyk2ZphQgVIdmKbZODJ3Up+JAE3m6tyWvLJZLRhtRZCqX71Exq0tu/Y+Cx5ldz+eOUHYLTFHWU6ni7YQrbhvy7iuCWrVAIYk2l4HwGjx5YgtH2GTIOLnW4tfeihBxbMdqxQeQBmpJbjKLlr7ZTICdDkOwmqbaHMSuGimO1rcd+TgoZo8xUNiRAAb/6JKg/4Ju8bZIxQ/IGibTKGr0AgjfUMGR3KHlBOXj3NRQcOuB98O2Uo/X2/o0ExMdoMn8gJJLDFWEBykNuKfVgEr30dwYo2tK/SI/i7ibHpt5cdZTsWMBeW67NQGmdbN66oH1ieWTYpITz1h6elAkV4115adm18fNl7Ui5/mG+F8zW5qrfkCw8uKlDveUrKSB513tdhRhYb39y/PDM4xaNrOFXeY1NX4SDfqLGTkPa1OKHoxvo6M3vEwwpHp/LKdBcdM79LhWrxrJuw8waMSS2nnLZ38YnVcuBID4QU/p/2e1BN/5qELQEM4bhG0iYiPrwahTrYCTcX7EoAmaxjnXkFJzEjI7j1U8WprQt2u8ku4c4M9p0cfRqagPT/V8ozPmoHEiQPo3BPB9/6XjhIGPk3iyuQYQ6EGl9s1ccvPL1ukArEej1JHH2p7mlV2aZzuKvUdCr5I2mSvgNehOw1+bfwxQF86jLgE7sKJcf+701Bz6LxFDZcGQKBmUlJ7lEPSBrTOvV9Oc+sG7mB7y93S/ZNWKq5ZCaMudENqOp4x0tf03nzy163oQaiysT+XhQCKSusN9alt7g82z9QApOBplrkFNxL+HKAXJVDtbfIBJWtqWo4R9SVLH02xx+WyuyWc8a2uaGWxRxHExkqBY9PIH4dx4cGtVMp9TK25NmE24BfIHlgSLhBGg2DW2Vqptx61IEDVa0gh71Y2u/oYlB3ik38sukTel4nMeddLAgstWKt8J/XASa0DNDZi21jUqTepJzUjVssLnmhP m8yl+EuW leG5P1E8gBXqQONumWGM/yaECSgCO+2vjEv/LQg7QjmpaLRi6N5G1EBqNlDAGWPRKZgQ+2pgzv4FQjM1O9qQ7lW+s5csyzFQ4UjCMCcAO+Q2DA8jKT4h6UiBpCPKpliJAaYeGRdqy4+A589VK8aHYLUIzi5ZaejnahP1zTOkUDqIexOlQrfAONbbLdQDjNTo6zRnzKCMilhTgDE6Tn/E/NaM7qbarfFPP8RTk4nJtvIXxJdXC7v297fbImsK3F9r73S75B71QpZIvDwXQixfWyeFKUJJBFJcXlYtQBCpNdkrkI+kg8grFhJ/r9CyveobVCwVlSwFzdnMcnqItWPRYpPLV3ge4keEDjmB3sNym95wrfoG3tf60agPonKtpTYrzY/H8ClGkUPSV5EpVQCJJRfUXUEA5O+uXV5WiHcoHcr34TidNCodtlsz+mVxeppLG7Lj82gl3SaxcFimCMZglrT1xx3U8o33DynaOJsPekT5e/colF1EXauaUUag4bVh9YNcR8TKV3nB7WXQCYHr7k3WPB0Y1xTKgWZmlEG/2CC5iOQwuZDWMd7dkk5EJLZ6YzNzSTbOnQKKbWBxxswOMD45TyOdf+boUhzoFIQEKcBhGYDCtOD+07kbpRn7wTm1MCftdh3Yq6g3ZgIibTiaZvvbaetRkrQMExfGKtijPYCDKzBa7k3soBvABIA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.05.25 16:50, Donet Tom wrote: > During node device initialization, `memory blocks` are registered under > each NUMA node. The `memory blocks` to be registered are identified using > the node’s start and end PFNs, which are obtained from the node's pg_data > > However, not all PFNs within this range necessarily belong to the same > node—some may belong to other nodes. Additionally, due to the > discontiguous nature of physical memory, certain sections within a > `memory block` may be absent. > > As a result, `memory blocks` that fall between a node’s start and end > PFNs may span across multiple nodes, and some sections within those blocks > may be missing. `Memory blocks` have a fixed size, which is architecture > dependent. > > Due to these considerations, the memory block registration is currently > performed as follows: > > for_each_online_node(nid): > start_pfn = pgdat->node_start_pfn; > end_pfn = pgdat->node_start_pfn + node_spanned_pages; > for_each_memory_block_between(PFN_PHYS(start_pfn), PFN_PHYS(end_pfn)) > mem_blk = memory_block_id(pfn_to_section_nr(pfn)); > pfn_mb_start=section_nr_to_pfn(mem_blk->start_section_nr) > pfn_mb_end = pfn_start + memory_block_pfns - 1 > for (pfn = pfn_mb_start; pfn < pfn_mb_end; pfn++): > if (get_nid_for_pfn(pfn) != nid): > continue; > else > do_register_memory_block_under_node(nid, mem_blk, > MEMINIT_EARLY); > > Here, we derive the start and end PFNs from the node's pg_data, then > determine the memory blocks that may belong to the node. For each > `memory block` in this range, we inspect all PFNs it contains and check > their associated NUMA node ID. If a PFN within the block matches the > current node, the memory block is registered under that node. > > If CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, get_nid_for_pfn() performs > a binary search in the `memblock regions` to determine the NUMA node ID > for a given PFN. If it is not enabled, the node ID is retrieved directly > from the struct page. > > On large systems, this process can become time-consuming, especially since > we iterate over each `memory block` and all PFNs within it until a match is > found. When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, the additional > overhead of the binary search increases the execution time significantly, > potentially leading to soft lockups during boot. > > In this patch, we iterate over `memblock region` to identify the > `memory blocks` that belong to the current NUMA node. `memblock regions` > are contiguous memory ranges, each associated with a single NUMA node, and > they do not span across multiple nodes. > > for_each_memory_region(r): // r => region > if (!node_online(r->nid)): > continue; > else > for_each_memory_block_between(r->base, r->base + r->size - 1): > do_register_memory_block_under_node(r->nid, mem_blk, MEMINIT_EARLY); > > We iterate over all memblock regions, and if the node associated with the > region is online, we calculate the start and end memory blocks based on the > region's start and end PFNs. We then register all the memory blocks within > that range under the region node. > > Test Results on My system with 32TB RAM > ======================================= > 1. Boot time with CONFIG_DEFERRED_STRUCT_PAGE_INIT enabled. > > Without this patch > ------------------ > Startup finished in 1min 16.528s (kernel) > > With this patch > --------------- > Startup finished in 17.236s (kernel) - 78% Improvement > > 2. Boot time with CONFIG_DEFERRED_STRUCT_PAGE_INIT disabled. > > Without this patch > ------------------ > Startup finished in 28.320s (kernel) > > With this patch > --------------- > Startup finished in 15.621s (kernel) - 46% Improvement > > Acked-by: Oscar Salvador > Acked-by: Mike Rapoport (Microsoft) > Acked-by: Zi Yan > Signed-off-by: Donet Tom > Only a couple of nits: > diff --git a/drivers/base/node.c b/drivers/base/node.c > index cd13ef287011..20b6f4496e1b 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > static const struct bus_type node_subsys = { > .name = "node", > @@ -850,6 +851,47 @@ void unregister_memory_block_under_nodes(struct memory_block *mem_blk) > kobject_name(&node_devices[mem_blk->nid]->dev.kobj)); > } > > +/* > + * register_memory_blocks_under_nodes : Register the memory blocks > + * under the nodes.> + * > + * This function registers all memory blocks to their corresponding nodes > + * based on the associated memory regions. Each memory region is tied to > + * a specific node and does not span multiple nodes. Therefore, all memory > + * blocks within a given region are considered to belong to that node. The > + * function iterates through each memory region and registers the memory > + * blocks contained within that region to the respective node. Since memory > + * blocks can span across multiple regions (and hence multiple nodes), a > + * single memory block may be registered under more than one node if it > + * overlaps with regions belonging to different nodes. a) Do we need excessive doc for that? b) It looks partially like kerneldoc, do we want to convert it to proper one? /** * register_memory_blocks_under_nodes - register all memory blocks * under the corresponding nodes * ... c) Maybe add a line break .. or two to make it a bit more readable. > + */> +static void register_memory_blocks_under_nodes(void) > +{ > + struct memblock_region *r; > + > + for_each_mem_region(r) { > + const unsigned long start_block_id = phys_to_block_id(r->base); > + const unsigned long end_block_id = phys_to_block_id(r->base + r->size - 1); > + unsigned long block_id; > + int nid = memblock_get_region_node(r); const int nid = memblock_get_region_node(r); unsigned long block_id; > + > + if (!node_online(nid)) > + continue; > + > + for (block_id = start_block_id; block_id <= end_block_id; block_id++) { > + struct memory_block *mem; > + > + mem = find_memory_block_by_id(block_id); > + if (!mem) > + continue; > + > + do_register_memory_block_under_node(nid, mem, MEMINIT_EARLY); > + put_device(&mem->dev); > + } > + > + } > +} > + > void register_memory_blocks_under_node(int nid, unsigned long start_pfn, > unsigned long end_pfn, > enum meminit_context context) > @@ -971,11 +1013,16 @@ void __init node_dev_init(void) > > /* > * Create all node devices, which will properly link the node > - * to applicable memory block devices and already created cpu devices. > + * to already created cpu devices. > */ > for_each_online_node(i) { > - ret = register_one_node(i); > + ret = __register_one_node(i); > if (ret) > panic("%s() failed to add node: %d\n", __func__, ret); > } > + > + /* > + * Link the node to memory block devices > + */ This comment is rather ... superfluous. ... and it would fit into a single line. > + register_memory_blocks_under_nodes(); > } > diff --git a/include/linux/memory.h b/include/linux/memory.h > index 12daa6ec7d09..2a61088e17ad 100644 > --- a/include/linux/memory.h > +++ b/include/linux/memory.h > @@ -171,12 +171,30 @@ struct memory_group *memory_group_find_by_id(int mgid); > typedef int (*walk_memory_groups_func_t)(struct memory_group *, void *); > int walk_dynamic_memory_groups(int nid, walk_memory_groups_func_t func, > struct memory_group *excluded, void *arg); > +struct memory_block *find_memory_block_by_id(unsigned long block_id); > #define hotplug_memory_notifier(fn, pri) ({ \ > static __meminitdata struct notifier_block fn##_mem_nb =\ > { .notifier_call = fn, .priority = pri };\ > register_memory_notifier(&fn##_mem_nb); \ > }) > > +extern int sections_per_block; > + > +static inline unsigned long memory_block_id(unsigned long section_nr) > +{ > + return section_nr / sections_per_block; > +} > + > +static inline unsigned long pfn_to_block_id(unsigned long pfn) > +{ > + return memory_block_id(pfn_to_section_nr(pfn)); > +} > + > +static inline unsigned long phys_to_block_id(unsigned long phys) > +{ > + return pfn_to_block_id(PFN_DOWN(phys)); > +} > + > #ifdef CONFIG_NUMA > void memory_block_add_nid(struct memory_block *mem, int nid, > enum meminit_context context); > @@ -188,5 +206,4 @@ void memory_block_add_nid(struct memory_block *mem, int nid, > * can sleep. > */ > extern struct mutex text_mutex; > - Unrelated change. Thanks Acked-by: David Hildenbrand -- Cheers, David / dhildenb