From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Artem Savkov <artem.savkov@gmail.com>,
minchan.kernel.2@gmail.com, dan.magenheimer@oracle.com,
rjw@sisk.pl, linux-mm@kvack.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] non-swapcache pages in end_swap_bio_read()
Date: Fri, 07 Jun 2013 13:51:33 -0700 [thread overview]
Message-ID: <1370638293.2209.134.camel@joe-AO722> (raw)
In-Reply-To: <20130607134303.a9bcff78691c38b03a8b3dde@linux-foundation.org>
On Fri, 2013-06-07 at 13:43 -0700, Andrew Morton wrote:
> On Sat, 8 Jun 2013 00:23:18 +0400 Artem Savkov <artem.savkov@gmail.com> wrote:
[]
> +++ a/mm/page_io.c
[]
> + /*
> + * There is no guarantee that the page is in swap cache - the software
> + * suspend code (at least) uses end_swap_bio_read() against a non-
> + * swapcache page. So we must check PG_swapcache before proceeding with
> + * this optimization.
> + */
> + if (likely(PageSwapCache(page))) {
or
if (unlikely(!PageSwapCache(page)))
goto out;
to save an indent level
> +out:
> unlock_page(page);
> bio_put(bio);
> }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-06-07 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 12:59 [BUG] non-swapcache page " Artem Savkov
2013-06-07 15:26 ` Minchan Kim
2013-06-07 20:23 ` [PATCH] non-swapcache pages " Artem Savkov
2013-06-07 20:43 ` Andrew Morton
2013-06-07 20:51 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370638293.2209.134.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=artem.savkov@gmail.com \
--cc=dan.magenheimer@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=minchan.kernel.2@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox