From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57719EB64D9 for ; Thu, 6 Jul 2023 08:53:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5D638D0002; Thu, 6 Jul 2023 04:53:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0BE88D0001; Thu, 6 Jul 2023 04:53:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD2F18D0002; Thu, 6 Jul 2023 04:53:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BB5898D0001 for ; Thu, 6 Jul 2023 04:53:51 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9089516033D for ; Thu, 6 Jul 2023 08:53:51 +0000 (UTC) X-FDA: 80980574262.20.CF1EAEB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 3DCA780010 for ; Thu, 6 Jul 2023 08:53:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eLmNhvhw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688633629; a=rsa-sha256; cv=none; b=ld7Mwqrng0+A1n1xLFilf/XfUSuj7OsQMcpg4aOLfg0lO85rX8k+FpLJHLJIJeKn05fix7 JEwUBnEy3dvlZp7HRA2kuVM/mPmVOAS5z8Kt7sxNuoQcNcvy9vO+jsitD3jNoAPIFc1eyf YNACZwehkDmsDxZ2hVwuCVAnLVbJWJ4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eLmNhvhw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688633629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=81qkwHowwcAcqm6FlMHXXHq0va4tVmVRF/nlPZhKaVo=; b=ZaGN9jm5CV1YUJ7CMaVkF//NCIowMfr9qVDxGRbu2blbqKRfRVY5TS+F/ZF968SPX2u5Aw wT9UM3Vd3YkJ/4fN5QXE+zMF5S1KXM6yvPHlGcFjD2IUZd+2rMfRaBMJO0ZUgwLtCKbt+s xiuTMimIvkSc0IOLl9PJ+nR7l+LusHE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688633627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=81qkwHowwcAcqm6FlMHXXHq0va4tVmVRF/nlPZhKaVo=; b=eLmNhvhwptbKJT8VkSA8yK3Wh4+G5VBNRbPy+Szyw9caLbnyxieb7jQaVjjouHt/WXYYPg EK5r0fOnj5Yac8tEZeFsoqeYZWZYV3Jwyw4uGlphl2kNXeQs1laST+ONcZirlx3mfq+uI0 /KVzOXuwN62AKCajmd7ChpwsydZ3bNM= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-MdqNHpszMAu1KWpK9FF1wg-1; Thu, 06 Jul 2023 04:53:42 -0400 X-MC-Unique: MdqNHpszMAu1KWpK9FF1wg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4fb913e8cddso209867e87.0 for ; Thu, 06 Jul 2023 01:53:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688633621; x=1691225621; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=81qkwHowwcAcqm6FlMHXXHq0va4tVmVRF/nlPZhKaVo=; b=fJwJ1+zTGkGD2C2wIdrtZN3zzep+AzxhxYFaAnBh+OgVP2yQ734Y+v/hsNzT9pgJBf Xl8YyvMQPQl70lrWwJNSTItZo1W8S4vPxiaCyB1Q99Ao4LNRO3oE4agG1i5OppDYCpaY s9sg89t7YwZ6r4GAvv87fWxaQnqUrNnZXbgKTI3FR2+ofWsBsbEYVB14ZORX87g7FjJw sHHdhDqsleEZrzSMPgqCzG5ir3wjpMGWljoaUkJDXs06+T6gCMsRYfwMSa+Gt4u1ZlqP SIjscH0uVCexP8Z90/0CzbR1jht0MfZzeUnOA7Fv7/XxEsXN8u6wiqhjIHYsDEebsjqD UX+w== X-Gm-Message-State: ABy/qLYkJZeexA+ra2neHMBB6YcxrPBJFM1pDi1MiLkHSA47dB0KrFPd xXqkEq5K7gW1zy+EiTtBOWKa1gETQuGz1hSgL6d7ECX1MFOAWKVpfrI9rMJo8DB5IqU3wSYIIrs ZZJ7jcZ1HpSA= X-Received: by 2002:a05:6512:10c3:b0:4fb:89cd:9616 with SMTP id k3-20020a05651210c300b004fb89cd9616mr1155474lfg.0.1688633621339; Thu, 06 Jul 2023 01:53:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlFn0LChzFLfH/50rYWYE0ovWOJVay0UrM+WH26hzPUG5tAX2N+T2RqjZX3zZr5NXTAsdUU47Q== X-Received: by 2002:a05:6512:10c3:b0:4fb:89cd:9616 with SMTP id k3-20020a05651210c300b004fb89cd9616mr1155456lfg.0.1688633620944; Thu, 06 Jul 2023 01:53:40 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id t19-20020a7bc3d3000000b003fb739d27aesm4438255wmj.35.2023.07.06.01.53.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jul 2023 01:53:40 -0700 (PDT) Message-ID: <136fb8f1-55b1-8fcf-2ab6-18b81a6f149e@redhat.com> Date: Thu, 6 Jul 2023 10:53:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 4/5] mm/hotplug: Simplify ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE kconfig To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230706085041.826340-1-aneesh.kumar@linux.ibm.com> <20230706085041.826340-5-aneesh.kumar@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230706085041.826340-5-aneesh.kumar@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3DCA780010 X-Stat-Signature: 44aduap9dtim1yj7nm7sexk9s66xeuxn X-HE-Tag: 1688633629-229450 X-HE-Meta: U2FsdGVkX19TYnQKXADvdZ67WgwkE1ZTKgkiZl6vvZU9g0LRFtpeBMQ7PsRPxC8rLX+jLd4Y8qaf6dDJOoD2D9yHlxjszKKr64rSkDhq5tiHARWYvF/oSAlu3D+WDjfmgTtxGXa0YUtNPKv+vWWTbMQlTgZRWorT2d6bCOit5An5Cv5tj9OQLWhBOpDd/V1l8VKQKjBb7ZC0WN3mc5lslqgQjJVPUhca2qpA9HQ/BWVSz3uDzW8z7rgzVCJgCzgJChTN4NKv8mYeW20NzdGZYdeSKtetZg0K/O8a4X2B/D5prcjtYUk6MxrN2M5fxzCM9y6Y/HIFdIVoupU1fP3YCkvDk2RCePBAAm8UimzltsVnG80F4uBc+Ksjxf0vZgpg/IX7y/Rgci/NT+dy0nZ1z4Ec0SWsDYpH7K2BkNva/SVv0vp24cmW7AxmQMt2uKYCU+FXw8ucSV4ypdd2S+fNNdA9rNnki6zNTjiEoFr2s0qwVzjjo2YpJ4w+PqQ4AcC4Fie4eYzoU3qi4OCdk0sNhIqnnRpIVH3tHRydqFtRZsfVVyVKcdifS3ND1SjJCskLDSEra/SjakiLdswvFiv+llYTYHCfXFlGzDl0HtN1x6Jp0Coomt+YmzJtJl1rcIiewlsRpQAYniz5LMeu0wFYiR1S7RALcvIAgzC4Nhp2vdCFfR9IDrcSA3KAaxTXCYc0OJ0NMFRPzjEgYzlZlZrTfcBYCJZOE/0FbE4NlsPgrxwlObEMk0XSnsKzkAFtaWRMJW2vbgjGt8z8px3GL3Gfve5Vq93rqK5dVx8u+a/dWOQO+GiSbzlb8vdp1KMclSpYI3KJTs5OSIHmUBheIP3Ju9U1XKjR13paQn1FY3NEBkG+gEYy0HiwLaPVYnTl8b7X9Lu0vWTu8jB5QLNKLCEJIjPw30Vt/uwSfKauyf+tECGoM5Rkix6snSSA+BOuHlrYK+dLK+ZHsINvy8v0qQ2 kVLG1u5p jvhBdA4+u5BRh8l4/28fJzGMmz4JCD3x+eSZpynmHjsaEMakYr4wxDCRYzsNW1IVX6a9+YrGxu3I75X1MTq4bdUF7nNf97qwoNuwtwgx/FSdu/jFF/WSaoR/9LoHJF9KTw4IJQhmEAuB3c01Ng7AdG5h6L7D1A6sis+QZvcEavSdAAKLig2Ce4Q/2gAYDeIO43T7crkUbuf5WepMcrNCofkQVC8nO5Y4J2HML87KG3s/yuDBena8+xgYuuuUBdOHcbsTAmFn02P7N7DUnXZCtLdNk8P2j/NDkTJ20p5LY+O/rSiUPV6aYMeKEHwXQ9uyHRaMJoMBbv1up8no2R4KRr2pzBDF7rvgWuFo2OUQaRG6hJeFd/8F5rKrFYOMO0/5Mq0UPGPYZw5BukDh3QLNgilqU9djgGrukNhScoMz95SkQ9CJhtjjSfjytRc6008saBYuHWxSPfd9RprsTLS0hCou82xrlvfNGVXSST+NtmXuw6LGUWyXFYq19qA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.07.23 10:50, Aneesh Kumar K.V wrote: > Instead of adding menu entry with all supported architectures, add > mm/Kconfig variable and select the same from supported architectures. > > No functional change in this patch. > > Signed-off-by: Aneesh Kumar K.V > --- > arch/arm64/Kconfig | 4 +--- > arch/x86/Kconfig | 4 +--- > mm/Kconfig | 3 +++ > 3 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 7856c3a3e35a..7e5985c018f8 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -78,6 +78,7 @@ config ARM64 > select ARCH_INLINE_SPIN_UNLOCK_IRQ if !PREEMPTION > select ARCH_INLINE_SPIN_UNLOCK_IRQRESTORE if !PREEMPTION > select ARCH_KEEP_MEMBLOCK > + select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > select ARCH_USE_CMPXCHG_LOCKREF > select ARCH_USE_GNU_PROPERTY > select ARCH_USE_MEMTEST > @@ -346,9 +347,6 @@ config GENERIC_CSUM > config GENERIC_CALIBRATE_DELAY > def_bool y > > -config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > - def_bool y > - > config SMP > def_bool y > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 78224aa76409..d0258e92a8af 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -102,6 +102,7 @@ config X86 > select ARCH_HAS_DEBUG_WX > select ARCH_HAS_ZONE_DMA_SET if EXPERT > select ARCH_HAVE_NMI_SAFE_CMPXCHG > + select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > select ARCH_MIGHT_HAVE_ACPI_PDC if ACPI > select ARCH_MIGHT_HAVE_PC_PARPORT > select ARCH_MIGHT_HAVE_PC_SERIO > @@ -2610,9 +2611,6 @@ config ARCH_HAS_ADD_PAGES > def_bool y > depends on ARCH_ENABLE_MEMORY_HOTPLUG > > -config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > - def_bool y > - > menu "Power management and ACPI options" > > config ARCH_HIBERNATION_HEADER > diff --git a/mm/Kconfig b/mm/Kconfig > index 923bd35f81f2..2f9d28fee75d 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -570,6 +570,9 @@ config MHP_MEMMAP_ON_MEMORY > depends on MEMORY_HOTPLUG && SPARSEMEM_VMEMMAP > depends on ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > > +config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE > + bool > + > endif # MEMORY_HOTPLUG > > # Heavily threaded applications may benefit from splitting the mm-wide Acked-by: David Hildenbrand -- Cheers, David / dhildenb