Re: [PATCH v2 4/5] mm/hotplug: Simplify ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE kconfig

[David Hildenbrand <david@redhat.com>]

On 06.07.23 10:50, Aneesh Kumar K.V wrote:
> Instead of adding menu entry with all supported architectures, add
> mm/Kconfig variable and select the same from supported architectures.
> 
> No functional change in this patch.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
>   arch/arm64/Kconfig | 4 +---
>   arch/x86/Kconfig   | 4 +---
>   mm/Kconfig         | 3 +++
>   3 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7856c3a3e35a..7e5985c018f8 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -78,6 +78,7 @@ config ARM64
>   	select ARCH_INLINE_SPIN_UNLOCK_IRQ if !PREEMPTION
>   	select ARCH_INLINE_SPIN_UNLOCK_IRQRESTORE if !PREEMPTION
>   	select ARCH_KEEP_MEMBLOCK
> +	select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
>   	select ARCH_USE_CMPXCHG_LOCKREF
>   	select ARCH_USE_GNU_PROPERTY
>   	select ARCH_USE_MEMTEST
> @@ -346,9 +347,6 @@ config GENERIC_CSUM
>   config GENERIC_CALIBRATE_DELAY
>   	def_bool y
>   
> -config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
> -	def_bool y
> -
>   config SMP
>   	def_bool y
>   
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 78224aa76409..d0258e92a8af 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -102,6 +102,7 @@ config X86
>   	select ARCH_HAS_DEBUG_WX
>   	select ARCH_HAS_ZONE_DMA_SET if EXPERT
>   	select ARCH_HAVE_NMI_SAFE_CMPXCHG
> +	select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
>   	select ARCH_MIGHT_HAVE_ACPI_PDC		if ACPI
>   	select ARCH_MIGHT_HAVE_PC_PARPORT
>   	select ARCH_MIGHT_HAVE_PC_SERIO
> @@ -2610,9 +2611,6 @@ config ARCH_HAS_ADD_PAGES
>   	def_bool y
>   	depends on ARCH_ENABLE_MEMORY_HOTPLUG
>   
> -config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
> -	def_bool y
> -
>   menu "Power management and ACPI options"
>   
>   config ARCH_HIBERNATION_HEADER
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 923bd35f81f2..2f9d28fee75d 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -570,6 +570,9 @@ config MHP_MEMMAP_ON_MEMORY
>   	depends on MEMORY_HOTPLUG && SPARSEMEM_VMEMMAP
>   	depends on ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
>   
> +config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
> +       bool
> +
>   endif # MEMORY_HOTPLUG
>   
>   # Heavily threaded applications may benefit from splitting the mm-wide

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb