From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D17FC02180 for ; Mon, 13 Jan 2025 10:06:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B34F66B008C; Mon, 13 Jan 2025 05:06:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE52A6B0092; Mon, 13 Jan 2025 05:06:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95E396B0093; Mon, 13 Jan 2025 05:06:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 75FAD6B008C for ; Mon, 13 Jan 2025 05:06:34 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2AEF9AF06E for ; Mon, 13 Jan 2025 10:06:34 +0000 (UTC) X-FDA: 83001999108.16.E80562E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 90B24140012 for ; Mon, 13 Jan 2025 10:06:31 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B2ZCWrcB; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736762791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QMLyxLxpwIbseMdl1XyknNit15mtfYNolUiL1qEghYg=; b=yDzGUVaUgLsKq9Fm5C7aBCaTRAANc/KlT54tZDuuzFrMrB3XVkM7kLGrJ9Kq8PIzs3AL9d bevTsEQ2aVDy6idD9wx41kgf3M07OTuNDb3Z07DHUwXbbdn6Uajh7SLFqdQfN4jB+nP69o gbJ1x0QGGSpvDa7IHMJaSodNbUlDWRU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B2ZCWrcB; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736762791; a=rsa-sha256; cv=none; b=Ci1vi77AAI9TzaI+QdbUYjKUbxvQ6osqODJICUTP6lDhxcbLeKb2aa6trjU0x7k/NIoz2V vwG8mGewrOsIeVnNolP6AUR9NepKkwY3sfjcB0HbEUeB3k/3pFvKKn8mObKwjpYPkGfcRQ iYiagkGpnm7rsZAfpSro8YDuZOcuFcY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736762791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QMLyxLxpwIbseMdl1XyknNit15mtfYNolUiL1qEghYg=; b=B2ZCWrcBM4W3HIhcRKlsceZ3rkAIiW88BYA91SYVVMN6m9rTAnlOW/HFQgfp4kWDSeydQJ RB7rVIzrCyi0LH6TaOSZSLyosZP0ltDzdRMQ96DTJvXeBAjBpYW9qK7jH/drjPYXp+FZlE n5pgbiKqGA5c5FhW1LDSepE6AzsmtgE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-m4tIn8u5Mnu3n_w3uDBqCQ-1; Mon, 13 Jan 2025 05:06:29 -0500 X-MC-Unique: m4tIn8u5Mnu3n_w3uDBqCQ-1 X-Mimecast-MFC-AGG-ID: m4tIn8u5Mnu3n_w3uDBqCQ Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385e00ebb16so1516560f8f.3 for ; Mon, 13 Jan 2025 02:06:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736762788; x=1737367588; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QMLyxLxpwIbseMdl1XyknNit15mtfYNolUiL1qEghYg=; b=hDlmGyqf60+ECDQeOxiGmjbKjHcAvApcBT5zAwmSy7TbNUykm34uobu7zH/STK2edC c9qb1KSdqxsKuiqkUOeirejW2hPa6kBbfcfOch1BbKjqLvAIH17pVZ1jKOtJBTVPxg+n 640Pd/qXYfSgp9yL/H+kCKbTMTBO380vbJgEN7m7Nkfwl4lssZ62iM/Hp8OyRug4CShz bOC/VtxeLsyknoZlVdnXNRe0KOOvwdE8FBvfs1YvPXzITcmSBIHoeinrcnyCLTH20r1P z2VcLnt1Zn5+pIm6u3IkZtjnMMzR4oHz/u8dNCzsO4CbaZ+BAZcRff8xVC4ZG7Qw4AHC NFrw== X-Forwarded-Encrypted: i=1; AJvYcCWzF++vEHzPNYJJXNU30IRuPosFBMmS77jhtsiSXmZLBkLAGnzMJOKIxQg3pJ2gY1AggYJVqCKINg==@kvack.org X-Gm-Message-State: AOJu0Yx7D0fb6IdIOcnMIunQ/Q2BsOAAixn18QsftHaK/+/Y6+fU66+Q tLH4frrNlZ+N75BwlvlIunwYRFc6u4yStJ5racSNHaApliuQaLJrp++MMV8mYeMBX1uUEEZe5Ae L9cuVUS4Xq74k27tZRC/KiS6zxn8tgzMxTyMZpEfaqb0mp4Rf X-Gm-Gg: ASbGncsxVPeOE4LyFkVOuxDnGvw2nfSMT+dFt+j1k8q31fw1kPqgWRhPqaHaH+VtMQx 1zSfYy25cFrNvdQ/7vI4le0F1MpYxoF8NN9MVxHJ9hOycy1pjgIprcf2AzzI9RkLrlZoH5sl2Pa SzIIojGYZyCo8ywf7s/X+/GFPHoguLU5gJ/rXjtP1HDr4FRf4cR+xrdiNXxbKnEJVhMOx/sTPWa epJjG+FwT20sIJQwLLXSN9da7mry3Q3F+qRcZErgcwq706do1QZddhOGhkcIxjHegLQBHNb+4+4 bYOsOaPR6P7CEM0= X-Received: by 2002:a05:6000:1569:b0:38b:d8e0:a864 with SMTP id ffacd0b85a97d-38bd8e0a959mr3433858f8f.55.1736762788444; Mon, 13 Jan 2025 02:06:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IG80aCPWv5Tkap1khe9cIhWYNYkL4nZeIGVqq21uLPoBZh6ApAk/cioVDleOsi9z3XujM7seg== X-Received: by 2002:a05:6000:1569:b0:38b:d8e0:a864 with SMTP id ffacd0b85a97d-38bd8e0a959mr3433808f8f.55.1736762788038; Mon, 13 Jan 2025 02:06:28 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4c3428sm11480131f8f.87.2025.01.13.02.06.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 02:06:27 -0800 (PST) Message-ID: <136d0ec9-38a0-4de0-b5e1-d68686d5692d@redhat.com> Date: Mon, 13 Jan 2025 11:06:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] drm/i915/gem: Use PG_dropbehind instead of PG_reclaim To: "Kirill A. Shutemov" , Andrew Morton , "Matthew Wilcox (Oracle)" , Jens Axboe Cc: "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20250113093453.1932083-1-kirill.shutemov@linux.intel.com> <20250113093453.1932083-3-kirill.shutemov@linux.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250113093453.1932083-3-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vzAyCChWe0clzvXMsnCS_D5aX3pR6kdLH0xwuhpRdnI_1736762788 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 90B24140012 X-Rspamd-Server: rspam12 X-Stat-Signature: w67oba91g9mn3yzdx8odj5jjdf7cr7i1 X-Rspam-User: X-HE-Tag: 1736762791-759397 X-HE-Meta: U2FsdGVkX19v9vxIgFEFeZoyRKkqdtmW8EDes8JO3JcvVDLk4m1WdYF9Rq3WS6gzDh7iCCP3x/Yn0L0FsYvaoScPdYkbogURKXupbtAzPWcSRxGE+uBk+u4VNC4/5a04CtR6zDvXk5F82Zv+yBe4yKPSSRHwRh90VD/mNX4jDS37wnN06Iid5Tx+D4nmqTtXNGeBlfoOOtE0kiVSRAOiCDVfHyST4CrXLN+NuxfN5hccV4wI0qS+sHOhY6kNUop4httGCH9Yb88XE3To5aqCqPhYbjW87oz5my9tFuogIWPTmmahXx3HVVGJxiSlzmbcG1pxPKtU1NACWhHh4thcMm1gv+/CH3AlVKrGmaQ/467/V0YdhVTLAccxmDHDp4bB7bXMQkVOjVpZCxr727XJu2JryLLPQsY+Hfc+sKktnubaqo23nMa4DpFLSt/ZdZ8Vt3jVHnkL7/fhQr/8ZDv5EfhbhLep4RB72nuNWXBUrFFk4Hc1kUOm4ed5NEA32D/uEt47KQj1c2pmtdBhWjG03fVzQJ13rnaOzFfJJsFyCudsZ0XHwN9q3FlaaIKVB43IojHWyUpUrXQuZ3g8DSP4Jj2tLaoCNP5N4kfx/MwwVIFNZDAPmwqe+I9C0toKWsv7u/uXUhksVboqJHYOhEqARH3/x2nLW2YFUn1MfULe8vuCQGvbwTRFp4mThaGMYrqt9BHDmJEOO2UO/693xximqE0ZvQmYL6/npOEzMvcQ8BL5B4evGscEXjK+MpLpcQSSSg4vVSld6rdQEdeTrofyQMvNw7d+vzF4TOGLazsoV2rVgtIx5IdSw6ZdEluJkbW6a0ZdZV31EwIc+xXdWsS+AQWE0mhUymMSLEKdlwiWx4wGDc1s3J4HQDdgMvG41vs2Dxeq3h47F/8/0KkcCGIUlqOMAEApARPtSJjPkAwqu67TfPX/3FD6OH1w/TmP1WWKrpVyKj4ek0cbNVosVOB fzqPdn4N VAh8e01qJd+Gpmst6ZiOu1EyFP54Vpdc8XQPCRwnRBgvDbFKNIL027AKfArnEICNU44U6sq78NENOBDfarh3jAcPhjODUp7TJ5c8xXQ92GppqLHKTE4NLZNQRY96gYuHjolXqAlIkTKh81uFhp8YkAe04GKgd637LfL23bVp5lqWp+wAI2XZAe0zSaUOJ4FriSMdRtK110eHKJiHcF9Zm3rBVcTa5I5aYFzgg0o1qA3Ka4IYxc1taEvjtanYgOPit2aT2TatEFnOk3JwX12ARroug9m4xG4JwTFYRofXPJpMfrL1ooWHXs/j6ezpBabJvDu0SOF/7th+o2R1Kv14r2rbYyWXoV/eYfjrJv7sl+GHXDLwZzaY8nJgojPd++qKaPLE+pm7QABzvlxI72bmENHgYd5bymAXL807BCpR/ELsfE/D1bUd6gEPLdBf832GN7LuuW9HqFq7EPkTI8y+Kc4miLQrdjwgm01u4hdKkWK1jknIWxLka8bkRmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.01.25 10:34, Kirill A. Shutemov wrote: > The recently introduced PG_dropbehind allows for freeing folios > immediately after writeback. Unlike PG_reclaim, it does not need vmscan > to be involved to get the folio freed. > > Instead of using folio_set_reclaim(), use folio_set_dropbehind() in > __shmem_writeback() > > It is safe to leave PG_dropbehind on the folio if, for some reason > (bug?), the folio is not in a writeback state after ->writepage(). > In these cases, the kernel had to clear PG_reclaim as it shared a page > flag bit with PG_readahead. I think this is correct Acked-by: David Hildenbrand -- Cheers, David / dhildenb