From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: bob.liu@oracle.com, dan.magenheimer@oracle.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, xen-devel@lists.xensource.com
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH 4/9] xen/tmem: Fix compile warning.
Date: Tue, 14 May 2013 14:09:21 -0400 [thread overview]
Message-ID: <1368554966-30469-5-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1368554966-30469-1-git-send-email-konrad.wilk@oracle.com>
We keep on getting:
drivers/xen/tmem.c:65:13: warning: a??disable_frontswap_selfshrinkinga?? defined but not used [-Wunused-variable]
if CONFIG_FRONTSWAP=y and # CONFIG_CLEANCACHE is not set
Found by 0 day test project
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
drivers/xen/tmem.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/xen/tmem.c b/drivers/xen/tmem.c
index c2ee188..30bf974 100644
--- a/drivers/xen/tmem.c
+++ b/drivers/xen/tmem.c
@@ -61,14 +61,12 @@ __setup("nofrontswap", no_frontswap);
#endif
#endif /* CONFIG_FRONTSWAP */
-#ifdef CONFIG_FRONTSWAP
+#ifdef CONFIG_XEN_SELFBALLOONING
static bool disable_frontswap_selfshrinking __read_mostly;
#ifdef CONFIG_XEN_TMEM_MODULE
module_param(disable_frontswap_selfshrinking, bool, S_IRUGO);
-#else
-#define disable_frontswap_selfshrinking 1
#endif
-#endif /* CONFIG_FRONTSWAP */
+#endif /* CONFIG_XEN_SELFBALLOONING */
#define TMEM_CONTROL 0
#define TMEM_NEW_POOL 1
--
1.7.7.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-14 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 18:09 [PATCH] Fixes, cleanups, compile warning fixes, and documentation update for Xen tmem driver (v2) Konrad Rzeszutek Wilk
2013-05-14 18:09 ` [PATCH 1/9] xen/tmem: Cleanup. Remove the parts that say temporary Konrad Rzeszutek Wilk
2013-05-14 18:09 ` [PATCH 2/9] xen/tmem: Move all of the boot and module parameters to the top of the file Konrad Rzeszutek Wilk
2013-05-14 18:09 ` [PATCH 3/9] xen/tmem: Split out the different module/boot options Konrad Rzeszutek Wilk
2013-05-14 18:09 ` Konrad Rzeszutek Wilk [this message]
2013-05-14 18:09 ` [PATCH 5/9] xen/tmem: s/disable_// and change the logic Konrad Rzeszutek Wilk
2013-05-14 18:09 ` [PATCH 6/9] xen/tmem: Remove the boot options and fold them in the tmem.X parameters Konrad Rzeszutek Wilk
2013-05-14 18:09 ` [PATCH 7/9] xen/tmem: Remove the usage of 'noselfshrink' and use 'tmem.selfshrink' bool instead Konrad Rzeszutek Wilk
2013-05-14 18:09 ` [PATCH 8/9] xen/tmem: Remove the usage of '[no|]selfballoon' and use 'tmem.selfballooning' " Konrad Rzeszutek Wilk
2013-05-14 18:09 ` [PATCH 9/9] xen/tmem: Don't use self[ballooning|shrinking] if frontswap is off Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368554966-30469-5-git-send-email-konrad.wilk@oracle.com \
--to=konrad@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bob.liu@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox