linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: j.glisse@gmail.com
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Jerome Glisse <jglisse@redhat.com>
Subject: [PATCH] mm: honor FOLL_GET flag in follow_hugetlb_page v2
Date: Tue,  7 May 2013 18:58:42 -0400	[thread overview]
Message-ID: <1367967522-3934-1-git-send-email-j.glisse@gmail.com> (raw)

From: Jerome Glisse <jglisse@redhat.com>

Do not increase page count if FOLL_GET is not set. None of the
current user can trigger the issue because none of the current
user call __get_user_pages with both the pages array ptr non
NULL and the FOLL_GET flags non set in other word all caller
of __get_user_pages that don't set the FOLL_GET flags also call
with pages == NULL.

v2: Do not use get_page_foll. Improved comment.

Signed-off-by: Jerome Glisse <jglisse@redhat.com>
---
 mm/hugetlb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index ca9a7c6..32f323b 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2981,7 +2981,9 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma,
 same_page:
 		if (pages) {
 			pages[i] = mem_map_offset(page, pfn_offset);
-			get_page(pages[i]);
+			if (flags & FOLL_GET) {
+				get_page(pages[i]);
+			}
 		}
 
 		if (vmas)
-- 
1.7.11.7

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2013-05-07 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07 22:58 j.glisse [this message]
2013-05-08  0:47 ` KOSAKI Motohiro
2013-05-08  0:51   ` Jerome Glisse
2013-05-08  2:41     ` KOSAKI Motohiro
2013-05-08 14:33       ` Jerome Glisse
2013-05-08 23:41         ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367967522-3934-1-git-send-email-j.glisse@gmail.com \
    --to=j.glisse@gmail.com \
    --cc=jglisse@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox