From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 148F2C54E67 for ; Tue, 26 Mar 2024 15:36:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7224D6B0096; Tue, 26 Mar 2024 11:36:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AB1C6B0099; Tue, 26 Mar 2024 11:36:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5246F6B009B; Tue, 26 Mar 2024 11:36:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4009A6B0096 for ; Tue, 26 Mar 2024 11:36:24 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0FC72A06A5 for ; Tue, 26 Mar 2024 15:36:24 +0000 (UTC) X-FDA: 81939591888.29.0AEB249 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id A2B11140012 for ; Tue, 26 Mar 2024 15:36:21 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AZXOr71e; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711467381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3IoP/uIjCVx3xjBmhXcu+ibQvDzjCyC7N9xRWM9JDXA=; b=72D/xewhHK85cREVNN0HN+t67MGQaKizR7oFpToWbJy2aDSxMPUcjG9BxurRbVaR2kOQ3S aZ9VoAfXh2uyI8YK0QuzxXj8Z10ivBCcb/riD1HAdJYshD4PV4EtMO48kNxJRqb6Wc3MFI EfvMWDH2EizHxEWTfzfixA0Rb9JTEu4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711467381; a=rsa-sha256; cv=none; b=CAu0yj9/mTbe6L5JM92JY8OCt+nvwBEHkQI7LG9RJFBX/IbxpcKImNHrYzhojYeUeE+elL vNretFCnVNBfDYWl7diFvVRx+Fm1mSjyYzwOVnySkoi+IAs3F5/RNmBx+wwOSX5rBnNHxT aT6ApQOrQE9dsSJACvGpfuywNgPcZa0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AZXOr71e; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711467381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3IoP/uIjCVx3xjBmhXcu+ibQvDzjCyC7N9xRWM9JDXA=; b=AZXOr71eE3gYu6Ca0jawWcrJHZqj1vhab1zf1T3B4TNLmGWkMXEt0rXI4qOW7fFbWbyZaX mfIRIgkzNgdVoM4K24cCyaB+GpV3afpKV4y34gDnzuEHZv5iReE+3R1fICXnSRLyyaj6/z XxpEOGJi9Q47uhZJciRRU47yl3HcQYY= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-502-ujoYmLAnMhSJRo1YLJTRNg-1; Tue, 26 Mar 2024 11:36:19 -0400 X-MC-Unique: ujoYmLAnMhSJRo1YLJTRNg-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d6c82d12b5so27680421fa.1 for ; Tue, 26 Mar 2024 08:36:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711467378; x=1712072178; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3IoP/uIjCVx3xjBmhXcu+ibQvDzjCyC7N9xRWM9JDXA=; b=H6PumLuaIEdm2cjkI3CwQ3izKE3ljdkr9qOGtUjgmbrwsmfg8wLXIDoT16AU4G9OQk 4zzsQl++SeocKh+7o4l2W6T88Np50DQSbcbdJ6QFv2FZuIWEu+psvp9+i6Kvx38kzuD8 Im2GbjLrFsh1aIoe2y3RZEMKtyoV1T98DOoFtFTPN6wx15kq7BSLfroHta+2u3C8HRZz 3qZS2gmN37dQJKbnTnn9u19qzZMaWFT93acJWtJMTECypewDQ3UaDTNnVdsOVIYmy2XM /qEof3Twntx88Tt8bm5HHbCZvLaKhE/YJCn//luXOMBC02wwp6cKPWF3mCsEaBb0GorI m1lA== X-Forwarded-Encrypted: i=1; AJvYcCWhlh+bBmq+Ys8K+6MpR7pmFR+weCN2EUlLONi6nUK325CqoBa2CXTe8zY15x4+vqY8kmYN3xLk7wuAfycygm2u2EM= X-Gm-Message-State: AOJu0Yx5Nkj9JgqWCl+/FQF+kuDc76g0dm4t41Vl1hIoYBnbAH+CIKpS kiIvUQltThmVbe0o2MzKOllKKXwPDdmmKeXHrE0PxgxUfHBC631u1T4dGKX/ati3zBx4TsLp89R kLgiQRCD5vXxp9JmLcFU/DTG/lTgYPev0gA9KMoRbqClfXuNa X-Received: by 2002:a2e:9e17:0:b0:2d3:3305:c373 with SMTP id e23-20020a2e9e17000000b002d33305c373mr4433ljk.3.1711467377979; Tue, 26 Mar 2024 08:36:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2h4q41+sxDzjlavGKRpW//ZC/MnJzwFbRClX0GSm1CQrH9mLaodYkZHwfcA8JxvlzSDq1iw== X-Received: by 2002:a2e:9e17:0:b0:2d3:3305:c373 with SMTP id e23-20020a2e9e17000000b002d33305c373mr4421ljk.3.1711467377601; Tue, 26 Mar 2024 08:36:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c741:c700:3db9:94c9:28b0:34f2? (p200300cbc741c7003db994c928b034f2.dip0.t-ipconnect.de. [2003:cb:c741:c700:3db9:94c9:28b0:34f2]) by smtp.gmail.com with ESMTPSA id t21-20020a05600c451500b004146e58cc35sm11991594wmo.46.2024.03.26.08.36.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 08:36:17 -0700 (PDT) Message-ID: <1365c52b-2883-4b1a-aa9f-f587e38df695@redhat.com> Date: Tue, 26 Mar 2024 16:36:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] selftests/memfd_secret: add vmsplice() test To: Miklos Szeredi Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Rapoport , Lorenzo Stoakes , xingwei lee , yue sun References: <20240326143210.291116-1-david@redhat.com> <20240326143210.291116-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A2B11140012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: htsimmp63bqaiztgpyuyi7wdyp18epfe X-HE-Tag: 1711467381-143961 X-HE-Meta: U2FsdGVkX1/r7E5lFXGx1Wj2cZbN7K6513OAxIkBNKB9V+9Dn7I47QhjMX3C2k3Dmzo5mvJHu6DCUIpuWN3yIsNDK7izefMr44GljgFZiCiTrAyf9Yefay1R4Z1jkVvDgMgf8c+tBIadKvLM2fN8aW9xNDp7V4VfYQTlpbmuVpF6Suopbwo4Z+aUPM1Pcf3lOZ2USXTH/fOW2KgoPU+RNL+9uGPNsXw8Y18cyHcgUh7JGJ/QwS/Xp4yZcekStd47/s+P1VB7ydG/X3q9+h8Lb24XTNSwuhgmfzjB0vFg3yKJQ1yEafHu8CmYeTe/KyNfV0uBZlSdyH6QM8IGgXR1pXuJGEOIqKub0NndArMGFRB6Gr3P+tWevT+JfiMedUn/PQELs2evotO3W998grNRyaw8NTdQIj6tVAZfEQAVJrY8C6FXeMxbXJkz/YNWLWWj3P4ArsT9zh4qDr6w2cQ2W/39LMrYDTgmW6Shjav0cwNQ77vYWIkTz9gLwiS85y0Yc/XXlgInYJChJVrLn1RG/pVXCkF9vz8zc5F8eTCr6fPY5N7UfAHkGBFvy4ilHiOHBPJQF2ULzRqb/crmmiXvaJFlQpPCjYLF3b14WnHNNk86VT2H1spuFgTMNJtaJbicEigCTESwcOz5w5DpgYZDM77MvdlsZpG6NK/zusOKEowWuLcodAqu8CFh4Sm1+zpOp6Pcv6G9ipW+3XVARECC86GcjytP2aIW+8oLdSas3hilZLWf9Sb9pGbDTNGVHkaYdCg9E5QzODjPUX5E1C0+klqtJshcQZY3FoY15PA8jBv/Ytd3AzO7bdgMlFKEQ0F+1rTVCLAeeOmnFeaAOxOwHPqvxxcr69jBvcnMoahjop7Br2AGXHCvaRP1xXJ5rzGXkBdEV0hQyHgJO8gJBaKlKzI1YIGG8aWZ8KFUGtPuJ9zdR4VRb3fyVhGfJbUdydpF4S0tXzshBlrdS0BVTOL 67s85Ol5 L4yOJN6S6kIUXJF3rLN7YB1rD9HLqA0qixvtvN0RERP3pVazukYOqIc7ZSwAgLYDJeiHmAiYWWLHIf+ZgMrnMixkv8HlCqGvKrqQOCTbhPUJxlcoGBpgVk5wBUezDqC4olck3xaDuyPICGP+yAD5qpcnTdZqtStssI18EmK1TljFibhyVdYOaTwd10no/usKNpzo49WIHPZfiCyGxEBRIpXsYoisy5LW1/Y8HLtrlG5SFebRMyUIX4WzQ22otv5treEE46KW8F7dgYiAP/RjAG0Zf+VZ8NVL+UTzAYkXrt7JMpb9R4fpTlNdg1aamCHixkzoSBfXpZNIyYkUt1K6QLGKTZsspbSH9Gae4GZTzwJfpciLouu/5IK0FTdjGZrIy18BpnJ82gCPHFPdkoGb6nOfS/Fv2NRz00FNEUGUK3IYQKZauIJ0Uv3tKpOu5Q9wE/Td1B3ui7DDx98QWMUAd7J/0DQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> +static void test_vmsplice(int fd, const char *desc) >> +{ >> + ssize_t transferred; >> + struct iovec iov; >> + int pipefd[2]; >> + char *mem; >> + >> + if (pipe(pipefd)) { >> + fail("pipe failed: %s\n", strerror(errno)); >> + return; >> + } >> + >> + mem = mmap(NULL, page_size, prot, mode, fd, 0); >> + if (mem == MAP_FAILED) { >> + fail("Unable to mmap secret memory\n"); >> + goto close_pipe; >> + } >> + >> + /* >> + * vmsplice() may use GUP-fast, which must also fail. Prefault the >> + * page table, so GUP-fast could find it. >> + */ >> + memset(mem, PATTERN, page_size); > > Shouldn't the non-prefault case be tested as well? That's the "easy" case where GUP-fast is never involved, and it should mostly be covered by the ptrace/process_vm_read() tests already. -- Cheers, David / dhildenb