From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx127.postini.com [74.125.245.127]) by kanga.kvack.org (Postfix) with SMTP id 142536B0006 for ; Mon, 1 Apr 2013 13:21:50 -0400 (EDT) From: Naoya Horiguchi Subject: [PATCH v2 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB) Date: Mon, 1 Apr 2013 13:21:21 -0400 Message-Id: <1364836882-9713-2-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1364836882-9713-1-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1364836882-9713-1-git-send-email-n-horiguchi@ah.jp.nec.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Mel Gorman , Hugh Dickins , Rik van Riel , KOSAKI Motohiro , Konstantin Khlebnikov , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit 314e51b98 "mm: kill vma flag VM_RESERVED and mm->reserved_vm counter". This looks to me a serious regression, so let's fix it. ChangeLog v2: - add 'return 0' in hugepage memory check Signed-off-by: Naoya Horiguchi Acked-by: Konstantin Khlebnikov Acked-by: Michal Hocko Cc: stable@vger.kernel.org --- fs/binfmt_elf.c | 1 + fs/hugetlbfs/inode.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git v3.9-rc3.orig/fs/binfmt_elf.c v3.9-rc3/fs/binfmt_elf.c index 3939829..86af964 100644 --- v3.9-rc3.orig/fs/binfmt_elf.c +++ v3.9-rc3/fs/binfmt_elf.c @@ -1137,6 +1137,7 @@ static unsigned long vma_dump_size(struct vm_area_struct *vma, goto whole; if (!(vma->vm_flags & VM_SHARED) && FILTER(HUGETLB_PRIVATE)) goto whole; + return 0; } /* Do not dump I/O mapped devices or special mappings */ diff --git v3.9-rc3.orig/fs/hugetlbfs/inode.c v3.9-rc3/fs/hugetlbfs/inode.c index 84e3d85..523464e 100644 --- v3.9-rc3.orig/fs/hugetlbfs/inode.c +++ v3.9-rc3/fs/hugetlbfs/inode.c @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma) * way when do_mmap_pgoff unwinds (may be important on powerpc * and ia64). */ - vma->vm_flags |= VM_HUGETLB | VM_DONTEXPAND | VM_DONTDUMP; + vma->vm_flags |= VM_HUGETLB | VM_DONTEXPAND; vma->vm_ops = &hugetlb_vm_ops; if (vma->vm_pgoff & (~huge_page_mask(h) >> PAGE_SHIFT)) -- 1.7.11.7 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org