From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx177.postini.com [74.125.245.177]) by kanga.kvack.org (Postfix) with SMTP id C6D256B0005 for ; Thu, 28 Mar 2013 14:29:25 -0400 (EDT) Date: Thu, 28 Mar 2013 14:29:18 -0400 From: Naoya Horiguchi Message-ID: <1364495358-2gnie765-mutt-n-horiguchi@ah.jp.nec.com> In-Reply-To: <515477D4.1060206@openvz.org> References: <1364485358-8745-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1364485358-8745-2-git-send-email-n-horiguchi@ah.jp.nec.com> <515477D4.1060206@openvz.org> Subject: Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB) Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: Konstantin Khlebnikov Cc: Andrew Morton , Mel Gorman , Hugh Dickins , Rik van Riel , KOSAKI Motohiro , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Thu, Mar 28, 2013 at 09:03:16PM +0400, Konstantin Khlebnikov wrote: > Naoya Horiguchi wrote: > >Currently we fail to include any data on hugepages into coredump, > >because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently > >introduced by commit 314e51b98 "mm: kill vma flag VM_RESERVED and > >mm->reserved_vm counter". This looks to me a serious regression, > >so let's fix it. > > That was introduced in my patch? Really? > Here was VM_RESERVED and it had the same effect as VM_DONTDUMP. At least I thought so. vma_dump_size() does like this (the diff is the one in 314e51b98): static unsigned long vma_dump_size(struct vm_area_struct *vma, unsigned long mm_flags) { #define FILTER(type) (mm_flags & (1UL << MMF_DUMP_##type)) /* always dump the vdso and vsyscall sections */ if (always_dump_vma(vma)) goto whole; if (vma->vm_flags & VM_DONTDUMP) return 0; /* Hugetlb memory check */ if (vma->vm_flags & VM_HUGETLB) { if ((vma->vm_flags & VM_SHARED) && FILTER(HUGETLB_SHARED)) goto whole; if (!(vma->vm_flags & VM_SHARED) && FILTER(HUGETLB_PRIVATE)) goto whole; } /* Do not dump I/O mapped devices or special mappings */ - if (vma->vm_flags & (VM_IO | VM_RESERVED)) + if (vma->vm_flags & VM_IO) return 0; We have hugetlb memory check after VM_DONTDUMP check, so the following changed the behavior. --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma) * way when do_mmap_pgoff unwinds (may be important on powerpc * and ia64). */ - vma->vm_flags |= VM_HUGETLB | VM_RESERVED; + vma->vm_flags |= VM_HUGETLB | VM_DONTEXPAND | VM_DONTDUMP; vma->vm_ops = &hugetlb_vm_ops; if (vma->vm_pgoff & (~huge_page_mask(h) >> PAGE_SHIFT)) I think we don't have to set VM_DONTDUMP on hugetlbfs's vma. Thanks, Naoya -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org