From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Qi Zheng <qi.zheng@linux.dev>,
mboone@akamai.com, Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] mm/pagewalk: fix race between concurrent split and refault
Date: Wed, 18 Mar 2026 08:38:57 +0100 [thread overview]
Message-ID: <13624f64-a624-48ac-94b9-f43689441316@kernel.org> (raw)
In-Reply-To: <268abf39-9cd6-412e-b3ec-32fb8fea1684@linux.dev>
>> +
>> pmd = pmd_offset(pud, addr);
>> do {
>> again:
>> @@ -218,12 +231,13 @@ static int walk_pud_range(p4d_t *p4d, unsigned
>> long addr, unsigned long end,
>> else if (pud_leaf(*pud) || !pud_present(*pud))
>> continue; /* Nothing to do. */
>
> Why not check pudval directly here? Like the following:
>
As the patch description states: "This mirrors the
retry logic in walk_pmd_range()."
--
Cheers,
David
next prev parent reply other threads:[~2026-03-18 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 14:03 Max Boone via B4 Relay
2026-03-17 14:05 ` David Hildenbrand (Arm)
2026-03-18 6:16 ` Qi Zheng
2026-03-18 7:37 ` Boone, Max
2026-03-18 7:38 ` David Hildenbrand (Arm) [this message]
2026-03-18 12:55 ` Lorenzo Stoakes (Oracle)
2026-03-18 13:08 ` Boone, Max
2026-03-18 13:27 ` Boone, Max
2026-03-18 14:07 ` Lorenzo Stoakes (Oracle)
2026-03-18 14:10 ` Lorenzo Stoakes (Oracle)
2026-03-18 14:30 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13624f64-a624-48ac-94b9-f43689441316@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mboone@akamai.com \
--cc=mhocko@suse.com \
--cc=qi.zheng@linux.dev \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox