From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org,
linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Michal Nazarewicz <mina86@mina86.com>,
Minchan Kim <minchan@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [RFC/PATCH 1/5] mm: introduce migrate_replace_page() for migrating page to the given target
Date: Tue, 05 Mar 2013 07:57:55 +0100 [thread overview]
Message-ID: <1362466679-17111-2-git-send-email-m.szyprowski@samsung.com> (raw)
In-Reply-To: <1362466679-17111-1-git-send-email-m.szyprowski@samsung.com>
Introduce migrate_replace_page() function for migrating single page to the
given target page.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
include/linux/migrate.h | 5 ++++
mm/migrate.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 64 insertions(+)
diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index a405d3dc..3a8a6c1 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -35,6 +35,8 @@ enum migrate_reason {
#ifdef CONFIG_MIGRATION
+extern int migrate_replace_page(struct page *oldpage, struct page *newpage);
+
extern void putback_lru_pages(struct list_head *l);
extern void putback_movable_pages(struct list_head *l);
extern int migrate_page(struct address_space *,
@@ -57,6 +59,9 @@ extern int migrate_huge_page_move_mapping(struct address_space *mapping,
struct page *newpage, struct page *page);
#else
+static inline int migrate_replace_page(struct page *oldpage,
+ struct page *newpage) { return -ENOSYS; }
+
static inline void putback_lru_pages(struct list_head *l) {}
static inline void putback_movable_pages(struct list_head *l) {}
static inline int migrate_pages(struct list_head *l, new_page_t x,
diff --git a/mm/migrate.c b/mm/migrate.c
index 3bbaf5d..a2a6950 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1067,6 +1067,65 @@ out:
return rc;
}
+/*
+ * migrate_replace_page
+ *
+ * The function takes one single page and a target page (newpage) and
+ * tries to migrate data to the target page. The caller must ensure that
+ * the source page is locked with one additional get_page() call, which
+ * will be freed during the migration. The caller also must release newpage
+ * if migration fails, otherwise the ownership of the newpage is taken.
+ * Source page is released if migration succeeds.
+ *
+ * Return: error code or 0 on success.
+ */
+int migrate_replace_page(struct page *page, struct page *newpage)
+{
+ struct zone *zone = page_zone(page);
+ unsigned long flags;
+ int ret = -EAGAIN;
+ int pass;
+
+ migrate_prep();
+
+ spin_lock_irqsave(&zone->lru_lock, flags);
+
+ if (PageLRU(page) &&
+ __isolate_lru_page(page, ISOLATE_UNEVICTABLE) == 0) {
+ struct lruvec *lruvec = mem_cgroup_page_lruvec(page, zone);
+ del_page_from_lru_list(page, lruvec, page_lru(page));
+ spin_unlock_irqrestore(&zone->lru_lock, flags);
+ } else {
+ spin_unlock_irqrestore(&zone->lru_lock, flags);
+ return -EAGAIN;
+ }
+
+ /* page is now isolated, so release additional reference */
+ put_page(page);
+
+ for (pass = 0; pass < 10 && ret != 0; pass++) {
+ cond_resched();
+
+ if (page_count(page) == 1) {
+ /* page was freed from under us, so we are done */
+ ret = 0;
+ break;
+ }
+ ret = __unmap_and_move(page, newpage, 1, MIGRATE_SYNC);
+ }
+
+ if (ret == 0) {
+ /* take ownership of newpage and add it to lru */
+ putback_lru_page(newpage);
+ } else {
+ /* restore additional reference to the oldpage */
+ get_page(page);
+ }
+
+ putback_lru_page(page);
+ return ret;
+}
+
#ifdef CONFIG_NUMA
/*
* Move a list of individual pages
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-05 6:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 6:57 [RFC/PATCH 0/5] Contiguous Memory Allocator and get_user_pages() Marek Szyprowski
2013-03-05 6:57 ` Marek Szyprowski [this message]
2013-03-05 6:57 ` [RFC/PATCH 2/5] mm: get_user_pages: use static inline Marek Szyprowski
2013-03-05 6:57 ` [RFC/PATCH 3/5] mm: get_user_pages: use NON-MOVABLE pages when FOLL_DURABLE flag is set Marek Szyprowski
2013-03-06 2:02 ` Yasuaki Ishimatsu
2013-03-06 9:30 ` Lin Feng
2013-03-06 10:53 ` Lin Feng
2013-05-06 7:19 ` Tang Chen
2013-05-07 10:47 ` Marek Szyprowski
2013-05-08 5:33 ` Tang Chen
2013-03-05 6:57 ` [RFC/PATCH 4/5] mm: get_user_pages: migrate out CMA " Marek Szyprowski
2013-03-06 2:41 ` Yasuaki Ishimatsu
2013-03-05 6:57 ` [RFC/PATCH 5/5] media: vb2: use FOLL_DURABLE and __get_user_pages() to avoid CMA migration issues Marek Szyprowski
2013-03-05 8:50 ` [RFC/PATCH 0/5] Contiguous Memory Allocator and get_user_pages() Arnd Bergmann
2013-03-05 13:47 ` Marek Szyprowski
2013-03-05 19:59 ` Arnd Bergmann
2013-03-05 22:42 ` Daniel Vetter
2013-03-06 1:34 ` Yasuaki Ishimatsu
2013-03-06 8:47 ` Minchan Kim
2013-03-06 10:48 ` Marek Szyprowski
2013-03-06 11:57 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362466679-17111-2-git-send-email-m.szyprowski@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox