linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* FIX [0/2] Slub hot path fixes
@ 2013-01-23 21:45 Christoph Lameter
  2013-01-23 21:55 ` Steven Rostedt
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Lameter @ 2013-01-23 21:45 UTC (permalink / raw)
  To: Pekka Enberg
  Cc: Steven Rostedt, Thomas Gleixner, RT, Clark Williams, John Kacur,
	Luis Claudio R. Goncalves, Joonsoo Kim, Glauber Costa, linux-mm,
	David Rientjes, elezegarcia

These are patches to fix up the issues brought up by Steven Rostedt.

I hoped to avoid the preempt disable for the tid retrieval but there is
no per cpu atomic way to get a value from the per cpu area and also retrieve
the pointer used in that operation. The pointer is necessary to fetch the
related data from the per cpu structure. Without that we
run into more issues with page pointer checks that can cause
freelist corruption in slab_free().


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: FIX [0/2] Slub hot path fixes
  2013-01-23 21:45 FIX [0/2] Slub hot path fixes Christoph Lameter
@ 2013-01-23 21:55 ` Steven Rostedt
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2013-01-23 21:55 UTC (permalink / raw)
  To: Christoph Lameter
  Cc: Pekka Enberg, Thomas Gleixner, RT, Clark Williams, John Kacur,
	Luis Claudio R. Goncalves, Joonsoo Kim, Glauber Costa, linux-mm,
	David Rientjes, elezegarcia

On Wed, 2013-01-23 at 21:45 +0000, Christoph Lameter wrote:
> These are patches to fix up the issues brought up by Steven Rostedt.
> 
> I hoped to avoid the preempt disable for the tid retrieval but there is
> no per cpu atomic way to get a value from the per cpu area and also retrieve
> the pointer used in that operation. The pointer is necessary to fetch the
> related data from the per cpu structure. Without that we
> run into more issues with page pointer checks that can cause
> freelist corruption in slab_free().

Thanks for looking into this. Your can add my "Reported-by" tags to the
patches. Just because I like labels ;-)

-- Steve


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-01-23 21:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-23 21:45 FIX [0/2] Slub hot path fixes Christoph Lameter
2013-01-23 21:55 ` Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox