From: Tang Chen <tangchen@cn.fujitsu.com>
To: akpm@linux-foundation.org, rientjes@google.com,
len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org,
cl@linux.com, minchan.kim@gmail.com,
kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com,
linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de,
yinghai@kernel.org, glommer@parallels.com, jiang.liu@huawei.com,
julian.calaby@gmail.com, sfr@canb.auug.org.au
Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org
Subject: [PATCH Bug fix 4/5] Bug fix: Fix section mismatch problem of release_firmware_map_entry().
Date: Tue, 22 Jan 2013 19:43:03 +0800 [thread overview]
Message-ID: <1358854984-6073-5-git-send-email-tangchen@cn.fujitsu.com> (raw)
In-Reply-To: <1358854984-6073-1-git-send-email-tangchen@cn.fujitsu.com>
The function release_firmware_map_entry() references the function
__meminit firmware_map_find_entry_in_list(). So it should also have
__meminit.
And since the firmware_map_entry->kobj is initialized with memmap_ktype,
the memmap_ktype should also be prefixed by __refdata.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
drivers/firmware/memmap.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c
index 0710179..658fdd4 100644
--- a/drivers/firmware/memmap.c
+++ b/drivers/firmware/memmap.c
@@ -103,7 +103,7 @@ to_memmap_entry(struct kobject *kobj)
return container_of(kobj, struct firmware_map_entry, kobj);
}
-static void release_firmware_map_entry(struct kobject *kobj)
+static void __meminit release_firmware_map_entry(struct kobject *kobj)
{
struct firmware_map_entry *entry = to_memmap_entry(kobj);
@@ -127,7 +127,7 @@ static void release_firmware_map_entry(struct kobject *kobj)
kfree(entry);
}
-static struct kobj_type memmap_ktype = {
+static struct kobj_type __refdata memmap_ktype = {
.release = release_firmware_map_entry,
.sysfs_ops = &memmap_attr_ops,
.default_attrs = def_attrs,
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-22 11:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 11:42 [PATCH Bug fix 0/5] Bug fix for physical memory hot-remove Tang Chen
2013-01-22 11:43 ` [PATCH Bug fix 1/5] Bug fix: consider compound pages when free memmap Tang Chen
2013-01-22 11:43 ` [PATCH Bug fix 2/5] Bug-fix: mempolicy: fix is_valid_nodemask() Tang Chen
2013-01-22 11:43 ` [PATCH Bug fix 3/5] Bug fix: Do not split pages when freeing pagetable pages Tang Chen
2013-01-22 11:43 ` Tang Chen [this message]
2013-01-22 11:43 ` [PATCH Bug fix 5/5] Bug fix: Fix the doc format in drivers/firmware/memmap.c Tang Chen
2013-01-23 12:29 ` [PATCH Bug fix 0/5] Bug fix for physical memory hot-remove Simon Jeons
2013-01-23 13:17 ` Tang Chen
2013-01-24 0:35 ` Simon Jeons
2013-01-24 1:36 ` Tang Chen
2013-01-24 1:48 ` Simon Jeons
2013-01-25 13:17 ` Michal Hocko
2013-01-28 1:33 ` Tang Chen
2013-01-28 8:15 ` Michal Hocko
2013-01-25 18:19 ` Toshi Kani
2013-01-28 1:22 ` Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358854984-6073-5-git-send-email-tangchen@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=julian.calaby@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=paulus@samba.org \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=wency@cn.fujitsu.com \
--cc=wujianguo@huawei.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox