From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx123.postini.com [74.125.245.123]) by kanga.kvack.org (Postfix) with SMTP id 82ED56B0006 for ; Thu, 17 Jan 2013 17:10:48 -0500 (EST) Message-ID: <1358460647.23211.52.camel@gandalf.local.home> Subject: Re: [RFC][PATCH] slub: Check for page NULL before doing the node_match check From: Steven Rostedt Date: Thu, 17 Jan 2013 17:10:47 -0500 In-Reply-To: <0000013c4a8363ed-ba83975a-7b62-4a9e-981b-8b44d8030431-000000@email.amazonses.com> References: <1358446258.23211.32.camel@gandalf.local.home> <1358447864.23211.34.camel@gandalf.local.home> <0000013c4a69a2cf-1a19a6f6-e6a3-4f06-99a4-10fdd4b9aca2-000000@email.amazonses.com> <1358458996.23211.46.camel@gandalf.local.home> <0000013c4a8363ed-ba83975a-7b62-4a9e-981b-8b44d8030431-000000@email.amazonses.com> Content-Type: text/plain; charset="ISO-8859-15" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: LKML , linux-mm , Andrew Morton , Pekka Enberg , Matt Mackall , Thomas Gleixner , RT , Clark Williams , John Kacur , "Luis Claudio R. Goncalves" On Thu, 2013-01-17 at 21:56 +0000, Christoph Lameter wrote: > on Thu, 17 Jan 2013, Christoph Lameter wrote: > > > Ditto which leaves us with: > > > > Index: linux/mm/slub.c > > =================================================================== > > --- linux.orig/mm/slub.c 2013-01-17 15:49:57.417491975 -0600 > > +++ linux/mm/slub.c 2013-01-17 15:50:49.010287150 -0600 > > @@ -1993,8 +1993,9 @@ static inline void flush_slab(struct kme > > deactivate_slab(s, c->page, c->freelist); > > > > c->tid = next_tid(c->tid); > > - c->page = NULL; > > c->freelist = NULL; > > + barrier(); > > + c->page = NULL; > > } > > But the larger question is why is flush_slab() called with interrupts > enabled? > > RT? Could be, there's a few tweaks made in -rt. I'll put in a WARN_ON_ONCE() if flush_slab() is called with interrupts enabled just to see where it happens. -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org