From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx205.postini.com [74.125.245.205]) by kanga.kvack.org (Postfix) with SMTP id 9F0116B0006 for ; Thu, 17 Jan 2013 17:07:28 -0500 (EST) Message-ID: <1358460446.23211.50.camel@gandalf.local.home> Subject: Re: [RFC][PATCH] slub: Check for page NULL before doing the node_match check From: Steven Rostedt Date: Thu, 17 Jan 2013 17:07:26 -0500 In-Reply-To: <0000013c4a7e7fbf-c51fd42a-2455-4fec-bb37-915035956f05-000000@email.amazonses.com> References: <1358446258.23211.32.camel@gandalf.local.home> <1358447864.23211.34.camel@gandalf.local.home> <0000013c4a69a2cf-1a19a6f6-e6a3-4f06-99a4-10fdd4b9aca2-000000@email.amazonses.com> <1358458996.23211.46.camel@gandalf.local.home> <0000013c4a7e7fbf-c51fd42a-2455-4fec-bb37-915035956f05-000000@email.amazonses.com> Content-Type: text/plain; charset="ISO-8859-15" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: LKML , linux-mm , Andrew Morton , Pekka Enberg , Matt Mackall , Thomas Gleixner , RT , Clark Williams , John Kacur , "Luis Claudio R. Goncalves" On Thu, 2013-01-17 at 21:51 +0000, Christoph Lameter wrote: > Ditto which leaves us with: Except... > > Index: linux/mm/slub.c > =================================================================== > --- linux.orig/mm/slub.c 2013-01-17 15:49:57.417491975 -0600 > +++ linux/mm/slub.c 2013-01-17 15:50:49.010287150 -0600 > @@ -1993,8 +1993,9 @@ static inline void flush_slab(struct kme > deactivate_slab(s, c->page, c->freelist); > > c->tid = next_tid(c->tid); > - c->page = NULL; > c->freelist = NULL; + /* + * Preemption may be enabled here, and if the task is preempted + * other tasks require that freelist is NULL if page is NULL. + */ > + barrier(); > + c->page = NULL; > } > > /* -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org