From: kamezawa.hiroyu@jp.fujitsu.com
To: Hugh Dickins <hugh@veritas.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mel@csn.ul.ie>, Shi Weihua <shiwh@cn.fujitsu.com>,
akpm@linux-foundation.org, balbir@linux.vnet.ibm.com,
xemul@openvz.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: Re: [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-aligned zone initilaization.
Date: Mon, 21 Apr 2008 22:02:24 +0900 (JST) [thread overview]
Message-ID: <13567392.1208782944657.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0804211250000.16476@blonde.site>
thank you for review.
>> + z = page_zone(page);
>
>Does this have to be recalculated for every page? The function name
>"memmap_init_zone" suggests it could be done just once (but I'm on
>unfamiliar territory here, ignore any nonsense from me).
>
you're right. I will consider this again.
>> - if ((pfn & (pageblock_nr_pages-1)))
>> + if ((z->zone_start_pfn < pfn)
>
>Shouldn't that be <= ?
>
yes.
>> + && (pfn < z->zone_start_pfn + z->spanned_pages)
>> + && !(pfn & (pageblock_nr_pages-1)))
>
>Ah, that line (with the ! in) makes more sense than what was there
>before; but that's an unrelated (minor) bugfix which you ought to
>mention separately in the change comment.
>
Ah, ok. I'll rewrite and post again. thank you.
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-04-21 13:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48080706.50305@cn.fujitsu.com>
[not found] ` <48080930.5090905@cn.fujitsu.com>
2008-04-18 2:46 ` [PATCH] memcgroup: check and initialize page->cgroup in memmap_init_zone Shi Weihua
2008-04-18 3:04 ` KAMEZAWA Hiroyuki
2008-04-18 3:14 ` Shi Weihua
2008-04-18 3:14 ` Andrew Morton
2008-04-18 3:32 ` KAMEZAWA Hiroyuki
2008-04-18 5:09 ` KAMEZAWA Hiroyuki
2008-04-18 5:43 ` Shi Weihua
2008-04-18 5:57 ` KAMEZAWA Hiroyuki
2008-04-18 6:47 ` KAMEZAWA Hiroyuki
2008-04-18 3:37 ` Balbir Singh
2008-04-18 3:49 ` Shi Weihua
2008-04-18 12:12 ` [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-aligned zone initilaization KAMEZAWA Hiroyuki
2008-04-18 16:15 ` Mel Gorman
2008-04-18 17:41 ` Dave Hansen
2008-04-18 17:25 ` kamezawa.hiroyu
2008-04-21 2:20 ` KAMEZAWA Hiroyuki
2008-04-21 10:12 ` Mel Gorman
2008-04-21 10:29 ` KAMEZAWA Hiroyuki
2008-04-21 11:56 ` Hugh Dickins
2008-04-22 1:40 ` [BUGFIX][PATCH] Fix usemap initialization v2 KAMEZAWA Hiroyuki
2008-04-22 10:12 ` Hugh Dickins
2008-04-23 1:45 ` KAMEZAWA Hiroyuki
2008-04-23 2:17 ` Shi Weihua
2008-04-23 4:46 ` [BUGFIX][PATCH] Fix usemap initialization v3 KAMEZAWA Hiroyuki
2008-04-23 6:19 ` Shi Weihua
2008-04-23 8:04 ` KAMEZAWA Hiroyuki
2008-04-23 12:46 ` Mel Gorman
2008-04-27 19:18 ` Andrew Morton
2008-04-27 19:30 ` Balbir Singh
2008-04-27 22:50 ` Hugh Dickins
2008-04-28 0:39 ` KAMEZAWA Hiroyuki
2008-04-21 13:02 ` kamezawa.hiroyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13567392.1208782944657.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=shiwh@cn.fujitsu.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox