From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1A9C2D0CD for ; Mon, 19 May 2025 11:53:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 250C26B00A8; Mon, 19 May 2025 07:53:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D9CF6B00B1; Mon, 19 May 2025 07:53:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F227E6B00CD; Mon, 19 May 2025 07:53:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE3D06B00A8 for ; Mon, 19 May 2025 07:53:49 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 665C11A01C3 for ; Mon, 19 May 2025 11:53:51 +0000 (UTC) X-FDA: 83459498262.08.C547E9C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 39AC618000C for ; Mon, 19 May 2025 11:53:49 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jlo3zky+; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747655629; a=rsa-sha256; cv=none; b=Z2JGzXz8/IH3SrNrTr9lep73e1zq59551yRBzCirp1QjTJyB05RgC8alit8OHm/OqkWPpg ZNRd0AYmTjNkvIxenOgr9lLIoQPtymP/z2aGsSMvG8c90ZTeklvaHCutiO6uSBG9jazOxb Gzsqr1sFJVIlZTBQAJ4wdM2YC8Tw09s= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jlo3zky+; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747655629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GPR3VXLvHXW7ydech2OrYgRwl+zj+Xb2j8cG0tq4eIk=; b=sSIwy8iydkZCpk03oEYfAG6gj9r3YNTrF5QJXlmqvPg8A8oRTCs33ymGfMoDIbMnDaeoLt d7BnP3zYUt2WQlfix7tnAINM3/YsbZOTQH/WyUrxSAmFj35Wi7aRhjNEo/V83usCZDGc3H QvEGkGvRS1rQIHw4Q2xoi+4UUIiwLFM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747655628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GPR3VXLvHXW7ydech2OrYgRwl+zj+Xb2j8cG0tq4eIk=; b=Jlo3zky+HAdiB993L8N0ikAmV0KjPC5DKghoFIXeI/5mofQ4WHAbomAsJOx9XA6LR1jZVu wPPeg48BN1x3mWzKJRZdrdDipy8aSkXw7KD8DW1nzjyu5YQBbJKmIu2iyteMKe7SOct5iF 4CJbQV0uI/IckEhTy/qiRJlpiZ0Jz5E= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-wSjvJmGzPAyIPuRwIC2fxA-1; Mon, 19 May 2025 07:53:47 -0400 X-MC-Unique: wSjvJmGzPAyIPuRwIC2fxA-1 X-Mimecast-MFC-AGG-ID: wSjvJmGzPAyIPuRwIC2fxA_1747655626 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cfda30a3cso22832275e9.3 for ; Mon, 19 May 2025 04:53:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747655626; x=1748260426; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GPR3VXLvHXW7ydech2OrYgRwl+zj+Xb2j8cG0tq4eIk=; b=ehQQyIrJyLRLWy6xtJWrA3gFC3aJK7L/yn62/7AlHKfkrej6HznF593SlUdIkbpp6Q G9jjPwyEh3UQ92HIrh1w0px6HudJ/obyTwVa4LGqT1BWbKfXiOnJNfCAb5uMCKeq3DWE nGQmA6UwuLNReL5P6lEnxG1uNv3o5BSIWOcT2UCBmtjnSHV5Dc+QyEg0k1MUrdxj2py5 dpNEgplAmGgUV6/mlUHItzd4L3MRR1T4GmzUwTNTYaBfw9y6ABaBGt73GAPTxLywyZWg OrCtFI0X0K5X7RmKausYeOt/vkHRfW4+fGpU9fwOvuirxZc4UCZ+/IW/kwck3qNPkcl0 IRSg== X-Forwarded-Encrypted: i=1; AJvYcCVXdRKWdNF60weuOo7+tkWbY48t6KDAC+6dxYOp2z3H0RYegPXwJCDmlP5sDLbO+FsjIoRi7f7+yg==@kvack.org X-Gm-Message-State: AOJu0YwS4BuozyqmiZveW8wJ35KSKEdBks1DvwOGftOTOryIZR6WENAb rb7j54NC0jLKF/gdPnriEgLfxCQqqDSw5FT7nqLRlj4+Mq2PBMxEG82PWJXg3uvKCZjcbpQOQ9W L7+oQK17vlIOvvN50Q0fAprPVGrRHMfLD7w1cupWtMAtI3+BOMlwz X-Gm-Gg: ASbGnctHXcf/ICB1zwhIycTQqyztf7J9qh9+cVgi6EsqwwyrIJd6OjZUIMTy0s/bjGM UoxA9Y29OIshZo1dMJjVraUKfOSmS7coDEIvLnnPrQUGhObZ9PMJ665EQWCAZ5qvviVRu4ipE6O KKmjglVXVJ1HEi5a3WK5ZnXFUi+SZ/YHu8gNRhGCdKEb+9G71L4wDELnUOahR4fkw0coDkFAhy7 50u3KApm/SlEJTFsW9ZkejprprsRGLdmaXy19xz+sRIKeg7z/czMxgrEcxh4kPU1if5akdjimKs n2Q/A2beXIHLqaP8Wj7KyHKakMKqSpQagf1uTUkfNxXt+jkdGjKe7HxFJ2oeNL818gJXeOdCG55 3cHId23VYq5/vn4X6RD8ghFxzTwMIEgsht73X8RY= X-Received: by 2002:a5d:5885:0:b0:3a3:71c2:f74b with SMTP id ffacd0b85a97d-3a371c2f942mr2035385f8f.31.1747655625966; Mon, 19 May 2025 04:53:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFeikYDBgPelSMoJHVDougEefZ8K1XTFemF16mNYYeA/UWZsVraadRQAlJr/ByjfGMl+SaWcg== X-Received: by 2002:a5d:5885:0:b0:3a3:71c2:f74b with SMTP id ffacd0b85a97d-3a371c2f942mr2035361f8f.31.1747655625595; Mon, 19 May 2025 04:53:45 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f39e84d3sm217395445e9.32.2025.05.19.04.53.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 04:53:45 -0700 (PDT) Message-ID: <135556a3-9b72-4ec0-acc3-21ee0d15ebe3@redhat.com> Date: Mon, 19 May 2025 13:53:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] mm: ksm: prevent KSM from entirely breaking VMA merging To: Lorenzo Stoakes , Andrew Morton Cc: Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 25Z7YXITFtJWAOQwtVJQWECiSfK_F5FRL5xFrQIx2OM_1747655626 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 39AC618000C X-Stat-Signature: jikz8xrbhwane338qtp8kwhqqztp71f7 X-HE-Tag: 1747655629-709540 X-HE-Meta: U2FsdGVkX1+T7Nq4q8V3vsT/GCJNifzpOrg2pd2cjhrM8bcEvi6UW2DKDRCDP4IWsmykUsjSv/Awxm8yr44pU+QqyaLu2Swagv59d6Olk7obmP6Z/dct548CO2n3zRQUs7t4PtF7z5h6flhyw4ycgcR1JeDGfbHLgCGzsSI/ySuUMkFidC1DUqbkrUGOhMl4d/qJnKd8B6hUFinQAziWnoaa0Jcs6M6tUapRFS47OxQAUl4FsURmDLC3Es+KFkBpVjX396VBy/dH48C2PlXiyV+bbDIcqrXtKoBbQsLr271RLgAHvfCQjOxOnH+CqttKlAZlpWqe+4NYUHtxKnlneJI1FhjKy/omu0/Q8JpK8gvCf14tzxjAhqtRqhDV2gh6YvE63TfgzMxfuw7oO3izCdklIvAnn+YTDUBN0LrmFZghY2N8SFQCs+zRSd2v1x4S+42+Pg5Qi4spnEBblZoGGyi3pXNo7OemHPxAGM4SO16oBKJOzPC8tAORcb1/JlVlAKcHTBPai3hxUraQG3f7XuSFSuC6Q6wg5NIRa/7q/b7881BpJsrEzuKtgdW7j6U/t5SC/rb8w9AfPyjnZIXkYQVoBril0pNKwZu2E5A9gYfIAsCmeT/ACbi93Nu6sSsosW8iI7qpsrjE4sB1K7jjhpxmCqogQHyo74jgbQ8u21Dbim5UxzWcVxd+Yu5fclwmkjFjeYZrwFQ6Af0byA6tAOLd2/QiX1JCRrDuTB68OcnLtJu5aBd4VMXsH40buS9gC6jFVOUO+LqE/NfXZ67faxXgzVvdG5gCcH+CTckx9dV+Fuukm3/7FXuRMOvpEozzfp78iIVKW907+K3XIp5QI2XDM5nLnm9mj0pvoCoWi0Yw6+Sx7cyvdbnThzQ3LSbYXisZwSRsn6H45hPhqAj5sFgCC7KAfgL8rRxrat2LHMIkhHKk89+wxgsn4Qppvu675+fMssMiFS8pWutbxUN xzz38J9/ g5aim1iwa8fbjcIQYRB6NcXEeg8T6/NGH6e3Pl/LdkBRkOvGCePeOIKYzAwlegRV2gkbOX7I/m8LsJB4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.05.25 10:51, Lorenzo Stoakes wrote: > When KSM-by-default is established using prctl(PR_SET_MEMORY_MERGE), this > defaults all newly mapped VMAs to having VM_MERGEABLE set, and thus makes > them available to KSM for samepage merging. It also sets VM_MERGEABLE in > all existing VMAs. > > However this causes an issue upon mapping of new VMAs - the initial flags > will never have VM_MERGEABLE set when attempting a merge with adjacent VMAs > (this is set later in the mmap() logic), and adjacent VMAs will ALWAYS have > VM_MERGEABLE set. Just to clarify, you mean that VM_MERGEABLE is set later, during __mmap_new_vma()->ksm_add_vma()->__ksm_add_vma(), and we are already past vma_merge_new_range(), correct? -- Cheers, David / dhildenb