From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Tony Luck <tony.luck@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Jiang Liu <jiang.liu@huawei.com>, Borislav Petkov <bp@alien8.de>,
Simon Jeons <simon.jeons@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: clean up soft_offline_page()
Date: Fri, 14 Dec 2012 10:37:36 -0500 [thread overview]
Message-ID: <1355499456-3311-1-git-send-email-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <50CA97D0.4020401@huawei.com>
Hi Xishi,
On Fri, Dec 14, 2012 at 11:06:56AM +0800, Xishi Qiu wrote:
> On 2012/12/14 7:01, Naoya Horiguchi wrote:
...
> > + ret = get_any_page(page, pfn, flags);
> > + if (ret < 0)
> > + return ret;
> > + if (ret) { /* for in-use pages */
> > + if (PageHuge(page))
> > + soft_offline_huge_page(page, flags);
>
> ret = soft_offline_huge_page(page, flags);
>
> > + else
> > + __soft_offline_page(page, flags);
>
> ret = __soft_offline_page(page, flags); right?
Ah, you're right, Thanks!
Naoya
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-12-14 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 23:01 Naoya Horiguchi
2012-12-14 3:06 ` Xishi Qiu
2012-12-14 15:37 ` Naoya Horiguchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355499456-3311-1-git-send-email-n-horiguchi@ah.jp.nec.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=fengguang.wu@intel.com \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=qiuxishi@huawei.com \
--cc=simon.jeons@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox