From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087CBC432C3 for ; Wed, 27 Nov 2019 22:55:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 976C8206E0 for ; Wed, 27 Nov 2019 22:55:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a3Vszlb7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 976C8206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB93B6B04EF; Wed, 27 Nov 2019 17:55:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6A1B6B04F0; Wed, 27 Nov 2019 17:55:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D59DF6B04F1; Wed, 27 Nov 2019 17:55:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id BE7A36B04EF for ; Wed, 27 Nov 2019 17:55:48 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 65B99440B for ; Wed, 27 Nov 2019 22:55:48 +0000 (UTC) X-FDA: 76203566376.30.star24_32a24916b513c X-HE-Tag: star24_32a24916b513c X-Filterd-Recvd-Size: 4883 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Nov 2019 22:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574895347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OkZZSn7UB7yAAoECEs1czq8fk4r+Na8nNcmoXP+YNQc=; b=a3Vszlb7rpzb68CMYBZNnya3oDwZoRmgnhQ1pv0w80N3ActYdZVFoqJ2C0YZd2mL0SjNOA y0mdODjho+YgUdUHKjHpn5l4PUsYXZQItopNEk4BqKpCsOYcUr61h7yA12RFWHlWHdERX7 PoIOm7r9NdJl5wg7VeTgM3Vwjuia2rI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-mJ9MNIBwN0-nEKUYodTwiA-1; Wed, 27 Nov 2019 17:55:45 -0500 Received: by mail-wm1-f71.google.com with SMTP id p2so770981wma.3 for ; Wed, 27 Nov 2019 14:55:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=ypXWC1p1rh6B0sqBKSPovHb8hFFh42IyChXftJmwFwA=; b=sliPD7KzB0R80CKAOZhkZDoTe5/bXAj3+6Djon71FIwl2kNn21TSkIApsAWTK76Np0 RPT4zRu+rbuzP327Qwsy+1nFFiyu0t63jut+aSHF5TRaqkyR9n+vXjguqgefXDXW/ts0 MRJ7TgiycpjF4e/T+0bfDiDj2mozwmGfKsGqWgq0RQ6jYNurtDZJ4GH0pGXmw3/wNicl QMOFtSJ9j21MUwzYsKGnMBeMEbnWsUF/9cLn72MpwYKFJUl+TyBi0YQKZJv3YP6Kw3Ce ITQsBjDg5XmTpBoBVpsY8s7iH5FCffdTL2nACxhWnEiYS0GdsSQyQ8sNCGKfQCZm8IV4 CAOg== X-Gm-Message-State: APjAAAWFxlMVL0a+x2m5MdhFicOgZScL2aZ5SGPUgJvsWpa21EsYzwm3 1BKhlX0td3mUqOnNkk9tYZK1JzsP7k4qyDEonrIMEckrLIqTtqWehF2A91Jce35LEqkQYpPufIz AxemqXAsXFd8= X-Received: by 2002:a7b:c844:: with SMTP id c4mr6439432wml.1.1574895344456; Wed, 27 Nov 2019 14:55:44 -0800 (PST) X-Google-Smtp-Source: APXvYqyIAv+FB8FoOGt06XxttDaljWDfDs6v8v8eSAU83EObkoTkmGHfwfYyoH4gt9sI1Da63D1u4w== X-Received: by 2002:a7b:c844:: with SMTP id c4mr6439414wml.1.1574895344253; Wed, 27 Nov 2019 14:55:44 -0800 (PST) Received: from ?IPv6:2a01:598:b889:7f36:a401:5177:c4ae:d2ba? ([2a01:598:b889:7f36:a401:5177:c4ae:d2ba]) by smtp.gmail.com with ESMTPSA id g11sm8525862wmh.27.2019.11.27.14.55.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 14:55:43 -0800 (PST) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2] drivers/base/node.c: Simplify unregister_memory_block_under_nodes() Date: Wed, 27 Nov 2019 23:55:42 +0100 Message-Id: <13549413-C422-4661-9E7E-4DBC63B8997C@redhat.com> References: <20191127141532.525708b65a96fd614595bae8@linux-foundation.org> Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Stephen Rothwell , Pavel Tatashin , Michal Hocko , Oscar Salvador , Chris von Recklinghausen In-Reply-To: <20191127141532.525708b65a96fd614595bae8@linux-foundation.org> To: Andrew Morton X-Mailer: iPhone Mail (17A878) X-MC-Unique: mJ9MNIBwN0-nEKUYodTwiA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 27.11.2019 um 23:15 schrieb Andrew Morton : >=20 > =EF=BB=BFOn Wed, 27 Nov 2019 17:53:12 +0100 David Hildenbrand wrote: >=20 >> Just a note that this was actually also a bugfix as noted by Chris. >>=20 >> If the memory we are removing was never onlined, >> get_nid_for_pfn()->pfn_to_nid() will return garbage. Removing will >> succeed but links will remain in place. >>=20 >> Can be triggered by >>=20 >> 1. hotplugging a DIMM to node 1 >> 2. not onlining the memory blocks >> 3. unplugging it >> 4. re-plugging it to node 1 >>=20 >> We will trigger the BUG_ON(ret) in add_memory_resource(), because >> link_mem_sections() will return with -EEXIST. >=20 > Oh. In that case case we please redo the patch as a bugfix?=20 > Appropriate title and changelog? And perhaps the bugfix can be split > from the cleanup, to make the former more backportable? This is already upstream (d84f2f5a7552 ),so I=E2=80=98m afraid we can=E2=80= =98t do anything about it. (When your cleanups turn into bugfixes ...). I can still try to send stable patches, though ...