From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 5D33D6B006A for ; Mon, 20 Jul 2009 08:46:05 -0400 (EDT) From: David Howells In-Reply-To: <20090715074952.A36C7DDDB2@ozlabs.org> References: <20090715074952.A36C7DDDB2@ozlabs.org> Subject: Re: [RFC/PATCH] mm: Pass virtual address to [__]p{te,ud,md}_free_tlb() Date: Mon, 20 Jul 2009 13:46:03 +0100 Message-ID: <13548.1248093963@redhat.com> Sender: owner-linux-mm@kvack.org To: Benjamin Herrenschmidt Cc: dhowells@redhat.com, Linux Memory Management , Linux-Arch , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Hugh Dickins , Nick Piggin List-ID: Benjamin Herrenschmidt wrote: > Upcoming paches to support the new 64-bit "BookE" powerpc architecture > will need to have the virtual address corresponding to PTE page when > freeing it, due to the way the HW table walker works. > > Basically, the TLB can be loaded with "large" pages that cover the whole > virtual space (well, sort-of, half of it actually) represented by a PTE > page, and which contain an "indirect" bit indicating that this TLB entry > RPN points to an array of PTEs from which the TLB can then create direct > entries. Thus, in order to invalidate those when PTE pages are deleted, > we need the virtual address to pass to tlbilx or tlbivax instructions. > > The old trick of sticking it somewhere in the PTE page struct page sucks > too much, the address is almost readily available in all call sites and > almost everybody implemets these as macros, so we may as well add the > argument everywhere. I added it to the pmd and pud variants for consistency. > > Signed-off-by: Benjamin Herrenschmidt Acked-by: David Howells [MN10300 & FRV] -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org