From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
George Spelvin <linux@horizon.com>,
Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>,
Tomas Racek <tracek@redhat.com>, Jan Kara <jack@suse.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Josh Boyer <jwboyer@gmail.com>,
Valdis.Kletnieks@vt.edu, Jiri Slaby <jslaby@suse.cz>,
Thorsten Leemhuis <fedora@leemhuis.info>,
Zdenek Kabelac <zkabelac@redhat.com>,
Bruno Wolff III <bruno@wolff.to>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: kswapd craziness in 3.7
Date: Tue, 27 Nov 2012 15:48:34 -0500 [thread overview]
Message-ID: <1354049315-12874-1-git-send-email-hannes@cmpxchg.org> (raw)
Hi everyone,
I hope I included everybody that participated in the various threads
on kswapd getting stuck / exhibiting high CPU usage. We were looking
at at least three root causes as far as I can see, so it's not really
clear who observed which problem. Please correct me if the
reported-by, tested-by, bisected-by tags are incomplete.
One problem was, as it seems, overly aggressive reclaim due to scaling
up reclaim goals based on compaction failures. This one was reverted
in 9671009 mm: revert "mm: vmscan: scale number of pages reclaimed by
reclaim/compaction based on failures".
Another one was an accounting problem where a freed higher order page
was underreported, and so kswapd had trouble restoring watermarks.
This one was fixed in ef6c5be fix incorrect NR_FREE_PAGES accounting
(appears like memory leak).
The third one is a problem with small zones, like the DMA zone, where
the high watermark is lower than the low watermark plus compaction gap
(2 * allocation size). The zonelist reclaim in kswapd would do
nothing because all high watermarks are met, but the compaction logic
would find its own requirements unmet and loop over the zones again.
Indefinitely, until some third party would free enough memory to help
meet the higher compaction watermark. The problematic code has been
there since the 3.4 merge window for non-THP higher order allocations
but has been more prominent since the 3.7 merge window, where kswapd
is also woken up for the much more common THP allocations.
The following patch should fix the third issue by making both reclaim
and compaction code in kswapd use the same predicate to determine
whether a zone is balanced or not.
Hopefully, the sum of all three fixes should tame kswapd enough for
3.7.
Johannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2012-11-27 20:49 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 20:48 Johannes Weiner [this message]
2012-11-27 20:48 ` [patch] mm: vmscan: fix kswapd endless loop on higher order allocation Johannes Weiner
2012-11-27 20:58 ` kswapd craziness in 3.7 Linus Torvalds
2012-11-27 21:16 ` Rik van Riel
2012-11-27 21:49 ` Johannes Weiner
2012-11-27 22:02 ` Rik van Riel
2012-11-27 22:26 ` Johannes Weiner
2012-11-27 23:19 ` Linus Torvalds
2012-11-28 10:13 ` Mel Gorman
2012-11-28 10:51 ` Thorsten Leemhuis
2012-11-28 16:42 ` Mel Gorman
2012-11-28 22:52 ` Andrew Morton
2012-11-28 23:54 ` Mel Gorman
2012-11-29 0:14 ` Andrew Morton
2012-11-29 15:30 ` Thorsten Leemhuis
2012-11-29 17:05 ` Johannes Weiner
2012-11-30 12:39 ` Thorsten Leemhuis
2012-12-01 0:45 ` Johannes Weiner
2012-12-03 8:30 ` Thorsten Leemhuis
2012-12-03 13:08 ` Fedora repo (was: Re: kswapd craziness in 3.7) Borislav Petkov
2012-12-03 19:42 ` kswapd craziness in 3.7 Johannes Weiner
2012-12-04 21:42 ` Johannes Weiner
2012-12-05 3:01 ` Bruno Wolff III
2012-12-06 17:37 ` Bruno Wolff III
2012-12-06 19:31 ` Linus Torvalds
2012-12-06 19:43 ` Rik van Riel
2012-12-06 20:23 ` Johannes Weiner
2012-12-06 20:32 ` Rik van Riel
2012-12-08 12:06 ` Zlatko Calusic
2012-12-08 21:22 ` Zlatko Calusic
2012-12-09 1:01 ` Linus Torvalds
2012-12-09 21:59 ` Zdenek Kabelac
2012-12-10 11:03 ` Mel Gorman
2012-12-10 16:39 ` Johannes Weiner
2012-12-10 18:01 ` Mel Gorman
2012-12-10 18:33 ` Zlatko Calusic
2012-12-10 19:13 ` Linus Torvalds
2012-12-10 20:35 ` Zlatko Calusic
2012-12-10 21:28 ` Linus Torvalds
2012-12-10 21:42 ` Borislav Petkov
2012-12-10 21:47 ` Linus Torvalds
2012-12-10 21:54 ` Borislav Petkov
2012-12-10 22:15 ` Zlatko Calusic
2012-12-10 23:27 ` Hugh Dickins
2012-12-11 0:19 ` Zlatko Calusic
2012-12-11 21:56 ` Zlatko Calusic
2012-12-19 22:24 ` Zlatko Calusic
2012-12-10 18:29 ` Zlatko Calusic
2012-12-06 8:09 ` Thorsten Leemhuis
2012-11-27 21:29 ` Johannes Weiner
2012-11-28 13:35 ` Zdenek Kabelac
2012-11-28 14:04 ` Jiri Slaby
2012-11-28 9:45 ` Mel Gorman
2012-12-03 15:23 ` Zdenek Kabelac
2012-12-03 19:18 ` Johannes Weiner
2012-12-04 9:05 ` Zdenek Kabelac
2012-12-04 9:15 ` Jiri Slaby
2012-12-04 16:11 ` Johannes Weiner
2012-12-04 16:22 ` Jiri Slaby
2012-12-04 19:50 ` Johannes Weiner
2012-12-08 10:35 ` Jiri Slaby
2012-12-04 16:15 ` Johannes Weiner
2012-12-06 13:51 ` Zdenek Kabelac
2012-12-03 13:14 ` Jiri Slaby
2012-12-04 8:55 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354049315-12874-1-git-send-email-hannes@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=bruno@wolff.to \
--cc=dave@linux.vnet.ibm.com \
--cc=fedora@leemhuis.info \
--cc=jack@suse.cz \
--cc=johannes.hirte@fem.tu-ilmenau.de \
--cc=jslaby@suse.cz \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@horizon.com \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=tracek@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox