From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx102.postini.com [74.125.245.102]) by kanga.kvack.org (Postfix) with SMTP id 0F4876B0078 for ; Mon, 19 Nov 2012 16:27:37 -0500 (EST) Message-ID: <1353359959.10939.84.camel@misato.fc.hp.com> Subject: Re: [ACPIHP PATCH part1 0/4] introduce a framework for ACPI based system device hotplug From: Toshi Kani Date: Mon, 19 Nov 2012 14:19:19 -0700 In-Reply-To: <50AA63CE.9080700@gmail.com> References: <1351958865-24394-1-git-send-email-jiang.liu@huawei.com> <6684049.OOiNLWpfRL@vostro.rjw.lan> <50AA63CE.9080700@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu Cc: "Rafael J. Wysocki" , Yinghai Lu , Tony Luck , Yasuaki Ishimatsu , Wen Congyang , Tang Chen , Taku Izumi , Bjorn Helgaas , Jiang Liu , Kenji Kaneshige , Huang Ying , Bob Moore , Len Brown , "Srivatsa S . Bhat" , Yijing Wang , Hanjun Guo , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, "Wang, Frank" > But for the ACPI part for CPU and memory hotplug enhancements recently posted to > the community, I think they are different solutions with the new framework. I feel > they are lightweight enhancements to existing code with some limitations, but the > new framework is a heavyweight solution with full functionalities and improved > usability. So we may need discussions about the different solutions here:) Hi Gerry, Thanks for working on the framework enhancement. I am still new to Linux (and learning :), but have extensive background in hot-plug features on other OS for CPU, Memory, Node, RP and PCI hot-plug support. So, I basically agree with you that we do need framework enhancement. However, I think we need phased approach here. First, we need to make CPU and Memory hot-plug work under the current framework. Once we settle on the basic features, we can then make framework enhancements without breaking the features. For CPU hotplug, I also intentionally minimized the code changes so that the changes could be back-ported to older kernels being used by distributions. I will send you more comments after I reviewed your patches (which may take some time :). Thanks, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org