From: Glauber Costa <glommer@parallels.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
kamezawa.hiroyu@jp.fujitsu.com, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Glauber Costa <glommer@parallels.com>
Subject: [PATCH 1/7] memcg: simplify ida initialization
Date: Thu, 15 Nov 2012 06:54:47 +0400 [thread overview]
Message-ID: <1352948093-2315-2-git-send-email-glommer@parallels.com> (raw)
In-Reply-To: <1352948093-2315-1-git-send-email-glommer@parallels.com>
As suggested by akpm, change the manual initialization of our kmem
index to DEFINE_IDA()
Signed-off-by: Glauber Costa <glommer@parallels.com>
CC: Michal Hocko <mhocko@suse.cz>
CC: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: Andrew Morton <akpm@linux-foundation.org>
---
mm/memcontrol.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 6136fec..c0c6adf 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -569,7 +569,7 @@ static void disarm_sock_keys(struct mem_cgroup *memcg)
* memcg_limited_groups_array_size. It will double each time we have to
* increase it.
*/
-static struct ida kmem_limited_groups;
+static DEFINE_IDA(kmem_limited_groups);
int memcg_limited_groups_array_size;
/*
@@ -5686,9 +5686,6 @@ static int memcg_init_kmem(struct mem_cgroup *memcg, struct cgroup_subsys *ss)
if (ret)
return ret;
- if (mem_cgroup_is_root(memcg))
- ida_init(&kmem_limited_groups);
-
return mem_cgroup_sockets_init(memcg, ss);
};
--
1.7.11.7
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-14 18:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 2:54 [PATCH 0/7] fixups for kmemcg Glauber Costa
2012-11-15 0:47 ` David Rientjes
2012-11-15 2:54 ` Glauber Costa [this message]
2012-11-15 2:54 ` [PATCH 2/7] move include of workqueue.h to top of slab.h file Glauber Costa
2012-11-15 9:30 ` Kamezawa Hiroyuki
2012-11-15 2:54 ` [PATCH 3/7] memcg: remove test for current->mm in memcg_stop/resume_kmem_account Glauber Costa
2012-11-15 9:28 ` Kamezawa Hiroyuki
2012-11-15 2:54 ` [PATCH 4/7] memcg: replace __always_inline with plain inline Glauber Costa
2012-11-15 9:29 ` Kamezawa Hiroyuki
2012-11-15 2:54 ` [PATCH 5/7] memcg: get rid of once-per-second cache shrinking for dead memcgs Glauber Costa
2012-11-15 9:41 ` Kamezawa Hiroyuki
2012-11-15 13:47 ` Glauber Costa
2012-11-16 5:07 ` Kamezawa Hiroyuki
2012-11-16 7:11 ` Glauber Costa
2012-11-16 7:21 ` Kamezawa Hiroyuki
2012-11-16 14:55 ` Michal Hocko
2012-11-16 15:50 ` Glauber Costa
2012-11-15 2:54 ` [PATCH 6/7] memcg: add comments clarifying aspects of cache attribute propagation Glauber Costa
2012-11-15 2:54 ` [PATCH 7/7] slub: drop mutex before deleting sysfs entry Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352948093-2315-2-git-send-email-glommer@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox