From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jinjie Ruan <ruanjinjie@huawei.com>,
dennis@kernel.org, tj@kernel.org, cl@linux.com,
mpe@ellerman.id.au, npiggin@gmail.com, naveen@kernel.org,
linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] powerpc: Fix a config comment typo in asm/percpu.h
Date: Tue, 6 Aug 2024 14:50:00 +0200 [thread overview]
Message-ID: <135289c2-78bc-4a14-ad43-6d45750af293@csgroup.eu> (raw)
In-Reply-To: <20240806112345.2387969-1-ruanjinjie@huawei.com>
Le 06/08/2024 à 13:23, Jinjie Ruan a écrit :
> [Vous ne recevez pas souvent de courriers de ruanjinjie@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> commit 0db880fc865f ("powerpc: Avoid nmi_enter/nmi_exit in real mode
> interrupt.") has a config comment typo, fix it.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> arch/powerpc/include/asm/percpu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/percpu.h b/arch/powerpc/include/asm/percpu.h
> index 634970ce13c6..c836b16ce30d 100644
> --- a/arch/powerpc/include/asm/percpu.h
> +++ b/arch/powerpc/include/asm/percpu.h
> @@ -23,7 +23,7 @@ DECLARE_STATIC_KEY_FALSE(__percpu_first_chunk_is_paged);
> (static_key_enabled(&__percpu_first_chunk_is_paged.key))
> #else
> #define percpu_first_chunk_is_paged false
> -#endif /* CONFIG_PPC64 && CONFIG_SMP */
> +#endif /* CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK && CONFIG_SMP */
The #if/#else/#endif section is small and doesn't nest additional
#ifdefs so the comment is useless and should be removed completely.
Christophe
next prev parent reply other threads:[~2024-08-06 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 11:23 Jinjie Ruan
2024-08-06 12:50 ` Christophe Leroy [this message]
2024-08-06 12:56 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=135289c2-78bc-4a14-ad43-6d45750af293@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox