From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Dave Chinner <david@fromorbit.com>,
Tony Luck <tony.luck@intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andi Kleen <andi.kleen@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
Akira Fujita <a-fujita@rs.jp.nec.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/3] ext4: introduce ext4_error_remove_page
Date: Mon, 29 Oct 2012 17:47:36 -0400 [thread overview]
Message-ID: <1351547256-837-1-git-send-email-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <m21ughksh3.fsf@firstfloor.org>
On Mon, Oct 29, 2012 at 12:07:04PM -0700, Andi Kleen wrote:
> Theodore Ts'o <tytso@mit.edu> writes:
...
> > Also, if you're going to keep this state in memory, what happens if
> > the inode gets pushed out of memory?
>
> You lose the error, just like you do today with any other IO error.
>
> We had a lot of discussions on this when the memory error handling
> was originally introduced, that was the conclusuion.
>
> I don't think a special panic knob for this makes sense either.
> We already have multiple panic knobs for memory errors, that
> can be used.
Yes. I understand that adding a new knob is not good.
So this patch uses the existing ext4 knob without adding new one.
Thanks,
Naoya
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-29 21:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 15:12 [PATCH 0/3] HWPOISON: improve error_remove_page() Naoya Horiguchi
2012-10-25 15:12 ` [PATCH 1/3] mm: print out information of file affected by memory error Naoya Horiguchi
2012-10-25 19:32 ` Jan Kara
2012-10-25 20:34 ` Naoya Horiguchi
2012-10-25 15:12 ` [PATCH 2/3] ext4: introduce ext4_error_remove_page Naoya Horiguchi
2012-10-25 19:39 ` Jan Kara
2012-10-26 6:12 ` Theodore Ts'o
2012-10-26 16:55 ` Luck, Tony
2012-10-26 18:46 ` Theodore Ts'o
2012-10-26 22:24 ` Luck, Tony
2012-10-27 22:16 ` Theodore Ts'o
2012-10-28 1:57 ` Naoya Horiguchi
2012-10-29 1:16 ` Dave Chinner
2012-10-29 2:40 ` Theodore Ts'o
2012-10-29 10:37 ` Andi Kleen
2012-10-29 11:05 ` Jun'ichi Nomura
2012-10-29 18:24 ` Theodore Ts'o
2012-10-29 18:55 ` Jan Kara
2012-10-29 19:07 ` Andi Kleen
2012-10-29 21:47 ` Naoya Horiguchi [this message]
2012-10-30 0:00 ` Jun'ichi Nomura
2012-10-29 18:11 ` Luck, Tony
2012-10-31 0:21 ` Dave Chinner
2012-10-26 18:50 ` Naoya Horiguchi
2012-10-25 15:12 ` [PATCH 3/3] ext3: introduce ext3_error_remove_page Naoya Horiguchi
2012-10-25 19:45 ` Jan Kara
2012-10-25 20:35 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351547256-837-1-git-send-email-n-horiguchi@ah.jp.nec.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=a-fujita@rs.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=andi@firstfloor.org \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox