From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx139.postini.com [74.125.245.139]) by kanga.kvack.org (Postfix) with SMTP id D20576B0074 for ; Thu, 25 Oct 2012 16:35:08 -0400 (EDT) From: Naoya Horiguchi Subject: Re: [PATCH 3/3] ext3: introduce ext3_error_remove_page Date: Thu, 25 Oct 2012 16:35:02 -0400 Message-Id: <1351197302-14134-1-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <20121025194551.GE3262@quack.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Jan Kara Cc: Naoya Horiguchi , Andi Kleen , Tony Luck , Wu Fengguang , Andrew Morton , Jun'ichi Nomura , Akira Fujita , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org On Thu, Oct 25, 2012 at 09:45:51PM +0200, Jan Kara wrote: > On Thu 25-10-12 11:12:49, Naoya Horiguchi wrote: > > What I suggested in the previous patch for ext4 is ditto with ext3, > > so do the same thing for ext3. > > > > Signed-off-by: Naoya Horiguchi > > --- > > fs/ext3/inode.c | 33 ++++++++++++++++++++++++++++++--- > > 1 file changed, 30 insertions(+), 3 deletions(-) > > > > diff --git v3.7-rc2.orig/fs/ext3/inode.c v3.7-rc2/fs/ext3/inode.c > > index 7e87e37..7f708bf 100644 > > --- v3.7-rc2.orig/fs/ext3/inode.c > > +++ v3.7-rc2/fs/ext3/inode.c > > @@ -1967,6 +1967,33 @@ static int ext3_journalled_set_page_dirty(struct page *page) > > return __set_page_dirty_nobuffers(page); > > } > > > > +static int ext3_error_remove_page(struct address_space *mapping, > > + struct page *page) > > +{ > > + struct inode *inode = mapping->host; > > + struct buffer_head *bh, *head; > > + ext3_fsblk_t block = 0; > > + > > + if (!PageDirty(page) || !page_has_buffers(page)) > > + goto remove_page; > > + > > + /* Lost data. Handle as critical fs error. */ > > + bh = head = page_buffers(page); > > + do { > > + if (buffer_dirty(bh)) { > For ext3, you should check that buffer_mapped() is set because we can > have dirty and unmapped buffers. Otherwise the patch looks OK. OK, I'll add it. Thanks, Naoya -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org