From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84A5C433EF for ; Tue, 7 Jun 2022 07:37:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49F578D0002; Tue, 7 Jun 2022 03:37:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44F0D8D0001; Tue, 7 Jun 2022 03:37:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3165C8D0002; Tue, 7 Jun 2022 03:37:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 20A478D0001 for ; Tue, 7 Jun 2022 03:37:53 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F13711C5 for ; Tue, 7 Jun 2022 07:37:52 +0000 (UTC) X-FDA: 79550635584.27.BA25D3A Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf29.hostedemail.com (Postfix) with ESMTP id E12D1120026 for ; Tue, 7 Jun 2022 07:37:36 +0000 (UTC) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LHMbh3fGCz1KDRp; Tue, 7 Jun 2022 15:36:00 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 7 Jun 2022 15:37:22 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 7 Jun 2022 15:37:11 +0800 Message-ID: <134e7578-cfd5-2cc0-e878-5c403e9c21b0@huawei.com> Date: Tue, 7 Jun 2022 15:37:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 4/6] mm: ioremap: Add ioremap/iounmap_allowed() Content-Language: en-US To: Baoquan He CC: , , , , , , , , References: <20220606074815.139265-1-wangkefeng.wang@huawei.com> <20220606074815.139265-5-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Stat-Signature: upme6f571mxx15nxidsh4ze4ct73h4b1 X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E12D1120026 X-HE-Tag: 1654587456-396945 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/6 23:14, Baoquan He wrote: > On 06/06/22 at 03:48pm, Kefeng Wang wrote: >> Add special hook for architecture to verify addr, size or prot >> when ioremap() or iounmap(), which will make the generic ioremap >> more useful. >> >> ioremap_allowed() return an int, >> - NULL means continue to remap >> - error code means skip remap and return directly >> iounmap_allowed() return an int, >> - 0 means continue to vunmap >> - error code means skip vunmap and return directly > Aren't they bool type function and better return bool value? Ok, let's keep it simple, back to v1's version , use bool, if we want to extend them,  do it later. > >> Acked-by: Andrew Morton >> Signed-off-by: Kefeng Wang >> --- >> include/asm-generic/io.h | 25 +++++++++++++++++++++++++ >> mm/ioremap.c | 13 ++++++++++--- >> 2 files changed, 35 insertions(+), 3 deletions(-) >> >> diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h >> index e6ffa2519f08..9429387a3e65 100644 >> --- a/include/asm-generic/io.h >> +++ b/include/asm-generic/io.h >> @@ -964,6 +964,31 @@ static inline void iounmap(volatile void __iomem *addr) >> #elif defined(CONFIG_GENERIC_IOREMAP) >> #include >> >> +/* >> + * Arch code can implement the following two special hooks when using GENERIC_IOREMAP >> + * ioremap_allowed() return an int, >> + * - 0 means continue to remap >> + * - error code means skip remap and return directly >> + * iounmap_allowed() return an int, >> + * - 0 means continue to vunmap >> + * - error code means skip vunmap and return directly >> + */ >> +#ifndef ioremap_allowed >> +#define ioremap_allowed ioremap_allowed >> +static inline int ioremap_allowed(phys_addr_t phys_addr, size_t size, unsigned long prot) >> +{ >> + return 0; >> +} >> +#endif >> + >> +#ifndef iounmap_allowed >> +#define iounmap_allowed iounmap_allowed >> +static inline int iounmap_allowed(void __iomem *addr) >> +{ >> + return 0; >> +} >> +#endif >> + >> void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, unsigned long prot); >> void iounmap(volatile void __iomem *addr); >> >> diff --git a/mm/ioremap.c b/mm/ioremap.c >> index 7cb9996b0c12..196c93c0beb8 100644 >> --- a/mm/ioremap.c >> +++ b/mm/ioremap.c >> @@ -27,8 +27,10 @@ void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, unsigned long pro >> phys_addr -= offset; >> size = PAGE_ALIGN(size + offset); >> >> - area = get_vm_area_caller(size, VM_IOREMAP, >> - __builtin_return_address(0)); >> + if (ioremap_allowed(phys_addr, size, prot)) >> + return NULL; >> + >> + area = get_vm_area_caller(size, VM_IOREMAP, __builtin_return_address(0)); >> if (!area) >> return NULL; >> vaddr = (unsigned long)area->addr; >> @@ -45,6 +47,11 @@ EXPORT_SYMBOL(ioremap_prot); >> >> void iounmap(volatile void __iomem *addr) >> { >> - vunmap((void *)((unsigned long)addr & PAGE_MASK)); >> + void __iomem *vaddr = (void __iomem *)((unsigned long)addr & PAGE_MASK); >> + >> + if (iounmap_allowed(vaddr)) >> + return; >> + >> + vunmap((void __force *)vaddr); >> } >> EXPORT_SYMBOL(iounmap); >> -- >> 2.35.3 >> >> > .