From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D60E7C4167B for ; Thu, 9 Nov 2023 07:46:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38E5C8D00DF; Thu, 9 Nov 2023 02:46:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3169C8D0073; Thu, 9 Nov 2023 02:46:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DEA08D00DF; Thu, 9 Nov 2023 02:46:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0C0D48D0073 for ; Thu, 9 Nov 2023 02:46:40 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D9C30B6009 for ; Thu, 9 Nov 2023 07:46:39 +0000 (UTC) X-FDA: 81437633718.18.B19F6FD Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by imf12.hostedemail.com (Postfix) with ESMTP id 286C64000E for ; Thu, 9 Nov 2023 07:46:37 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IuO+lTMN; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.160.52 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699515998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l/+JlupkDMkqoU5uCh+PzR+ir4Ss/6wqjM2z/ZkKVT8=; b=3vqQbHmlUyjh/Ebv/bxjsaGzPHlFYw8kgc/JfMUAu635BSRoD2bin1l3IiFQMw0TExcaKG gBt8SD+M6MGIEVfJ3V6l940w+O5mAfMB0Vb2S92EfSxLVgrCjhRpPr8AgkchewsLhC0ZB3 TTGVXg9y668AwBCWnm/bU+7ytozOfuY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IuO+lTMN; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of hughd@google.com designates 209.85.160.52 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699515998; a=rsa-sha256; cv=none; b=V1rEaGkVroHMKg6QtyG4NnmwXd2y1an9dtNiK/JEQEhLWflmx6SllEK64bhB0+RyQXi6fS znJyPMUHpQlWmI+KgAH+yj82hkjuJM9Yo70gxWTfU14HQonZVsLm5+5xgBt8mmyUDHbyaz ux44T09oD9l+llC3zR7FmEsfqFifUo0= Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-1f060e059a3so335819fac.1 for ; Wed, 08 Nov 2023 23:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699515997; x=1700120797; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=l/+JlupkDMkqoU5uCh+PzR+ir4Ss/6wqjM2z/ZkKVT8=; b=IuO+lTMN3kCbebTrfg6odoa6DCFd64KNoioo9yvY3Wq+qgc5FGgrTLEahSKLC3D64C i7das/Qtz7N5kRKCHmLLBwRuGu6oGQ+E6SybXGSiTLB2N2C0kUtFK6diIA+GyBC5IANn vOR0U6+Ej0D4UQSp4zmeSBAb839FjxMpQGriFlFAU6EkhQ2YCeoZEuGyeDu+qIxM92lT VBAgZUELqZnjWgeM5lL/RqiaB2UheAPBDAZZ1xIpufUc11cqq8qBadUEgDql9K9adL3Y 7v1VtFXq5zGKTe9nnuTREIPY2WGAanmGQBzKn+K7jZ3A2DbDTRKn9dlPUik6eRZHKhNf MHEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699515997; x=1700120797; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l/+JlupkDMkqoU5uCh+PzR+ir4Ss/6wqjM2z/ZkKVT8=; b=nlzrbI1sfXYRk2eGBOrN23VPG2YsF/FslNS66C8In5WTlPSOwR4kC0VNrh25LIHMNe 0BKaPrG2rBFADbeg8X/eHyVFgilVlKVQu71KR1ybzHccDDwT3MV+f7OF17ZdL23Q1wu7 SbLNa8K4xPdaqOL7+lRIF8VB6MeJrKgOzOpsSHarg9Rc2kxy0T0rsuWji7fxx/zkREmi 04kUGwjP5N/99lkBBtIQWbU/5Ltx8KH/nir1KbCsprfwzIoLktfukA4QlhpAmOWbO2YV eFBDM3FpUnx2y8+88c9nCGhE5ks/kCIH+ERBNReVPl2WSAF4svXdd9M0UVAj9mZtqQSO 6Hbg== X-Gm-Message-State: AOJu0Yx/gKyWxsTGmcER8Kb5Yn184TlayV4YeoombSerbUB7p8FAoWzE 2rEgk+lc6TtzKUnj6vHa04MZZA== X-Google-Smtp-Source: AGHT+IFcvxX9FePStob/4xGAqXiLZnp72OF2HSNFxQO6szCfZH6z4KkXFDHNv0NB60K8V2ew2JbakA== X-Received: by 2002:a05:6870:11c4:b0:1ef:f14e:6f4c with SMTP id 4-20020a05687011c400b001eff14e6f4cmr4149504oav.2.1699515997237; Wed, 08 Nov 2023 23:46:37 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id g21-20020a056870a71500b001d6e9bb67d2sm629396oam.7.2023.11.08.23.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 23:46:36 -0800 (PST) Date: Wed, 8 Nov 2023 23:46:25 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Omkar Wagle cc: Matthew Wilcox , hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MM: shmem: Remove code sytle warnings In-Reply-To: <20231109062228.10227-1-ov.wagle@gmail.com> Message-ID: <134bb70e-db8a-0892-0a3c-d00ad57fcece@google.com> References: <20231109062228.10227-1-ov.wagle@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 286C64000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: mm5t96cxd3bjmdkq1uyxidqgo6b13i1n X-HE-Tag: 1699515997-211199 X-HE-Meta: U2FsdGVkX1/wX0GD1EYmZ+tOWsgegff7w9gLUcMQXIpEwyoxCWn2Mc/GllyofdHr3Ukgq9q++pby8zL8Av2FKQtJ0GRXg9ex/FHsuWoLvD/GYcobX0wXRb2OitMWy5R5HHnUbsVcYiSW/NmxaQZr1OWResbIRlPgcDN0t9GIHmZAs0uA1Vh34ZEZU0112NiHtUzx/XwNpQnrJ4fZ9Zb7t9kdRy1c3F4M77gAZPFfBV+ylqrnDzwhCvC7PT/kMYWyfBwCagELKME31XIRs/FhKPeIINOEY3nD/GanYcpo3YMARI2z0q5fBTGUd4cgtLg8Vh8OrANuR5Vo0tb5JRbLOfp+0hgNrhm6AJ2PX7uwLhKabIloA6+X9BF1Cxif1AdCUPcK752Adv25ZSicDji9KOEzJ0ua8eDXpK+KBFBc2clLb69haDlavJj+FC8uK+X/6sekcdddSf6DdxopcYkk3WXETfYafdW1JlR8pqCLexs6+3tzPmvPJufz7QMZMinGVZ/Pc0wyPMZe9NIHNrYiDVXyEaUm1ZP914le0eoMj1JWtshm3kaQOGtO4v0kiU5GhaRst80LsRVnuJh5rRMLO3X59f4ZvHiFrrWcAe+7OU33kaQ3AE//ySY452cCNqPfqaIFHheGxi4eO/EowTXjK1k3v45gowuGla3EmXQxcuz0yS1dMY9hUJOQs55NTIJ+f+XXOm2QJ8OwY7ViL91JKXYLplG1eL1tiJ+R1Omu1+ATvmOvh5vMYvWFC0DnOWKD8xc9qkB0gM/4r6RsJMJUAjwvpcEXN9Z6QRS2KjTJF2lPmNNn4sj/iAHIHSW0L+g0QAmyFEX1WtIxEb3+81I7T8Nqdwbb6E1lDblZZHPa1EE8ISLSMof3r+Yhhmb62j2aqP1lQKRcKYXMCHxSrSB/uKHRaVKDhJprt3iso3RQZ3TCnqbCs4cXLhvzT2qTjGtX4jume1S+RsyuI/KC+Sg HxYyJmYy Awf7YDfFxMPKshK3LmI0Rur2GkNq5OqfwK6TjaoOTQ6IcO8Mu5xTfUnmLJJNyUSjmNqCo2hVJNSun5008eAf8CNylCfxp0dODbV4TFzt71eG/qB4b6FmkarDKwLUCba/m60wpXzD5esTmtFJy0hfwTtabiOo321TbsvTl7u+P6KLrE2bJuD9fjGX1fBsmd6rO+r9OForZHc4juqOgf/qMqTlyWAQkabDsijeuYDlf0H02oVfSyPwF0pz8Ygs7G1PQORg1VRcVr8MIv5LNQX+Jm/OvjiQrx4RPbWTVPcUYTJ410j+pIOxACVvro7ucaVH+485oxac1u7fabG/euRNGBwSmD7zI5rKr3+djF0TwM9RwO+1dt4dCNk/cnJZojXvF4wsSMEvScG+NJOpDBndxVEb1CAfIoTe9OOCN/r4dRKcK4wmeWpqEhTh15j5eshZZIsJWZ980jnYTonk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: mm not MM, style not sytle. On Wed, 8 Nov 2023, Omkar Wagle wrote: > Remove most of the code style warnings > > Signed-off-by: Omkar Wagle > --- > mm/shmem.c | 51 +++++++++++++++++++++++++++++++++------------------ > 1 file changed, 33 insertions(+), 18 deletions(-) Thanks for trying, but I'm sorry: very little of this is an improvement. Almost all of it is just adding a blank line in between declaration and code in some small block (including at least one from Linus himself). checkpatch does a good job of encouraging tidy patches, but it makes no claim to being right; and that particular nag annoys me more often than any other (though I often grudgingly give in to it, just for a quiet life - Cc'ing Matthew because I suspect he resents it even more than I do). And look at those fsparams: Al and others have gone to the trouble of lining them up nicely, but you've decided to undo their work. I believe it's explained somewhere (but admit that a quick look in Documentation didn't show me where), that checkpatch is something to run to tidy up your patches, or new source files (or perhaps even staging); but please don't send its advice on well-established source files. Hugh