From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 085E8C3DA4A for ; Tue, 20 Aug 2024 14:02:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81F1A6B0088; Tue, 20 Aug 2024 10:02:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CF876B0089; Tue, 20 Aug 2024 10:02:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 648906B008A; Tue, 20 Aug 2024 10:02:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 465286B0088 for ; Tue, 20 Aug 2024 10:02:16 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F0D0E1A01C9 for ; Tue, 20 Aug 2024 14:02:15 +0000 (UTC) X-FDA: 82472788230.19.229BB3F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 0627AA00C4 for ; Tue, 20 Aug 2024 14:01:49 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gl57pe8f; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724162422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=znabnRivu0IJNMc+xL9bcvze6M8IFubHKInix+JGtDI=; b=JICOynEuGdPl5vCXX1J+RsJUIS4Dcxt/o0DzIXLYvp0ZPAT68B3/KqZ5cDqBSo1c507FIy VWq58a2rwl7dP+kLjpE1nZuVDvhVw/Zdm/tII2RRSccijcoEQqqwonyQ/0OttjPSbr0/Vl kMRNCq7vXJnnClF4ZUCjR/2P5cfVZA8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724162422; a=rsa-sha256; cv=none; b=kG0IJsB6izv545ziyswcJ0NFonQ9JGYV/Joo771kAHxGZYUWGq+TdQcszt8nwCtjJqGToQ mdEGbceaP8NFdDWfjeqzirqjpwQpShb33FRYuCcn2d/UeeQo6ALTBvRRy1a1sKliJXyu97 UWpEC6MH+59WeJATBnusbN1HOFsEOIc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gl57pe8f; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724162509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=znabnRivu0IJNMc+xL9bcvze6M8IFubHKInix+JGtDI=; b=gl57pe8fOvYBbWLrd9oIx6fFuM9gUnS2K32KQXkWKPGNP2tO5xNk9tV7oOiuczMeiRrm4m nNjU7Rwc9ufRQtVdNZiZfzde4Hrbami/OWrG87n3EEd2MhnT2RYwYr/t0W+M436bx+K9sg rfYzXGqmpJwbs1OMMLvyy4LnlbvT05I= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-1mAkwvNXN-WDk2xgEaKT4g-1; Tue, 20 Aug 2024 10:01:47 -0400 X-MC-Unique: 1mAkwvNXN-WDk2xgEaKT4g-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3718e1d1847so3281387f8f.1 for ; Tue, 20 Aug 2024 07:01:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724162506; x=1724767306; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=znabnRivu0IJNMc+xL9bcvze6M8IFubHKInix+JGtDI=; b=k8GO08u87Ri/2xdqUyZkdpj9hTfUfXtyB2QAxL8hi7ZNly/zqYPoZxCDFxL088Q50K 0suXv8WVSr/EosIEeE04V/h2plMRqLzxIlCbzr87xf61A02mV6CCHuVwqYdrsz3hi7gF al4sZJ05jcNW90FUK1UNGFrNpEEKgiHt6Zx0zjggX4xGKQ2uZsV3GW+sRyH8AiYEsH/z RK3lkr2Iq4ot2287EzRoV+hcDZ+MhuMr0+GiCMQxJphtffNMFfjx03s8LQ2XzawNUFz8 4OzX+G+IgqTMPDnyD0hJyHNV3m2tq4QV6VF33DiCRRGSYNrWKFPvWM7RpmJkD1gg9FjC bDjg== X-Gm-Message-State: AOJu0Yz48ba1QX1gbi5F9HXR00JR7Y2Y4UJ2N7GF+1tI9jQf1rjiMFag 6ixP68UaVAQWSTfL7yZvVrUcbBfjTVt5D42swkM5ezIlpcD0q4zARnFXWJqwnu891VX5tbBF8HS N0rDZKReiqQUopkKDt3dWRqFjAdNTOfTDjhbuzaA459RmBMqA X-Received: by 2002:adf:fe03:0:b0:368:4def:921a with SMTP id ffacd0b85a97d-3719469f891mr10869017f8f.48.1724162506409; Tue, 20 Aug 2024 07:01:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLUxm96/6/nMsXHMFU+e2Sf0EGbV7Vdj/s0reoOO/dQSAB1ApZqtew1i/C643A0XThcz26Dw== X-Received: by 2002:adf:fe03:0:b0:368:4def:921a with SMTP id ffacd0b85a97d-3719469f891mr10868902f8f.48.1724162505186; Tue, 20 Aug 2024 07:01:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:e00:9c12:cdf2:bf1c:b8ed? (p200300cbc74b0e009c12cdf2bf1cb8ed.dip0.t-ipconnect.de. [2003:cb:c74b:e00:9c12:cdf2:bf1c:b8ed]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-371898aa229sm13251310f8f.88.2024.08.20.07.01.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 07:01:44 -0700 (PDT) Message-ID: <1348c6a5-f23c-4a25-921b-67262f0d919e@redhat.com> Date: Tue, 20 Aug 2024 16:01:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: remove migration for HugePage in isolate_single_pageblock() To: Kefeng Wang , Andrew Morton , Oscar Salvador , Zi Yan Cc: linux-mm@kvack.org, Matthew Wilcox References: <20240820032630.1894770-1-wangkefeng.wang@huawei.com> <5bf9cf7f-1c1b-42ec-be31-24b34024d599@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5bf9cf7f-1c1b-42ec-be31-24b34024d599@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0627AA00C4 X-Stat-Signature: g7smski5iqqrx1sgq374adqzwd3cpmn1 X-Rspam-User: X-HE-Tag: 1724162509-357037 X-HE-Meta: U2FsdGVkX1+Y8636vh7815/QX6v9PlXuVEmE3dkPjVCQvRWuULZYUgN9XWY7YQoTyv3x9KyhrdOakxJA3zPU++P/8Xh9BfFvFzEzs+IWwFtEfb4lhiposADciw5DnrVDNn5U0ATs9w3tivH128ecrxEV4iRCsVLO3PkeXlEv2JtzkAOtzdqQGZIV5CcojU19nh18aI3LD1JCTYuJqTLK+FfqVu1OuDv/uEJqPtiy65DzojDSYRdAJv2vmdXM6VAFO5BUwf7qJVzQ1V9RNThpcfZBixdofCkEU2R91xdk6HMr8/oSFqxvxA/acKf83AnH8JUKG7uz1PTJZPR/Pc4UGaVBHwzr7Nx1FfnjGVXrojuAo11mpAL8Fp5HhEjKBwJ8zV3NSTLhWcrDAVI6NZ7YPF2ljDWiiE6ZcIJ8ibciyNbtYfcQ8e281Trayx07M8cmXRvFNf2VrTrqL+iJ5MiMAmyqSMbRL8U7SfqNK2aWWvyCH5cjYn2/aO/TxhRv1VB2eVsTa39/te2yHBVh3rvKoN5n+Ixmy84RQr9BgAfil/UI7EiXZL24euOoG/PQrby0TUEa2tYo5w5jqYy0/QuvrpQkoFwU/gTMpoFZSiKCjhH34B+kp+PFPGVV9F1oHondrQ2MUyQRq6ZQvLkijolNLPZOfHgbBR56Ln1beJrd3TNOwIQ3+GgCxCkTYmuuyjyDuM/c60drvr6HDW1bg12B7SdOMiXsxAq4DPXl0PFow/pa0lFQTb+/kDzNTkXzxbmbOlMKLJfG/AG2vXZteO1NII+NoFO93oQclO0Uy7rouJpZF4p41U+CRyR0TOc9+iWprP879pYk+P18O+cfXlAI7Xz7YQb92A1Q6mPHkLuRA/2YvbTHP6RUdQF+9m7sCLPQB937Xv42o8IT0cxqDQEjZpKoHEVLPW5c1eHDY8kMQJ2KZVOHT/HUogp2t8v8T6kjI1N2B3BcK4dHMT4E5FE GWIDqiP+ JEDRSWO6ZifUoZAPjMRKnI+vMH9pgpY6o97vW3kf+nfsMmS+Jrhn/xjK0aSoaa6t7JJ0J5X3Hw0MHGblf679CkecCm1wsBN3CoI7s3J27tq2rz0lCpIftV6c3kn2CFgAZFcsQ+P+vOOra67PnSQH1Vvqp0c3Zeq99rhyIzkrOXTKJ9DrYJxaGYPom2gtf6roSHraveYVZ+kjN3NxyUXPAVoC/q0mVyoB/2P+Cdg30KzLwKNHre4x+mho+ldRnTTg+32bJLa+iRKSt+oAlmprtMQ/ZupygpJfiQ7zOmQZ/U+QTwJZG2bk5H01VnGXOw2vJ/1sOyZG4e+osOPcMKdnZSMi18WqpLJf521rgrrJj4rrzdm7xTjlPkz+J/DZl+lUvZfRUBYKdivOdmze36SIROno2sna9cyv6UaqKFDPqfQipSP8IHeTGGpk1WdzraqOjYHMYxUZpuWqcHguvvWo0yVR0xQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.08.24 16:00, Kefeng Wang wrote: > > > On 2024/8/20 16:42, David Hildenbrand wrote: >> On 20.08.24 05:26, Kefeng Wang wrote: >>> The gigantic page size may larger than memory block size, so memory >>> offline always fails in this case after commit b2c9e2fbba32 ("mm: make >>> alloc_contig_range work at pageblock granularity"), >>> >>> offline_pages >>>    start_isolate_page_range >>>      start_isolate_page_range(isolate_before=true) >>>        isolate [isolate_start, isolate_start + pageblock_nr_pages) >>>      start_isolate_page_range(isolate_before=false) >>>        isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock >>>             __alloc_contig_migrate_range >>>            isolate_migratepages_range >>>              isolate_migratepages_block >>>                isolate_or_dissolve_huge_page >>>                  if (hstate_is_gigantic(h)) >>>                      return -ENOMEM; >>> >>> [   15.815756] memory offlining [mem 0x3c0000000-0x3c7ffffff] failed >>> due to failure to isolate range >>> >>> Gigantic PageHuge is bigger than a pageblock, but since it is freed as >>> order-0 pages, its pageblocks after being freed will get to the right >>> free list. There is no need to have special handling code for them in >>> start_isolate_page_range(). For both alloc_contig_range() and memory >>> offline cases, the migration code after start_isolate_page_range() will >>> be able to migrate gigantic PageHuge when possible. >>> >>> Let's clean up start_isolate_page_range() and fix the aforementioned >>> memory offline failure issue all together. >>> >>> Fixes: b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock >>> granularity") >>> Signed-off-by: Kefeng Wang >>> --- > ... > >>> +            if (head_pfn + nr_pages <= boundary_pfn || >>> +                PageHuge(page)) { >> >> I'm wondering if we should have here some kind of WARN_ON_ONCE if >> PageLRU + "spans more than a single pageblock" check. >> >> Then we could catch whenever we would have !hugetlb LRU folios that span >> more than a single pageblock. >> >> /* >>  * We cannot currently handle movable (LRU) folios that span more than >>  * a single pageblock. hugetlb folios are fine, though. >>  */ >> WARN_ON_ONCE(PageLRU(page) && nr_pages > pageblock_nr_pages > > This should be already covered by following VM_WRAN, > > VM_WARN_ON_ONCE_PAGE(PageLRU(page), page); // only hint when head_pfn > + nr_pages > boundary_pfn ( boundary_pfn is pageblock aligned) Ahh, good! -- Cheers, David / dhildenb