linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Josh Triplett <josh@joshtriplett.org>, Tejun Heo <tj@kernel.org>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, paul.gortmaker@windriver.com
Subject: Re: [RFC 1/4] hashtable: introduce a small and naive hashtable
Date: Thu, 02 Aug 2012 19:48:37 +0200	[thread overview]
Message-ID: <1343929717.9299.358.camel@edumazet-glaptop> (raw)
In-Reply-To: <CA+55aFw_dwO5ZOuaz9eDxgnTZFDGVZKSLUTm5Fn99faALxxJRQ@mail.gmail.com>

On Thu, 2012-08-02 at 10:32 -0700, Linus Torvalds wrote:
> On Thu, Aug 2, 2012 at 9:40 AM, Eric W. Biederman <ebiederm@xmission.com> wrote:
> >
> > For a trivial hash table I don't know if the abstraction is worth it.
> > For a hash table that starts off small and grows as big as you need it
> > the incent to use a hash table abstraction seems a lot stronger.
> 
> I'm not sure growing hash tables are worth it.
> 
> In the dcache layer, we have an allocated-at-boot-time sizing thing,
> and I have been playing around with a patch that makes the hash table
> statically sized (and pretty small). And it actually speeds things up!

By the way, anybody tried to tweak vmalloc() (or
alloc_large_system_hash()) to use HugePages for those large hash
tables ?



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-08-02 17:48 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31 18:05 [RFC 0/4] generic hashtable implementation Sasha Levin
2012-07-31 18:05 ` [RFC 1/4] hashtable: introduce a small and naive hashtable Sasha Levin
2012-07-31 18:23   ` Tejun Heo
2012-07-31 20:31     ` Sasha Levin
2012-08-01 18:19     ` Sasha Levin
2012-08-01 18:21       ` Tejun Heo
2012-08-01 18:24         ` Sasha Levin
2012-08-01 18:27           ` Tejun Heo
2012-08-01 19:06             ` Sasha Levin
2012-08-01 20:24               ` Tejun Heo
2012-08-01 22:41                 ` Sasha Levin
2012-08-01 22:45                   ` Tejun Heo
2012-08-02 10:00                     ` Sasha Levin
2012-08-02 10:32                       ` Josh Triplett
2012-08-02 11:23                         ` Sasha Levin
2012-08-02 13:04                           ` Sasha Levin
2012-08-02 16:15                             ` Josh Triplett
2012-08-02 16:48                               ` Sasha Levin
2012-08-02 17:44                                 ` Josh Triplett
2012-08-02 17:54                                   ` Sasha Levin
2012-08-02 20:41                                     ` Josh Triplett
2012-08-02 21:47                                       ` Sasha Levin
2012-08-03 17:59                                         ` Josh Triplett
2012-08-02 16:03                           ` Eric W. Biederman
2012-08-02 16:34                             ` Sasha Levin
2012-08-02 16:40                               ` Eric W. Biederman
2012-08-02 17:32                                 ` Linus Torvalds
2012-08-02 17:48                                   ` Eric Dumazet [this message]
2012-08-02 17:59                                   ` Josh Triplett
2012-08-02 18:08                                     ` Linus Torvalds
2012-08-02 20:25                                       ` Josh Triplett
2012-08-02 20:32                                         ` Linus Torvalds
2012-08-02 21:21                                           ` Josh Triplett
2012-08-02 21:50                                             ` Linus Torvalds
2012-08-02  9:35             ` Josh Triplett
2012-07-31 18:05 ` [RFC 2/4] user_ns: use new hashtable implementation Sasha Levin
2012-07-31 18:05 ` [RFC 3/4] mm,ksm: " Sasha Levin
2012-07-31 18:05 ` [RFC 4/4] workqueue: " Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343929717.9299.358.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=josh@joshtriplett.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox