From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx103.postini.com [74.125.245.103]) by kanga.kvack.org (Postfix) with SMTP id 4FCCA6B004D for ; Fri, 27 Jul 2012 15:31:23 -0400 (EDT) Message-ID: <1343417470.32120.39.camel@twins> Subject: Re: [PATCH 4/6] rbtree: faster augmented insert From: Peter Zijlstra Date: Fri, 27 Jul 2012 21:31:10 +0200 In-Reply-To: <1342787467-5493-5-git-send-email-walken@google.com> References: <1342787467-5493-1-git-send-email-walken@google.com> <1342787467-5493-5-git-send-email-walken@google.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Michel Lespinasse Cc: riel@redhat.com, daniel.santos@pobox.com, aarcange@redhat.com, dwmw2@infradead.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Fri, 2012-07-20 at 05:31 -0700, Michel Lespinasse wrote: >=20 > rb_insert_color() is now a special case of rb_insert_augmented() with > a do-nothing callback. I used inlining to optimize out the callback, > with the intent that this would generate the same code as previously > for rb_insert_augmented(). This didn't fully work, as my compiler output > is now *smaller* than before for that function. Speed wise, they seem > comparable though.=20 It might be good to mention which particular GCC you're using. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org