From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2150EE0204 for ; Wed, 11 Sep 2024 03:53:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F5F590000B; Tue, 10 Sep 2024 23:53:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A6128D00E2; Tue, 10 Sep 2024 23:53:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5942C90000B; Tue, 10 Sep 2024 23:53:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3B48C8D00E2 for ; Tue, 10 Sep 2024 23:53:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8F5FFA0D41 for ; Wed, 11 Sep 2024 03:53:07 +0000 (UTC) X-FDA: 82551086814.25.23541F6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 9C537100005 for ; Wed, 11 Sep 2024 03:53:05 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726026781; a=rsa-sha256; cv=none; b=57vo/lJmw/nsat9cYUpGjWdOXdAEbYqvwKCkCKVpw8qYev8GiocY/8s+s/7wxz/GHm5z5t n0OsS0dhQ/sKSMi4+PC64dmZ1uWIvect5Cczz68zgwMQiUa3+4TvD+bDinqhFECro9qdYM rSOBFmznXS1sAJHYLKX9ooAywSVHXJs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726026781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H133mAt3byb4iAcRjtf9LoNxz7xnNHUF3B+cwyjXO+c=; b=nWWcYTU/BSwfl9KFjKn3+1T1CBHWeUiU0LsB/PkFVyPKdPVA2w+ZLcu2OrCLPB7i2ijcWz 1rk4GybWYKu19Uo6dBvfaEUW/S3XAVvW7u6XnQtDPbP6zA47blpdZSfMEo+48/Q4Y2dq85 /mbZGOF7A3/lw5CJxQHyNd7nb3BWRuM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26F341063; Tue, 10 Sep 2024 20:53:34 -0700 (PDT) Received: from [10.162.42.11] (a077893.blr.arm.com [10.162.42.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8F43C3F66E; Tue, 10 Sep 2024 20:53:02 -0700 (PDT) Message-ID: <1340d57f-3f4e-4873-aa66-e93d3a8f3394@arm.com> Date: Wed, 11 Sep 2024 09:22:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] mm: Drop unused set_pte_safe() To: Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand , Ryan Roberts , "Mike Rapoport (IBM)" , linux-kernel@vger.kernel.org References: <20240910101026.428808-1-anshuman.khandual@arm.com> <20240910131355.8f56f86045c745cee7a97f85@linux-foundation.org> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240910131355.8f56f86045c745cee7a97f85@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: bhzoytrdn91czngowqsox8s845ge1879 X-Rspamd-Queue-Id: 9C537100005 X-Rspamd-Server: rspam02 X-HE-Tag: 1726026785-254850 X-HE-Meta: U2FsdGVkX1+Zu65Gx6ZuxBf6M3ZvsQpGzOTqmZCArDj1KsWGWtFlhfRj51Q4BuRaihBsHASFZ+i/DGRd8daXCHmF3zdb1zOvgKUYPv3ic5zQSDNIAh7oFT0X+bcues8Xw16OHxKr2PVWH9/eVPiHBiIumifuD94q2nhZhXkRK8fcYbwB2xionNuLg95g8IuswYWIE/I0ZeQzXYvWOeTJvm9cK04e2m9EiUkRWmkxgaMNErcMZTNZJv8hZNTrPVci7NhEp66o8bURUa652B4a3M0YqyJiVkVuuCfKxI67NGxIRSzhrJHRn1mEV05eaqnkvsyXY1Gx4ki1BXhRA7ZHAHRTVXWwb8hjz1AyzcOtJpdj5EDu69VC9Bgr2fwi2t3e+AEdL2mp0pE3OvZZRbxaerNUO33DT6T6RBxi30bCU9ldPWVukE1b4GasDpM1Sn4SvLdLvbmGVJhZbvIZkCM19EJp58TT5YRFPZ0juVuxvzP8yZIL4qsgcT1sYN8ctk8LBfC/5CCf7tBS4zJ9rJfjbr6Wdi0Y+5DRCe374QRM1oupeiwQ02EnOXcyXxBLMASy6q0/KzYkGWU6foMI+ZeVkdPiARHz/ZkuY/YphmsHRlMC8C4SO8N28vzfX4adK9d/r7Win6//Qxc4UGWxHXd67MO7gnOtQFKT4r6eFjN5vbh2Al31AO05LtkHUSZHeQcYUa1AgjuM5i4e6VnM11r393d6YXDwEVPvo/K2KB7pPGD4Yc+DOFULfPK3yHVZooZNH82HK5XEE2svEIgI6u/qfrRk78JqBG7M6s76jHYmazU0PTGxOzQibpyyiUvtdzgwfAakhwSDaooQyVMFyVx+5UHRRP39c71wCIsUQitKGtsMXp4kY5k/dfirvBTMChxFBflzeNdbpeL/1Eq0T9qGnh25BwP/JGpAFze+WzZ1LRy6rtKvEs50eran2+M63aOrwKnWZRW4jRDvwI0iEtZ ZNcgBx5E DEjnA4PtMwOsgwqIa6dw6rEYYoLI1gOC8ifjzuxYOgAuvItWrF+HdoJmbox2UBcmac7TR0wTa+DYM5IZ9ie2sGq0YD37FlXOCuRaza3UC94GMKw6C1KYXJ0/q8LrClDhiIjJxIlQEpqOzTW8Gwsr9obcpen2omEWy5INfwI+miR1BX7OXrW2nytal8ybjqW81KgVaHayy+DlniRn2lnFMSPp9UVJ3B8Uyw31iafR0iSn5NDz+VkO1waQ3hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/11/24 01:43, Andrew Morton wrote: > On Tue, 10 Sep 2024 15:40:26 +0530 Anshuman Khandual wrote: > >> All set_pte_safe() usage have been dropped after the commit eccd906484d1 >> ("x86/mm: Do not use set_{pud, pmd}_safe() when splitting a large page") >> This just drops now unused helper set_pte_safe(). >> >> Besides this macro was buggy due to doing direct dereferencing of the pte, >> and if it were to be kept, it should have been updated to use a single call >> to ptep_get(). >> > > arch/x86/mm/init_64.c: In function 'set_pte_init': > arch/x86/mm/init_64.c:83:17: error: implicit declaration of function 'set_pte_safe'; did you mean 'set_pmd_safe'? [-Werror=implicit-function-declaration] > 83 | set_##type1##_safe(arg1, arg2); \ > | ^~~~ > arch/x86/mm/init_64.c:91:1: note: in expansion of macro 'DEFINE_ENTRY' > 91 | DEFINE_ENTRY(pte, pte, init) > | ^~~~~~~~~~~~ kernel_physical_mapping_init() __kernel_physical_mapping_init(, init = true) phys_p4d_init(, init = true) phys_pud_init(, init = true) phys_pmd_init(, init = true) phys_pte_init(, init = true) pte_init(, init = true) set_pte_safe() Right, seems like there is a path to set_pte_safe(). Sure, will drop this patch and convert the direct access into ptep_get() instead.