From: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Tejun Heo <tj@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Ian Campbell <ian.campbell@citrix.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [PATCH 7/7] highmem: avoid page_address() in flush_all_zero_pkmaps()
Date: Wed, 6 Jun 2012 16:15:01 +0800 [thread overview]
Message-ID: <1338970501-5098-7-git-send-email-laijs@cn.fujitsu.com> (raw)
In-Reply-To: <1338970501-5098-1-git-send-email-laijs@cn.fujitsu.com>
We can get the virtual address from PKMAP_ADDR(i),
we don't need to call page_address() here.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
mm/highmem.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/mm/highmem.c b/mm/highmem.c
index 6f028cb..994fd68 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -103,8 +103,6 @@ static void flush_all_zero_pkmaps(void)
flush_cache_kmaps();
for (i = 0; i < LAST_PKMAP; i++) {
- struct page *page;
-
/*
* zero means we don't have anything to do,
* >1 means that it is still in use. Only
@@ -125,9 +123,7 @@ static void flush_all_zero_pkmaps(void)
* getting the kmap_lock (which is held here).
* So no dangers, even with speculative execution.
*/
- page = pte_page(pkmap_page_table[i]);
- pte_clear(&init_mm, (unsigned long)page_address(page),
- &pkmap_page_table[i]);
+ pte_clear(&init_mm, PKMAP_ADDR(i), &pkmap_page_table[i]);
clear_high_page_map(i);
need_flush = 1;
--
1.7.7
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-06-06 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 8:14 [PATCH 1/7] highmem: rearrange export symbol of __kmap_atomic_idx Lai Jiangshan
2012-06-06 8:14 ` [PATCH 2/7] highmem: rearrange the comments of pkmap_count Lai Jiangshan
2012-06-06 8:14 ` [PATCH 3/7] highmem: remove set_page_address() Lai Jiangshan
2012-06-06 8:14 ` [PATCH 4/7] highmem: remove pool_lock Lai Jiangshan
2012-06-06 8:14 ` [PATCH 5/7] highmem: direct struct page_address_map allocation Lai Jiangshan
2012-06-06 8:15 ` [PATCH 6/7] highmem: remove ->virtual from struct page_address_map Lai Jiangshan
2012-06-06 8:15 ` Lai Jiangshan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338970501-5098-7-git-send-email-laijs@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@linux.intel.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=mingo@elte.hu \
--cc=paul.gortmaker@windriver.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox