From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx150.postini.com [74.125.245.150]) by kanga.kvack.org (Postfix) with SMTP id 4F6686B0071 for ; Wed, 6 Jun 2012 04:15:22 -0400 (EDT) From: Lai Jiangshan Subject: [PATCH 4/7] highmem: remove pool_lock Date: Wed, 6 Jun 2012 16:14:58 +0800 Message-Id: <1338970501-5098-4-git-send-email-laijs@cn.fujitsu.com> In-Reply-To: <1338970501-5098-1-git-send-email-laijs@cn.fujitsu.com> References: <1338970501-5098-1-git-send-email-laijs@cn.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: Cc: Ingo Molnar , Peter Zijlstra , Tejun Heo , Al Viro , "H. Peter Anvin" , Ian Campbell , Paul Gortmaker , Mel Gorman , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lai Jiangshan The accesses to the pool are always in kmap_lock critical region, thus pool_lock is not needed. Signed-off-by: Lai Jiangshan --- mm/highmem.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/mm/highmem.c b/mm/highmem.c index b6ce085..bf7f168 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -316,7 +316,6 @@ struct page_address_map { * page_address_map freelist, allocated from page_address_maps. */ static struct list_head page_address_pool; /* freelist */ -static spinlock_t pool_lock; /* protects page_address_pool */ /* * Hash table bucket @@ -383,11 +382,9 @@ static void set_high_page_address(struct page *page, void *virtual) if (virtual) { /* Add */ BUG_ON(list_empty(&page_address_pool)); - spin_lock_irqsave(&pool_lock, flags); pam = list_entry(page_address_pool.next, struct page_address_map, list); list_del(&pam->list); - spin_unlock_irqrestore(&pool_lock, flags); pam->page = page; pam->virtual = virtual; @@ -401,9 +398,7 @@ static void set_high_page_address(struct page *page, void *virtual) if (pam->page == page) { list_del(&pam->list); spin_unlock_irqrestore(&pas->lock, flags); - spin_lock_irqsave(&pool_lock, flags); list_add_tail(&pam->list, &page_address_pool); - spin_unlock_irqrestore(&pool_lock, flags); goto done; } } @@ -426,7 +421,6 @@ void __init page_address_init(void) INIT_LIST_HEAD(&page_address_htable[i].lh); spin_lock_init(&page_address_htable[i].lock); } - spin_lock_init(&pool_lock); } #endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */ -- 1.7.7 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org