From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx161.postini.com [74.125.245.161]) by kanga.kvack.org (Postfix) with SMTP id 4052E6B005C for ; Tue, 29 May 2012 12:30:44 -0400 (EDT) Message-ID: <1338309029.26856.123.camel@twins> Subject: Re: [PATCH 30/35] autonuma: reset autonuma page data when pages are freed From: Peter Zijlstra Date: Tue, 29 May 2012 18:30:29 +0200 In-Reply-To: <1337965359-29725-31-git-send-email-aarcange@redhat.com> References: <1337965359-29725-1-git-send-email-aarcange@redhat.com> <1337965359-29725-31-git-send-email-aarcange@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Andrea Arcangeli Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Rik van Riel , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter On Fri, 2012-05-25 at 19:02 +0200, Andrea Arcangeli wrote: > When pages are freed abort any pending migration. If knuma_migrated > arrives first it will notice because get_page_unless_zero would fail. But knuma_migrated can run on a different cpu than this free is happening, ACCESS_ONCE() won't cure that. What's that ACCESS_ONCE() good for? Also, you already have an autonuma_ hook right there, why add more #ifdeffery ? > Signed-off-by: Andrea Arcangeli > --- > mm/page_alloc.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) >=20 > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3d1ee70..1d3163f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -614,6 +614,10 @@ static inline int free_pages_check(struct page *page= ) > bad_page(page); > return 1; > } > + autonuma_migrate_page_remove(page); > +#ifdef CONFIG_AUTONUMA > + ACCESS_ONCE(page->autonuma_last_nid) =3D -1; > +#endif > if (page->flags & PAGE_FLAGS_CHECK_AT_PREP) > page->flags &=3D ~PAGE_FLAGS_CHECK_AT_PREP; > return 0; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org