From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>,
Glauber Costa <glommer@parallels.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] slab+slob: dup name string
Date: Wed, 23 May 2012 12:46:35 +0100 [thread overview]
Message-ID: <1337773595.3013.15.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205221529340.18325@chino.kir.corp.google.com>
On Tue, 2012-05-22 at 15:31 -0700, David Rientjes wrote:
> On Tue, 22 May 2012, Christoph Lameter wrote:
>
> > > I think that's precisely David's point: that we might want to destroy them
> > > eventually.
> >
> > Cannot imagine why.
> >
>
> We can't predict how slab will be extended in the future and this affects
> anything created before g_cpucache_cpu <= EARLY. This would introduce the
> first problem with destroying such caches and is unnecessary if a
> workaround exists.
These problems seem to indicate that the slab behaviour: expecting the
string to exist for the lifetime of the cache so there's no need to copy
it might be better.
This must be the behaviour all users of kmem_cache_create() expect
anyway, since all enterprise distributions use slab and they're not
getting bugs reported in this area.
So, why not simply patch slab to rely on the string lifetime being the
cache lifetime (or beyond) and therefore not having it take a copy?
James
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-23 11:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 15:18 Glauber Costa
2012-05-21 15:35 ` Christoph Lameter
2012-05-22 3:22 ` David Rientjes
2012-05-22 7:23 ` Glauber Costa
2012-05-22 9:45 ` Glauber Costa
2012-05-22 13:56 ` Christoph Lameter
2012-05-22 15:19 ` Glauber Costa
2012-05-22 17:16 ` Christoph Lameter
2012-05-22 22:31 ` David Rientjes
2012-05-23 11:46 ` James Bottomley [this message]
2012-05-23 12:08 ` Glauber Costa
2012-05-23 12:24 ` James Bottomley
2012-05-23 14:48 ` Christoph Lameter
2012-05-23 14:50 ` Glauber Costa
2012-05-24 0:18 ` Dave Chinner
2012-05-24 12:06 ` Glauber Costa
2012-05-23 15:01 ` Glauber Costa
2012-05-23 15:17 ` Christoph Lameter
2012-05-23 15:15 ` Glauber Costa
2012-05-23 13:48 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337773595.3013.15.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox