From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx207.postini.com [74.125.245.207]) by kanga.kvack.org (Postfix) with SMTP id 335918D0010 for ; Fri, 11 May 2012 13:48:06 -0400 (EDT) From: Glauber Costa Subject: [PATCH v2 02/29] slub: fix slab_state for slub Date: Fri, 11 May 2012 14:44:04 -0300 Message-Id: <1336758272-24284-3-git-send-email-glommer@parallels.com> In-Reply-To: <1336758272-24284-1-git-send-email-glommer@parallels.com> References: <1336758272-24284-1-git-send-email-glommer@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-kernel@vger.kernel.org Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel@openvz.org, Glauber Costa , Christoph Lameter , Pekka Enberg When the slub code wants to know if the sysfs state has already been initialized, it tests for slab_state == SYSFS. This is quite fragile, since new state can be added in the future (it is, in fact, for memcg caches). This patch fixes this behavior so the test matches >= SYSFS, as all other state does. Signed-off-by: Glauber Costa CC: Christoph Lameter CC: Pekka Enberg --- mm/slub.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index ffe13fd..226e053 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5356,7 +5356,7 @@ static int sysfs_slab_alias(struct kmem_cache *s, const char *name) { struct saved_alias *al; - if (slab_state == SYSFS) { + if (slab_state >= SYSFS) { /* * If we have a leftover link then remove it. */ -- 1.7.7.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org