From: Eric Dumazet <eric.dumazet@gmail.com>
To: Don Morris <don.morris@hp.com>
Cc: Waiman Long <Waiman.Long@hp.com>,
cl@linux-foundation.org, penberg@kernel.org, mpm@selenic.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slub: prevent validate_slab() error due to race condition
Date: Thu, 26 Apr 2012 21:44:11 +0200 [thread overview]
Message-ID: <1335469451.2775.64.camel@edumazet-glaptop> (raw)
In-Reply-To: <4F999FFB.3070408@hp.com>
On Thu, 2012-04-26 at 12:20 -0700, Don Morris wrote:
> Note that he sets n here, hence the if() block on 2458 can not
> be taken (!n fails) and the if(likely(!n)) is not taken for the
> same reason. As such, the code falls through to the returns for
> either the slab being empty (or not) where the node lock is
> released (2529 / 2543).
Ah yes, you're right, thanks for clarification.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-26 19:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 18:57 Waiman Long
2012-04-26 19:12 ` Eric Dumazet
2012-04-26 19:20 ` Don Morris
2012-04-26 19:44 ` Eric Dumazet [this message]
2012-04-27 14:59 ` Christoph Lameter
2012-04-27 20:10 ` Waiman Long
2012-04-30 6:35 ` Pekka Enberg
2012-05-01 20:23 ` Christoph Lameter
[not found] ` <alpine.LFD.2.02.1205300946170.2681@tux.localdomain>
[not found] ` <alpine.DEB.2.00.1205301039420.29257@router.home>
2012-05-30 17:54 ` Christoph Lameter
2012-08-16 7:02 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335469451.2775.64.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=Waiman.Long@hp.com \
--cc=cl@linux-foundation.org \
--cc=don.morris@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox