linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: linux-mm@kvack.org
Cc: mgorman@suse.de,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: [PATCH 1/2] mm: compaction: try harder to isolate free pages
Date: Thu, 05 Apr 2012 18:32:12 +0200	[thread overview]
Message-ID: <1333643534-1591-2-git-send-email-b.zolnierkie@samsung.com> (raw)
In-Reply-To: <1333643534-1591-1-git-send-email-b.zolnierkie@samsung.com>

In isolate_freepages() check each page in a pageblock
instead of checking only first pages of pageblock_nr_pages
intervals (suitable_migration_target(page) is called before
isolate_freepages_block() so if page is "unsuitable" whole
pageblock_nr_pages pages will be ommited from the check).
It greatly improves possibility of finding free pages to
isolate during compaction_alloc() phase.

Cc: Mel Gorman <mgorman@suse.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 mm/compaction.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index d9ebebe..bc77135 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -65,7 +65,7 @@ static unsigned long isolate_freepages_block(struct zone *zone,
 
 	/* Get the last PFN we should scan for free pages at */
 	zone_end_pfn = zone->zone_start_pfn + zone->spanned_pages;
-	end_pfn = min(blockpfn + pageblock_nr_pages, zone_end_pfn);
+	end_pfn = min(blockpfn + 1, zone_end_pfn);
 
 	/* Find the first usable PFN in the block to initialse page cursor */
 	for (; blockpfn < end_pfn; blockpfn++) {
@@ -160,8 +160,7 @@ static void isolate_freepages(struct zone *zone,
 	 * pages on cc->migratepages. We stop searching if the migrate
 	 * and free page scanners meet or enough free pages are isolated.
 	 */
-	for (; pfn > low_pfn && cc->nr_migratepages > nr_freepages;
-					pfn -= pageblock_nr_pages) {
+	for (; pfn > low_pfn && cc->nr_migratepages > nr_freepages; pfn--) {
 		unsigned long isolated;
 
 		if (!pfn_valid(pfn))
-- 
1.7.9.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-04-05 16:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-05 16:32 [PATCH 0/2] mm: compaction: improve free pages selection Bartlomiej Zolnierkiewicz
2012-04-05 16:32 ` Bartlomiej Zolnierkiewicz [this message]
2012-04-06  6:40   ` [PATCH 1/2] mm: compaction: try harder to isolate free pages Minchan Kim
2012-04-06  8:21     ` Bartlomiej Zolnierkiewicz
2012-04-06  8:51       ` Minchan Kim
2012-04-10 10:38   ` Mel Gorman
2012-04-12  5:42     ` Mel Gorman
2012-04-05 16:32 ` [PATCH 2/2] mm: compaction: allow isolation of lower order buddy pages Bartlomiej Zolnierkiewicz
2012-04-05 21:46   ` David Rientjes
2012-04-06  8:38     ` Bartlomiej Zolnierkiewicz
2012-04-06  6:45   ` Minchan Kim
2012-04-10 10:40   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333643534-1591-2-git-send-email-b.zolnierkie@samsung.com \
    --to=b.zolnierkie@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox